Date: Wed, 7 Sep 2005 00:21:20 +0900 From: "R. Imura" <imura@ryu16.org> To: Pyun YongHyeon <pyunyh@gmail.com> Cc: John Nielsen <john@jnielsen.net>, freebsd-sparc64@freebsd.org Subject: Re: "fast data access mmu miss" on kernels w/o "makeoptions DEBUG=-g" Message-ID: <20050906152119.GA49672%imura@ryu16.org> In-Reply-To: <20050829031058.GA871@rndsoft.co.kr> References: <200508230911.18163.john@jnielsen.net> <20050824010147.GD4956@rndsoft.co.kr> <20050824143940.GA65078%imura@ryu16.org> <20050824191437.A36508@newtrinity.zeist.de> <20050827055841.GB83681%imura@ryu16.org> <20050827145503.G19225@newtrinity.zeist.de> <20050827132008.GA28954%imura@ryu16.org> <20050827153704.H19225@newtrinity.zeist.de> <20050827140525.GA29949%imura@ryu16.org> <20050829031058.GA871@rndsoft.co.kr>
next in thread | previous in thread | raw e-mail | index | archive | help
On Mon, Aug 29, 2005 at 12:10:58PM +0900, Pyun YongHyeon wrote: > Supporting smbfs on sparc64 is on my TODO list. But it's priority > is low due to a lack of time and other pending works. Based on > NetBSD's changes I managed to build smbfs. But it didn't work and it > needs more investigation. While reading the code I noticed there > is a bug in smbfs_hash() in sys/fs/smbfs/smbfs_node.c. NetBSD > switched to use hash32_strn() defined in <sys/hash.h>. I think it > also has influence on our implementation. Would you please check > the function? > (http://cvsweb.netbsd.org/bsdweb.cgi/src/sys/fs/smbfs/smbfs_node.c, rev. 1.12) IMHO, we are not fully required to fix this problem at first because the mission of smbfs_hash() is to create unique i-node number. (however smbfs_hash can be replaced by any hash algorithm, though. Our smbfs_hash is called FNV hash according to google.) I hope you also look at Darwin's code, because I believe it may bring us some benefit easily if we keep differences small between Darwin's and ours, since Darwin has many improvement. For example, NetBSD had introduced SMBRQ_PUTLE16 macro but Darwin hadn't. I think this doesn't mean SMBRQ_PUTLE16 is an essential feature. BSD licensed Darwin's smbfs can be found at http://darwinsource.opendarwin.org/ . BTW, I found we can obtain macros from NetBSD in contrib/smbfs/include/netsmb/smb_lib.h. - R. Imura
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20050906152119.GA49672%imura>