From owner-cvs-sys Fri Aug 29 19:24:54 1997 Return-Path: Received: (from root@localhost) by hub.freebsd.org (8.8.7/8.8.7) id TAA12839 for cvs-sys-outgoing; Fri, 29 Aug 1997 19:24:54 -0700 (PDT) Received: from godzilla.zeta.org.au (godzilla.zeta.org.au [203.2.228.19]) by hub.freebsd.org (8.8.7/8.8.7) with ESMTP id TAA12834; Fri, 29 Aug 1997 19:24:43 -0700 (PDT) Received: (from bde@localhost) by godzilla.zeta.org.au (8.8.5/8.6.9) id MAA02715; Sat, 30 Aug 1997 12:18:42 +1000 Date: Sat, 30 Aug 1997 12:18:42 +1000 From: Bruce Evans Message-Id: <199708300218.MAA02715@godzilla.zeta.org.au> To: kato@FreeBSD.ORG, smp@csn.net Subject: Re: cvs commit: src/sys/i386/include param.h Cc: cvs-all@FreeBSD.ORG, cvs-committers@FreeBSD.ORG, cvs-sys@FreeBSD.ORG Sender: owner-cvs-sys@FreeBSD.ORG X-Loop: FreeBSD.org Precedence: bulk >machine/param.h has what should be a separate .h file appended to it as: > >#ifndef _SIMPLELOCK_H_ >#define _SIMPLELOCK_H_ > ... >#endif /* !_SIMPLELOCK_H_ */ > >I would like to take this section and move it to new file: machine/simplelock.h Me too (except perhaps it should be named machine/lock.h). >This would break a lot of files that currently get this info from param.h. To >get around this in the beginning I would just add: > >#include to the end of param.h until all the files >requiring it are found and fixed. I think should just be included in . depends on the full `struct simplelock' being defined, so nothing would be lost by this. I tried removing the simplelock declarations completely. This broke only 175 of 568 objects in LINT, mostly for sources that include . is included for approx. 171 of the objects in LINT, so all except approx. 4 cases can be handled by the nested include. It also broke everything that includes , even in the !KERNEL case when struct simplelock is not required, because includes in all cases. Bruce