From owner-cvs-all Wed Nov 13 21:27:44 2002 Delivered-To: cvs-all@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 10A3337B404 for ; Wed, 13 Nov 2002 21:27:43 -0800 (PST) Received: from rootlabs.com (root.org [67.118.192.226]) by mx1.FreeBSD.org (Postfix) with SMTP id E6AC343E7B for ; Wed, 13 Nov 2002 21:27:37 -0800 (PST) (envelope-from nate@rootlabs.com) Received: (qmail 42019 invoked by uid 1000); 14 Nov 2002 05:27:39 -0000 Date: Wed, 13 Nov 2002 21:27:39 -0800 (PST) From: Nate Lawson To: "M. Warner Losh" Cc: sobomax@FreeBSD.org, silby@silby.com, cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/bin/sleep sleep.c In-Reply-To: <20021113.215346.90827277.imp@bsdimp.com> Message-ID: MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG On Wed, 13 Nov 2002, M. Warner Losh wrote: > In message: <20021113204503.GI9006@vega.vega.com> > Maxim Sobolev writes: > : On Wed, Nov 13, 2002 at 03:32:13PM -0500, Mike Silbersack wrote: > : > > : > On Wed, 13 Nov 2002, Nate Lawson wrote: > : > > : > > njl 2002/11/13 12:12:26 PST > : > > > : > > Modified files: > : > > bin/sleep sleep.c > : > > Log: > : > > Remove getopt and strtol dependencies, reducing size of static exe. > : > > Preserve older desired behavior, accept [+-]*[0-9]*\.[0-9]* > : > > Remove a few unnecessary casts. > : > > : > Please don't commit crap like this. While having smaller binaries might > : > be nice, being entered into an obfuscated C contest is not one of the > : > goals of FreeBSD. > : > : I fully agree - HDD space is pretty cheap today, while embedded folks > : should use other means to reduce footprint (e.g crunchgen). Actually > : in the case of crunchgen this commit worsens situation, as the code > : is no longer shared. > > It also makes the dynamic binary larger for the folks that have / and > /usr on the same partition and dynamically link /sbin and /bin. Much > more bang for the buck that these silly micro-optimizations. So this > is a negative thing as far as I'm concerned. :-( Please read the commit message for my 2nd version. It uses 8 bytes less dynamically linked than v1.12 and 40k less statically linked. The first version was slightly larger than v1.12 dynamically linked (1k). I backed out the first version. -Nate To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message