From owner-dev-commits-src-all@freebsd.org Tue Sep 14 22:45:24 2021 Return-Path: Delivered-To: dev-commits-src-all@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id D42A36727AF; Tue, 14 Sep 2021 22:45:24 +0000 (UTC) (envelope-from kostikbel@gmail.com) Received: from kib.kiev.ua (kib.kiev.ua [IPv6:2001:470:d5e7:1::1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 4H8JMm3CFBz4YDg; Tue, 14 Sep 2021 22:45:24 +0000 (UTC) (envelope-from kostikbel@gmail.com) Received: from tom.home (kib@localhost [127.0.0.1]) by kib.kiev.ua (8.16.1/8.16.1) with ESMTPS id 18EMjG7I004715 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NO); Wed, 15 Sep 2021 01:45:19 +0300 (EEST) (envelope-from kostikbel@gmail.com) DKIM-Filter: OpenDKIM Filter v2.10.3 kib.kiev.ua 18EMjG7I004715 Received: (from kostik@localhost) by tom.home (8.16.1/8.16.1/Submit) id 18EMjGYo004712; Wed, 15 Sep 2021 01:45:16 +0300 (EEST) (envelope-from kostikbel@gmail.com) X-Authentication-Warning: tom.home: kostik set sender to kostikbel@gmail.com using -f Date: Wed, 15 Sep 2021 01:45:16 +0300 From: Konstantin Belousov To: Edward Tomasz Napierala Cc: src-committers@freebsd.org, dev-commits-src-all@freebsd.org, dev-commits-src-main@freebsd.org Subject: Re: git: bdf0f24bb16d - main - linux: implement PTRACE_GET_SYSCALL_INFO Message-ID: References: <202109142041.18EKf6RU040962@gitrepo.freebsd.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <202109142041.18EKf6RU040962@gitrepo.freebsd.org> X-Spam-Status: No, score=-1.0 required=5.0 tests=ALL_TRUSTED,BAYES_00, DKIM_ADSP_CUSTOM_MED,FORGED_GMAIL_RCVD,FREEMAIL_FROM, NML_ADSP_CUSTOM_MED autolearn=no autolearn_force=no version=3.4.5 X-Spam-Checker-Version: SpamAssassin 3.4.5 (2021-03-20) on tom.home X-Rspamd-Queue-Id: 4H8JMm3CFBz4YDg X-Spamd-Bar: ---- Authentication-Results: mx1.freebsd.org; none X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[] X-BeenThere: dev-commits-src-all@freebsd.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Commit messages for all branches of the src repository List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 14 Sep 2021 22:45:24 -0000 On Tue, Sep 14, 2021 at 08:41:06PM +0000, Edward Tomasz Napierala wrote: > The branch main has been updated by trasz: > > URL: https://cgit.FreeBSD.org/src/commit/?id=bdf0f24bb16d556a5b1e01cdfc087d08e91ac572 > > commit bdf0f24bb16d556a5b1e01cdfc087d08e91ac572 > Author: Edward Tomasz Napierala > AuthorDate: 2021-09-12 11:31:10 +0000 > Commit: Edward Tomasz Napierala > CommitDate: 2021-09-14 20:19:55 +0000 > > linux: implement PTRACE_GET_SYSCALL_INFO > > This is one of the pieces required to make modern (ie Focal) > strace(1) work. > > Reviewed By: jhb (earlier version) > Sponsored by: EPSRC > Differential Revision: https://reviews.freebsd.org/D28212 > --- > lib/libsysdecode/mktables | 2 +- > sys/amd64/linux/linux_ptrace.c | 98 +++++++++++++++++++++++++++++++++-- > sys/compat/freebsd32/freebsd32_misc.c | 3 ++ > sys/kern/sys_process.c | 17 ++++++ > sys/sys/ptrace.h | 4 ++ > 5 files changed, 120 insertions(+), 4 deletions(-) > > + case PT_GET_SC_ARGS_ALL: > + CTR1(KTR_PTRACE, "PT_GET_SC_ARGS_ALL: pid %d", p->p_pid); > + if ((td2->td_dbgflags & (TDB_SCE | TDB_SCX)) == 0 > +#ifdef COMPAT_FREEBSD32 > + || (wrap32 && !safe) > +#endif > + ) { > + error = EINVAL; > + break; > + } > + bcopy(td2->td_sa.args, addr, sizeof(td2->td_sa.args)); > + break; This is awful, you already got that feedback in review, as I read it. I strongly suggest to remove PT_GET_SC_ARGS_ALL, and instead checks something in the implementation of PT_GET_SC_ARGS to select either full copy or just nargs args. Easiest thing for 'something' would be SV_PROC_ABI(p) == SV_ABI_LINUX.