Skip site navigation (1)Skip section navigation (2)
Date:      Fri, 4 May 2012 18:54:52 +0000 (UTC)
From:      Jung-uk Kim <jkim@FreeBSD.org>
To:        src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org
Subject:   svn commit: r235029 - in head: share/man/man4 sys/dev/acpica
Message-ID:  <201205041854.q44IsqJ8018087@svn.freebsd.org>

next in thread | raw e-mail | index | archive | help
Author: jkim
Date: Fri May  4 18:54:51 2012
New Revision: 235029
URL: http://svn.freebsd.org/changeset/base/235029

Log:
  Complete commit message for r235024:
  
  Use MADT to match ACPI Processor objects to CPUs.  MADT and DSDT/SSDTs may
  list CPUs in different orders, especially for disabled logical cores.  Now
  we match ACPI IDs from the MADT with Processor objects, strictly order CPUs
  accordingly, and ignore disabled cores.  This prevents us from executing
  methods for other CPUs, e. g., _PSS for disabled logical core, which may not
  exist.  Unfortunately, it is known that there are a few systems with buggy
  BIOSes that do not have unique ACPI IDs for MADT and Processor objects.  To
  work around these problems, 'debug.acpi.cpu_unordered' tunable is added.
  Set this to a non-zero value to restore the old behavior.
  Many thanks to jhb for pointing me to the right direction and the manual
  page change.
  
  Reported by:	Harris, James R (james dot r dot harris at intel dot com)
  Tested by:	Harris, James R (james dot r dot harris at intel dot com)
  Reviewed by:	jhb
  MFC after:	1 month

Modified:
  head/share/man/man4/acpi.4
  head/sys/dev/acpica/acpi.c

Modified: head/share/man/man4/acpi.4
==============================================================================
--- head/share/man/man4/acpi.4	Fri May  4 18:36:00 2012	(r235028)
+++ head/share/man/man4/acpi.4	Fri May  4 18:54:51 2012	(r235029)
@@ -199,7 +199,7 @@ Enables loading of a custom ACPI DSDT.
 .It Va acpi_dsdt_name
 Name of the DSDT table to load, if loading is enabled.
 .It Va debug.acpi.cpu_unordered
-Do not use the MADT to match ACPI processor objects to CPUs.
+Do not use the MADT to match ACPI Processor objects to CPUs.
 This is needed on a few systems with a buggy BIOS that does not use
 consistent processor IDs.
 Default is 0 (disabled).

Modified: head/sys/dev/acpica/acpi.c
==============================================================================
--- head/sys/dev/acpica/acpi.c	Fri May  4 18:36:00 2012	(r235028)
+++ head/sys/dev/acpica/acpi.c	Fri May  4 18:54:51 2012	(r235029)
@@ -294,7 +294,7 @@ static int acpi_cpu_unordered;
 TUNABLE_INT("debug.acpi.cpu_unordered", &acpi_cpu_unordered);
 SYSCTL_INT(_debug_acpi, OID_AUTO, cpu_unordered, CTLFLAG_RDTUN,
     &acpi_cpu_unordered, 0,
-    "Do not use the MADT to match ACPI processor objects to CPUs.");
+    "Do not use the MADT to match ACPI Processor objects to CPUs.");
 
 /* Allow users to override quirks. */
 TUNABLE_INT("debug.acpi.quirks", &acpi_quirks);



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201205041854.q44IsqJ8018087>