From owner-freebsd-ppc@FreeBSD.ORG Mon Oct 14 22:02:30 2013 Return-Path: Delivered-To: freebsd-ppc@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTP id 84EA6C4C; Mon, 14 Oct 2013 22:02:30 +0000 (UTC) (envelope-from chmeeedalf@gmail.com) Received: from mail-bk0-x22e.google.com (mail-bk0-x22e.google.com [IPv6:2a00:1450:4008:c01::22e]) (using TLSv1 with cipher ECDHE-RSA-RC4-SHA (128/128 bits)) (No client certificate requested) by mx1.freebsd.org (Postfix) with ESMTPS id E9EA52B3C; Mon, 14 Oct 2013 22:02:29 +0000 (UTC) Received: by mail-bk0-f46.google.com with SMTP id 6so2785189bkj.5 for ; Mon, 14 Oct 2013 15:02:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:sender:in-reply-to:references:date:message-id:subject :from:to:cc:content-type; bh=UipwY7Vn9b6pPxmHilgNg81ZVO4kH6dMx9hG/rYByTw=; b=S9G9C5+hc5AAIMdhCPF8mMbgc+cGXrPWI1bE+uBlVU2qOuPGygkCtN+MppFn0iLvxn UZRsIaZIc5BOBDgrK/ltPLLCuPNJ3HkfGYykq3n4UV/jLQ1UiW//Sw0r/nJTiyGH1SQG ejUstTxXc8LwWQlLojfWv2oMskLs0rFpR75RKA+80cUsjVpVgwuCnB2MNqgvb5brvUcV SljavlJd1lEuy8w0H7MqmGRFwclaqYs+X7oI/f4pGlGdWQ1z3D6O51+rQ5PuhU+Pvotm fjXJarvhc/rOKm+OS80LyAzGBYmalsoCBoFDCiQXd1q52n6mbOzVI4PQ2tx0q/YytGUP FhmQ== MIME-Version: 1.0 X-Received: by 10.205.65.78 with SMTP id xl14mr31989091bkb.1.1381788148129; Mon, 14 Oct 2013 15:02:28 -0700 (PDT) Sender: chmeeedalf@gmail.com Received: by 10.205.13.199 with HTTP; Mon, 14 Oct 2013 15:02:28 -0700 (PDT) In-Reply-To: <201310141950.r9EJo1Dh054574@freefall.freebsd.org> References: <201310141950.r9EJo1Dh054574@freefall.freebsd.org> Date: Mon, 14 Oct 2013 15:02:28 -0700 X-Google-Sender-Auth: TQw96hU8FqjbJTPKAJHvLzh4Ggc Message-ID: Subject: Re: powerpc/182978: Kernel panic on boot on powerpc64 From: Justin Hibbits To: Andreas Tobler Content-Type: text/plain; charset=UTF-8 X-Content-Filtered-By: Mailman/MimeDel 2.1.14 Cc: FreeBSD PowerPC ML X-BeenThere: freebsd-ppc@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: Porting FreeBSD to the PowerPC List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 14 Oct 2013 22:02:30 -0000 On Mon, Oct 14, 2013 at 12:50 PM, Andreas Tobler wrote: > The following reply was made to PR powerpc/182978; it has been noted by > GNATS. > > From: Andreas Tobler > To: bug-followup@FreeBSD.org, julio@meroh.net > Cc: > Subject: Re: powerpc/182978: Kernel panic on boot on powerpc64 > Date: Mon, 14 Oct 2013 21:42:13 +0200 > > Hi, > > the reason is from this commit r256304. > > We're working on it. > > Basically, ata_probe does not longer return 0 and ata_kauai and > ata_macio fail now. This is due to the fact that these drivers do not > handle properly the BUS_* return codes other than 0. > > For the time being you can try the below. > > Gruss, > Andreas > > Index: powerpc/powermac/ata_kauai.c > =================================================================== > --- powerpc/powermac/ata_kauai.c (revision 256444) > +++ powerpc/powermac/ata_kauai.c (working copy) > @@ -199,7 +199,7 @@ > u_int32_t devid; > phandle_t node; > const char *compatstring = NULL; > - int i, found, rid; > + int err, i, found, rid; > > found = 0; > devid = pci_get_devid(dev); > @@ -252,8 +252,11 @@ > /* XXX: ATAPI DMA is unreliable. We should find out why. */ > ch->flags |= ATA_NO_ATAPI_DMA; > ata_generic_hw(dev); > + err = ata_probe(dev); > + if (err > 0) > + return (err); > > - return (ata_probe(dev)); > + return (0); > } > > #if USE_DBDMA_IRQ > What do the drivers need in order to behave properly with BUS_PROBE_DEFAULT? I don't see any drivers for other chipsets that use BUS_PROBE_DEFAULT that do anything differently from these. - Justin