From owner-p4-projects  Fri Jul 19  7:58:33 2002
Delivered-To: p4-projects@freebsd.org
Received: by hub.freebsd.org (Postfix, from userid 32767)
	id ABADE37B401; Fri, 19 Jul 2002 07:58:27 -0700 (PDT)
Delivered-To: perforce@freebsd.org
Received: from mx1.FreeBSD.org (mx1.FreeBSD.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id 3751837B400
	for <perforce@freebsd.org>; Fri, 19 Jul 2002 07:58:27 -0700 (PDT)
Received: from freefall.freebsd.org (freefall.FreeBSD.org [216.136.204.21])
	by mx1.FreeBSD.org (Postfix) with ESMTP id E797143E67
	for <perforce@freebsd.org>; Fri, 19 Jul 2002 07:58:26 -0700 (PDT)
	(envelope-from bb+lists.freebsd.perforce@cyrus.watson.org)
Received: from freefall.freebsd.org (perforce@localhost [127.0.0.1])
	by freefall.freebsd.org (8.12.4/8.12.4) with ESMTP id g6JEwQJU074406
	for <perforce@freebsd.org>; Fri, 19 Jul 2002 07:58:26 -0700 (PDT)
	(envelope-from bb+lists.freebsd.perforce@cyrus.watson.org)
Received: (from perforce@localhost)
	by freefall.freebsd.org (8.12.4/8.12.4/Submit) id g6JEwQmM074403
	for perforce@freebsd.org; Fri, 19 Jul 2002 07:58:26 -0700 (PDT)
Date: Fri, 19 Jul 2002 07:58:26 -0700 (PDT)
Message-Id: <200207191458.g6JEwQmM074403@freefall.freebsd.org>
X-Authentication-Warning: freefall.freebsd.org: perforce set sender to bb+lists.freebsd.perforce@cyrus.watson.org using -f
From: Robert Watson <rwatson@FreeBSD.org>
Subject: PERFORCE change 14465 for review
To: Perforce Change Reviews <perforce@freebsd.org>
Sender: owner-p4-projects@FreeBSD.ORG
Precedence: bulk
List-ID: <p4-projects.FreeBSD.ORG>
List-Archive: <http://docs.freebsd.org/mail/> (Web Archive)
List-Help: <mailto:majordomo@FreeBSD.ORG?subject=help> (List Instructions)
List-Subscribe: <mailto:majordomo@FreeBSD.ORG?subject=subscribe%20p4-projects>
List-Unsubscribe: <mailto:majordomo@FreeBSD.ORG?subject=unsubscribe%20p4-projects>
X-Loop: FreeBSD.ORG

http://people.freebsd.org/~peter/p4db/chv.cgi?CH=14465

Change 14465 by rwatson@rwatson_paprika on 2002/07/19 07:58:11

	Move the vnode label refresh of parent directory to the
	MULTILABEL-specific block of the mac_stdcreate_ea file
	system helper function.  This should improve performance
	on non-MULTILABEL file systems that support extended
	attribute backing of MAC labels.

Affected files ...

.. //depot/projects/trustedbsd/mac/sys/kern/kern_mac.c#170 edit

Differences ...

==== //depot/projects/trustedbsd/mac/sys/kern/kern_mac.c#170 (text+ko) ====

@@ -1062,13 +1062,13 @@
 	struct mac extmac;
 	int error;
 
-	error = vn_refreshlabel(dvp, cred);
-	if (error)
-		return (error);
-
 	if ((dvp->v_mount->mnt_flag & MNT_MULTILABEL) == 0) {
 		mac_update_vnode_from_mount(tvp, tvp->v_mount);
 	} else {
+		error = vn_refreshlabel(dvp, cred);
+		if (error)
+			return (error);
+
 		/*
 		 * Stick the label in the vnode.  Then try to write to
 		 * disk.  If we fail, return a failure to abort the

To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe p4-projects" in the body of the message