From owner-freebsd-ports-bugs@freebsd.org Sun Feb 28 13:10:58 2016 Return-Path: Delivered-To: freebsd-ports-bugs@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 8BAB0AB0084 for ; Sun, 28 Feb 2016 13:10:58 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2001:1900:2254:206a::16:76]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 71344E58 for ; Sun, 28 Feb 2016 13:10:58 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from bugs.freebsd.org ([127.0.1.118]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id u1SDAwbo056599 for ; Sun, 28 Feb 2016 13:10:58 GMT (envelope-from bugzilla-noreply@freebsd.org) From: bugzilla-noreply@freebsd.org To: freebsd-ports-bugs@FreeBSD.org Subject: [Bug 203204] [NEW PORT] databases/pgmodeler: PostgreSQL Database Modeler Date: Sun, 28 Feb 2016 13:10:58 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Ports & Packages X-Bugzilla-Component: Individual Port(s) X-Bugzilla-Version: Latest X-Bugzilla-Keywords: X-Bugzilla-Severity: Affects Only Me X-Bugzilla-Who: rakuco@FreeBSD.org X-Bugzilla-Status: New X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: freebsd-ports-bugs@FreeBSD.org X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: cc Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-BeenThere: freebsd-ports-bugs@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: Ports bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 28 Feb 2016 13:10:58 -0000 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D203204 Raphael Kubo da Costa changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |rakuco@FreeBSD.org --- Comment #2 from Raphael Kubo da Costa --- I've taken a look at the new port and have some comments and suggestions: * You should set USE_GITHUB to "yes" instead of just defining it. Just defi= ning it also works, but it's not the common idiom used in the tree. * You don't need to set GH_PROJECT if it has the same value as PORTNAME. * You also don't need to set GH_TAGNAME: there's an actual 0.8.1 release on GitHub, so just setting PORTVERSION and DISTVERSIONPREFIX works just fine. You'll need to re-run make makesum though as the file name will change. * Once you do that, setting WRKSRC is also not necessary. * qt5-dbus and qt5-imageformats do not seem to be actual dependencies after taking a look at the code. * Including bsd.port.{pre,post}.mk just because you are setting some target= s is not necessary. Just including bsd.port.mk at the end works fine. * Now speaking of those targets and your patches in files/: - Most of those patches become unnecessary if you use USES=3Dqmake instea= d of USES=3Dqmake:outsource. Unfortunately the upstream code seems to assume you= are not doing an out-of-tree build and references things like $$PWD in the .pro files. Instead of doing a lot of patching, it is much easier to just not do= an out-of-tree build until upstream fixes this. - I don't see why you are enabling the installation of the plugins. It requires additional patching and upstream seems to have made a conscious ch= oice of only building tests and samples in a debug build. You should also maybe = add a DEBUG option and handle those additional plugin files in pkg-plist with t= he %%DEBUG%% variable. - Personally, I don't like performing sed calls like the ones you do in t= he post-patch target. Having actual patch files makes it easier for other peop= le to see what is being changed and why. - When patching main.pro and main-cli.pro, you could use $$QMAKE_LIBS_EXECINFO instead of -lexecinfo directly. --=20 You are receiving this mail because: You are the assignee for the bug.=