From nobody Thu Feb 29 19:48:00 2024 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4Tm1wc4FRdz5Cnnt; Thu, 29 Feb 2024 19:48:00 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4Tm1wc28h8z4bp1; Thu, 29 Feb 2024 19:48:00 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1709236080; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=lz1OVyYp8x8F2rAR0nbI7xqKsyOpbBBN43wls28yytc=; b=mvUHuPd/JqfcROSprcAesKyNuqWZhlBMKGQTlEU5rzcZUVFOhx9z5prf9WczOb2a9HTN5D kUzIRCaqQQ7H2wdLtK0FGg26ED1jqY1flMoJQWpksQ1SMpX94uiCwq11tGKUbTclSAt3Q+ Kooj/l/f9lTLT4C096xsfY6B3SsJW/fHwKtcrmUJP2zNrdTbvC7qjJTj/v47KljnSpK/XS IUlhe71q2KGYENajC/hbuO5OVBerjC3JwK4zfSsKMVNPQB4V03rPaxGMOfLQ8SPp4y5rq8 5jvb6nIhAXq/u3J8sq7ULTyPhNNkC3JuprcsgVaN3JZlji2JyppO72+joXFSXg== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1709236080; a=rsa-sha256; cv=none; b=BHaBawYG6nVJspdkbAfo9OXEg3q1HUdPbrlQyEfM2Vg+KORCGqL5I9YovwIAnHETJ53NqK 0qwHBqQlRjnx7xntmhmfKdcbI8oU9gpgFqNCFUyaEOR8+CflcL+9FxbPLMX98BsHCUeI+s Lk9A4+U1oHD2IdcP167wV6zaX2S5E0lioD/e80k2i0pZNYbFCLNdRgdpFgxWHXPFgRL5Pd EUztKIB0/F8y2Gyonolh9lKJ5B5Qhesmaj7mdzhbCdgE4WtbSaMZWNQb6EgkJjJUclplkJ x0k68panGBibcqU4fgRdFSki8ixAJ4fXQBW4qRikrqN2hLQHKEm+s+fW3KsbRw== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1709236080; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=lz1OVyYp8x8F2rAR0nbI7xqKsyOpbBBN43wls28yytc=; b=OzB07xgJOHs/NzNk1XHsQbl6vGgKzpvFw3K3MGGENYfodaxd0JnE9qqqjDTw+IpluJfddR 1BKeXJW5WSxmiLem7NrRRRpaMlkMI5D60USfMN/kkUEemTms0G0diHvnu1HIbJn+q59DZo PKnJ1lPMdo6bynJbIEdXa0lSfW5r93piCVF37xZwjXazA9U10UOojOPS2mIK8Cv5Y4Ac75 dN8cImtMZ3Z/NJ4GBGxjzr1rCeAmjXfajLmYoDu81YpbcLM1PeuZ653vJxOA1tQ2jLOBH0 Oe8osCRl4bzROSHVGjaxZaf6UlU33/VybZMRkZfNG7KsHKy+B0cbrSPVszhqnA== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4Tm1wc1m0szwCf; Thu, 29 Feb 2024 19:48:00 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.17.1/8.17.1) with ESMTP id 41TJm0Da062909; Thu, 29 Feb 2024 19:48:00 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.17.1/8.17.1/Submit) id 41TJm0LR062906; Thu, 29 Feb 2024 19:48:00 GMT (envelope-from git) Date: Thu, 29 Feb 2024 19:48:00 GMT Message-Id: <202402291948.41TJm0LR062906@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Brooks Davis Subject: git: 304cdac7385a - main - lib{c,sys}: expose _getlogin consistently List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-all@freebsd.org X-BeenThere: dev-commits-src-all@freebsd.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: brooks X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: 304cdac7385a40477484737fc0a4aa928c3be9d6 Auto-Submitted: auto-generated The branch main has been updated by brooks: URL: https://cgit.FreeBSD.org/src/commit/?id=304cdac7385a40477484737fc0a4aa928c3be9d6 commit 304cdac7385a40477484737fc0a4aa928c3be9d6 Author: Brooks Davis AuthorDate: 2024-02-29 19:46:33 +0000 Commit: Brooks Davis CommitDate: 2024-02-29 19:46:33 +0000 lib{c,sys}: expose _getlogin consistently Historically we exposed _getlogin as a private symbol on a per-arch basis (except on aarch64 and riscv) for no obvious reason. We now need to expose it for libc's use so remove the special case from makesyscalls.lua and expose it in the generated syscalls.map. Reviewed by: kib Differential Revision: https://reviews.freebsd.org/D44116 --- lib/libc/powerpc64/Symbol.map | 4 ---- lib/libsys/amd64/Symbol.sys.map | 2 -- lib/libsys/arm/Symbol.sys.map | 1 - lib/libsys/i386/Symbol.sys.map | 1 - lib/libsys/powerpc/Symbol.sys.map | 4 ---- lib/libsys/powerpc64/Symbol.sys.map | 4 ---- lib/libsys/syscalls.map | 1 + sys/tools/makesyscalls.lua | 2 +- 8 files changed, 2 insertions(+), 17 deletions(-) diff --git a/lib/libc/powerpc64/Symbol.map b/lib/libc/powerpc64/Symbol.map index 3a772922e2e3..edccb69e960b 100644 --- a/lib/libc/powerpc64/Symbol.map +++ b/lib/libc/powerpc64/Symbol.map @@ -12,7 +12,3 @@ FBSD_1.0 { fpsetmask; fpsetround; }; - -FBSDprivate_1.0 { - _getlogin; -}; diff --git a/lib/libsys/amd64/Symbol.sys.map b/lib/libsys/amd64/Symbol.sys.map index 6a531b659c46..5e0714aef35d 100644 --- a/lib/libsys/amd64/Symbol.sys.map +++ b/lib/libsys/amd64/Symbol.sys.map @@ -21,8 +21,6 @@ FBSD_1.6 { * */ FBSDprivate_1.0 { - _getlogin; - _brk; _vfork; }; diff --git a/lib/libsys/arm/Symbol.sys.map b/lib/libsys/arm/Symbol.sys.map index 89a57d68f81d..179889b60832 100644 --- a/lib/libsys/arm/Symbol.sys.map +++ b/lib/libsys/arm/Symbol.sys.map @@ -4,7 +4,6 @@ FBSD_1.0 { }; FBSDprivate_1.0 { - _getlogin; _vfork; _brk; _sbrk; diff --git a/lib/libsys/i386/Symbol.sys.map b/lib/libsys/i386/Symbol.sys.map index c1b52b49c7a4..7d8c4ef61c11 100644 --- a/lib/libsys/i386/Symbol.sys.map +++ b/lib/libsys/i386/Symbol.sys.map @@ -23,7 +23,6 @@ FBSD_1.6 { }; FBSDprivate_1.0 { - _getlogin; _vfork; _brk; }; diff --git a/lib/libsys/powerpc/Symbol.sys.map b/lib/libsys/powerpc/Symbol.sys.map index d79597c0b45e..f241c4ed0984 100644 --- a/lib/libsys/powerpc/Symbol.sys.map +++ b/lib/libsys/powerpc/Symbol.sys.map @@ -2,7 +2,3 @@ FBSD_1.0 { brk; sbrk; }; - -FBSDprivate_1.0 { - _getlogin; -}; diff --git a/lib/libsys/powerpc64/Symbol.sys.map b/lib/libsys/powerpc64/Symbol.sys.map index d79597c0b45e..f241c4ed0984 100644 --- a/lib/libsys/powerpc64/Symbol.sys.map +++ b/lib/libsys/powerpc64/Symbol.sys.map @@ -2,7 +2,3 @@ FBSD_1.0 { brk; sbrk; }; - -FBSDprivate_1.0 { - _getlogin; -}; diff --git a/lib/libsys/syscalls.map b/lib/libsys/syscalls.map index f96647652430..b79c512834e0 100644 --- a/lib/libsys/syscalls.map +++ b/lib/libsys/syscalls.map @@ -80,6 +80,7 @@ FBSDprivate_1.0 { __sys_ktrace; _getgid; __sys_getgid; + _getlogin; __sys_getlogin; _setlogin; __sys_setlogin; diff --git a/sys/tools/makesyscalls.lua b/sys/tools/makesyscalls.lua index 1c80aa44c1a7..8784ff603e81 100644 --- a/sys/tools/makesyscalls.lua +++ b/sys/tools/makesyscalls.lua @@ -924,7 +924,7 @@ local function handle_noncompat(sysnum, thr_flag, flags, sysflags, rettype, config.syscallprefix, funcalias, sysnum)) write_line("sysmk", string.format(" \\\n\t%s.o", funcalias)) - if funcalias ~= "exit" and funcalias ~= "getlogin" and funcalias ~= "vfork" then + if funcalias ~= "exit" and funcalias ~= "vfork" then write_line("libsysmap", string.format("\t_%s;\n", funcalias)) end