From owner-freebsd-ports@FreeBSD.ORG  Thu May 24 12:35:07 2007
Return-Path: <owner-freebsd-ports@FreeBSD.ORG>
X-Original-To: freebsd-ports@freebsd.org
Delivered-To: freebsd-ports@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52])
	by hub.freebsd.org (Postfix) with ESMTP id F379D16A468;
	Thu, 24 May 2007 12:35:06 +0000 (UTC)
	(envelope-from stephen@math.missouri.edu)
Received: from sccmmhc92.asp.att.net (sccmmhc92.asp.att.net [204.127.203.212])
	by mx1.freebsd.org (Postfix) with ESMTP id 7277D13C46E;
	Thu, 24 May 2007 12:35:06 +0000 (UTC)
	(envelope-from stephen@math.missouri.edu)
Received: from laptop2.montlan
	(12-216-253-187.client.mchsi.com[12.216.253.187])
	by sccmmhc92.asp.att.net (sccmmhc92) with ESMTP
	id <20070524123505m9200e0h66e>; Thu, 24 May 2007 12:35:05 +0000
Message-ID: <46558678.3020704@math.missouri.edu>
Date: Thu, 24 May 2007 07:35:04 -0500
From: Stephen Montgomery-Smith <stephen@math.missouri.edu>
User-Agent: Mozilla/5.0 (X11; U; FreeBSD i386; en-US;
	rv:1.8.1.2) Gecko/20070505 SeaMonkey/1.1.1
MIME-Version: 1.0
To: pav@FreeBSD.org
References: <465291FB.4010901@math.missouri.edu>	
	<20070522071941.GB59910@xor.obsecurity.org>	
	<4652FFB4.8060107@math.missouri.edu>	
	<1179846295.52353.27.camel@pav.hide.vol.cz>	
	<4653349D.7080608@math.missouri.edu>	<46533D66.1070305@math.missouri.edu>	
	<1179868612.83498.6.camel@ikaros.oook.cz>	
	<1179869940.83498.9.camel@ikaros.oook.cz>	
	<20070522165525.S52261@math.missouri.edu>	
	<1179871899.83498.10.camel@ikaros.oook.cz>	
	<20070522172627.A52261@math.missouri.edu>	
	<465398E0.40404@math.missouri.edu>	
	<1179907804.60308.1.camel@pav.hide.vol.cz>	
	<4654E491.5000700@math.missouri.edu>
	<1179995317.66903.17.camel@pav.hide.vol.cz>
In-Reply-To: <1179995317.66903.17.camel@pav.hide.vol.cz>
Content-Type: text/plain; charset=ISO-8859-2; format=flowed
Content-Transfer-Encoding: 8bit
Cc: gnome@FreeBSD.org, freebsd-ports@FreeBSD.org,
	Kris Kennaway <kris@obsecurity.org>
Subject: Re: More speed increases for make-ing ports
X-BeenThere: freebsd-ports@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: Porting software to FreeBSD <freebsd-ports.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-ports>,
	<mailto:freebsd-ports-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-ports>
List-Post: <mailto:freebsd-ports@freebsd.org>
List-Help: <mailto:freebsd-ports-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-ports>,
	<mailto:freebsd-ports-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Thu, 24 May 2007 12:35:07 -0000

Pav Lucistnik wrote:
> Stephen Montgomery-Smith píše v st 23. 05. 2007 v 20:04 -0500:
> 
>> I'm getting kind of uncomfortable with the patch.  I looked some more
>> in 
>> bsd.gnome.mk and it seems to me that the suggested patch is really 
>> equivalent to the patch enclosed here.
>>
>> Why did the writer of bsd.gnome.mk have the rather complicated 
>> construction which I am proposing to replace?
> 
> I don't know, we'd have to ask Joe Marcus. Here is the revision in
> question:
> 
> http://www.freebsd.org/cgi/cvsweb.cgi/ports/Mk/bsd.gnome.mk.diff?r1=1.22;r2=1.23
> 
> You're basically reverting that revision. Perhaps our make(1) wasn't
> smart enough those four years ago, I don't know.

I'm not really reverting that revision.  As it was prior to that 
revision, I can see it not working under many circumstances.  Namely, if 
${component} appears more than once in ${_USE_GNOME} - something that 
will happen frequently - the test will not work.

My revision seems the obvious way to do it to me, but I can see that if 
someone was working with what Joe was working with, that one could be 
lead to think up his revision.  I know that I myself have missed the 
obvious in many circumstance.