From owner-cvs-all Sun Jun 23 9:37:10 2002 Delivered-To: cvs-all@freebsd.org Received: from nagual.pp.ru (pobrecita.freebsd.ru [194.87.13.42]) by hub.freebsd.org (Postfix) with ESMTP id E57FE37B401; Sun, 23 Jun 2002 09:37:05 -0700 (PDT) Received: from pobrecita.freebsd.ru (ache@localhost [127.0.0.1]) by nagual.pp.ru (8.12.4/8.12.3) with ESMTP id g5NGahd0037218; Sun, 23 Jun 2002 20:36:54 +0400 (MSD) (envelope-from ache@pobrecita.freebsd.ru) Received: (from ache@localhost) by pobrecita.freebsd.ru (8.12.4/8.12.3/Submit) id g5NGadtW037217; Sun, 23 Jun 2002 20:36:39 +0400 (MSD) (envelope-from ache) Date: Sun, 23 Jun 2002 20:36:35 +0400 From: "Andrey A. Chernov" To: Dag-Erling Smorgrav Cc: cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/crypto/openssh LICENCE auth-krb4.c auth-krb5.c auth-passwd.c auth-rh-rsa.c auth-rsa.c auth-skey.c auth.c auth.h auth1.c auth2-chall.c auth2.c authfd.c authfile.c bufaux.c canohost.c channels.c channels.h cipher.c cipher.h compat.c ... Message-ID: <20020623163631.GB36907@nagual.pp.ru> References: <200206231609.g5NG9AO66770@freefall.freebsd.org> <20020623161748.GA36907@nagual.pp.ru> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20020623161748.GA36907@nagual.pp.ru> User-Agent: Mutt/1.5.1i Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG On Sun, Jun 23, 2002 at 20:17:51 +0400, Andrey A. Chernov wrote: > On Sun, Jun 23, 2002 at 09:09:10 -0700, Dag-Erling Smorgrav wrote: > > > > - sshd fails to set TERM correctly. > > Do you merge our login.conf modifications in? I not check it yet, but it > can be the reason. Just check it, my guess is right, our changes are not merged properly. It means that not only TERM is not set correctly, but all login.conf variables are missing too. Quick check shows that session.c 1.29 have: env = do_setusercontext(s); But 1.30 (and original code) have do_setusercontext(pw); do_setusercontext() must return env to handle all LOGIN_CAP things. Please reestore our code in more correct way. Every change in session.c is for reason and must be inherited. P.S. That is the thing constantly wonder me. You are not only one who forget to save our changes in session.c across OpenSSH update. Previous people constantly forget the same changes too. I don't understand, why. Diff perfectly indicates them. What is hard with it? -- Andrey A. Chernov http://ache.pp.ru/ To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message