From owner-freebsd-bugs@FreeBSD.ORG Tue Jan 21 19:03:16 2014 Return-Path: Delivered-To: freebsd-bugs@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 6F9EF45D; Tue, 21 Jan 2014 19:03:16 +0000 (UTC) Received: from bigwig.baldwin.cx (bigwig.baldwin.cx [IPv6:2001:470:1f11:75::1]) (using TLSv1 with cipher ADH-CAMELLIA256-SHA (256/256 bits)) (No client certificate requested) by mx1.freebsd.org (Postfix) with ESMTPS id 43BC61E0F; Tue, 21 Jan 2014 19:03:16 +0000 (UTC) Received: from jhbbsd.localnet (unknown [209.249.190.124]) by bigwig.baldwin.cx (Postfix) with ESMTPSA id 592ACB946; Tue, 21 Jan 2014 14:03:15 -0500 (EST) From: John Baldwin To: alfred@freebsd.org Subject: Re: misc/185831: bumping maxcpu causes witness to panic at boot Date: Tue, 21 Jan 2014 13:21:06 -0500 User-Agent: KMail/1.13.5 (FreeBSD/8.4-CBSD-20130906; KDE/4.5.5; amd64; ; ) References: <201401170041.s0H0frLQ086977@freefall.freebsd.org> In-Reply-To: <201401170041.s0H0frLQ086977@freefall.freebsd.org> MIME-Version: 1.0 Content-Type: Text/Plain; charset="iso-8859-15" Content-Transfer-Encoding: 7bit Message-Id: <201401211321.06530.jhb@freebsd.org> X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.2.7 (bigwig.baldwin.cx); Tue, 21 Jan 2014 14:03:15 -0500 (EST) Cc: freebsd-bugs@freebsd.org X-BeenThere: freebsd-bugs@freebsd.org X-Mailman-Version: 2.1.17 Precedence: list List-Id: Bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 21 Jan 2014 19:03:16 -0000 On Thursday, January 16, 2014 7:41:53 pm alfred@freebsd.org wrote: > Synopsis: bumping maxcpu causes witness to panic at boot > > Responsible-Changed-From-To: freebsd-bugs->jhb > Responsible-Changed-By: alfred > Responsible-Changed-When: Fri Jan 17 00:41:11 UTC 2014 > Responsible-Changed-Why: > John, can I get a review please? WITNESS_COUNT should not need to change. If changing MAXCPU changes the number of witness structures in use, that is a bug (it means locks are named incorrectly). We could certainly change exhaustion of PENDLIST to not be a panic but to disable witness instead and possibly make PENDLIST depend on MAXCPU, but WITNESS_COUNT should not be a function of MAXCPU. -- John Baldwin