From owner-cvs-all Tue Feb 25 20:46:24 2003 Delivered-To: cvs-all@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 6250637B401; Tue, 25 Feb 2003 20:46:22 -0800 (PST) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id E7AF043F3F; Tue, 25 Feb 2003 20:46:21 -0800 (PST) (envelope-from scottl@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.6/8.12.6) with ESMTP id h1Q4kL0U042834; Tue, 25 Feb 2003 20:46:21 -0800 (PST) (envelope-from scottl@repoman.freebsd.org) Received: (from scottl@localhost) by repoman.freebsd.org (8.12.6/8.12.6/Submit) id h1Q4kLO6042833; Tue, 25 Feb 2003 20:46:21 -0800 (PST) Message-Id: <200302260446.h1Q4kLO6042833@repoman.freebsd.org> From: Scott Long Date: Tue, 25 Feb 2003 20:46:21 -0800 (PST) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org Subject: cvs commit: src/sys/dev/aac aac.c aac_cam.c aac_disk.c aacvar.h X-FreeBSD-CVS-Branch: HEAD Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG scottl 2003/02/25 20:46:21 PST Modified files: sys/dev/aac aac.c aac_cam.c aac_disk.c aacvar.h Log: Bring aac out from under Giant: - the mutex aac_io_lock protects the main codepaths which handle queues and hardware registers. Only one acquire/release is done in the top-half and the taskqueue. This mutex also applies to the userland command path and CAM data path. - Move the taskqueue to the new Giant-free version. - Register the disk device with DISKFLAG_NOGIANT so the top-half processing runs without Giant. - Move the dynamic command allocator to the worker thread to avoid locking issues with bus_dmamem_alloc(). This gives about 20% improvement in most of my benchmarks. Revision Changes Path 1.60 +32 -15 src/sys/dev/aac/aac.c 1.8 +4 -0 src/sys/dev/aac/aac_cam.c 1.29 +5 -2 src/sys/dev/aac/aac_disk.c 1.29 +5 -1 src/sys/dev/aac/aacvar.h To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message