Date: Wed, 09 Nov 2016 20:58:33 +0000 From: bugzilla-noreply@freebsd.org To: gnome@FreeBSD.org Subject: maintainer-approval requested: [Bug 211684] audio/pulseaudio: Respect hw.snd.default_unit : [Attachment 176830] Proposed patch (since 424621 revision) Message-ID: <bug-211684-6497-1vAHF7XnZ1@https.bugs.freebsd.org/bugzilla/> In-Reply-To: <bug-211684-6497@https.bugs.freebsd.org/bugzilla/>
index | next in thread | previous in thread | raw e-mail
lightside <lightside@gmx.com> has asked gnome@FreeBSD.org for maintainer-approval: Bug 211684: audio/pulseaudio: Respect hw.snd.default_unit https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=211684 Attachment 176830: Proposed patch (since 424621 revision) https://bugs.freebsd.org/bugzilla/attachment.cgi?id=176830&action=edit --- Comment #18 from lightside <lightside@gmx.com> --- Created attachment 176830 --> https://bugs.freebsd.org/bugzilla/attachment.cgi?id=176830&action=edit Proposed patch (since 424621 revision) (In reply to comment #17) > Default device parsing fails with hw.snd.verbose > 0. Not sure what you meant about "parsing fails". The parsing algorithm was developed in such a way, that recognizes concrete format of /dev/sndstat output (e.g. the "default" word at the end of line). If format of output is different, then further algorithm does nothing (as it was for "hw.snd.verbose > 0" case). Theoretically possible to break parsing algorithm (e.g. with custom /dev/sndstat output), I guess. But this is a possible drawback of such approach. Probably, you meant, that "the parsing algorithm doesn't work for hw.snd.verbose > 0 case". Looks like, sysctl hw.snd.verbose may change format of /dev/sndstat output. I extended parsing algorithm for "hw.snd.verbose > 0" case. Thanks for review.home | help
Want to link to this message? Use this
URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?bug-211684-6497-1vAHF7XnZ1>