From owner-freebsd-net@FreeBSD.ORG  Tue Jun 18 09:15:41 2013
Return-Path: <owner-freebsd-net@FreeBSD.ORG>
Delivered-To: net@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 by hub.freebsd.org (Postfix) with ESMTP id C8707CF0;
 Tue, 18 Jun 2013 09:15:41 +0000 (UTC)
 (envelope-from egrosbein@rdtc.ru)
Received: from eg.sd.rdtc.ru (eg.sd.rdtc.ru [IPv6:2a03:3100:c:13::5])
 by mx1.freebsd.org (Postfix) with ESMTP id 17BF71972;
 Tue, 18 Jun 2013 09:15:40 +0000 (UTC)
Received: from eg.sd.rdtc.ru (localhost [127.0.0.1])
 by eg.sd.rdtc.ru (8.14.7/8.14.7) with ESMTP id r5I9FaYx009430;
 Tue, 18 Jun 2013 16:15:36 +0700 (NOVT)
 (envelope-from egrosbein@rdtc.ru)
Message-ID: <51C02533.1070206@rdtc.ru>
Date: Tue, 18 Jun 2013 16:15:31 +0700
From: Eugene Grosbein <egrosbein@rdtc.ru>
User-Agent: Mozilla/5.0 (X11; FreeBSD amd64;
 rv:17.0) Gecko/20130415 Thunderbird/17.0.5
MIME-Version: 1.0
To: "net@freebsd.org" <net@freebsd.org>, Jack Vogel <jfvogel@gmail.com>,
 luigi@freebsd.org
Subject: em(4) & DEFAULT_ITR
Content-Type: text/plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
X-BeenThere: freebsd-net@freebsd.org
X-Mailman-Version: 2.1.14
Precedence: list
List-Id: Networking and TCP/IP with FreeBSD <freebsd-net.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/freebsd-net>,
 <mailto:freebsd-net-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-net>
List-Post: <mailto:freebsd-net@freebsd.org>
List-Help: <mailto:freebsd-net-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-net>,
 <mailto:freebsd-net-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Tue, 18 Jun 2013 09:15:41 -0000

Hi!

em(4) driver got new sysctl for 'itr' moderation register recently in head and stable/9.
Previously, it used the macro DEFAULT_ITR for it.

It seems for me, however, revision 250414 that brought this new feature
was quite incomplete: driver still uses DEFAULT_ITR macro instead of sysctl value
in the em_initialize_receive_unit() function. Isn't it a bug?

And there is no loader tunable like in igb(4) to make a default
to eliminate a need of extra reset of each adapter at sysctl time.

And it is more convenient to set it in terms of "maximum interrupt per second"
than as 'usec/4' unit timeouts, please :-)

Eugene Grosbein