From owner-cvs-all Sun Nov 17 10:17:28 2002 Delivered-To: cvs-all@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 250E637B401; Sun, 17 Nov 2002 10:17:27 -0800 (PST) Received: from ebb.errno.com (ebb.errno.com [66.127.85.87]) by mx1.FreeBSD.org (Postfix) with ESMTP id A981843E77; Sun, 17 Nov 2002 10:17:26 -0800 (PST) (envelope-from sam@errno.com) Received: from melange (melange.errno.com [66.127.85.82]) (authenticated bits=0) by ebb.errno.com (8.12.5/8.12.1) with ESMTP id gAHIHQ9i053073 (version=TLSv1/SSLv3 cipher=RC4-MD5 bits=128 verify=NO); Sun, 17 Nov 2002 10:17:26 -0800 (PST)?g (envelope-from sam@errno.com)œ X-Authentication-Warning: ebb.errno.com: Host melange.errno.com [66.127.85.82] claimed to be melange Message-ID: <081a01c28e65$9528df00$52557f42@errno.com> From: "Sam Leffler" To: "Luigi Rizzo" , , References: <200211171630.gAHGUjtH096646@repoman.freebsd.org> Subject: Re: cvs commit: src/sys/netinet ip_output.c ip_var.h Date: Sun, 17 Nov 2002 10:17:25 -0800 Organization: Errno Consulting MIME-Version: 1.0 Content-Type: text/plain; charset="Windows-1252" Content-Transfer-Encoding: 7bit X-Priority: 3 X-MSMail-Priority: Normal X-Mailer: Microsoft Outlook Express 5.50.4807.1700 X-MimeOLE: Produced By Microsoft MimeOLE V5.50.4807.1700 Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG I really dislike the ip_fragment api. In particular you're passing m as call-by-reference and returning multiple values to communicate multiple different possible returns. This a programming practice I dislike greatly. Please work with me to eliminate this. I'm also not happy with your commiting functional changes (e.g. ip_fragment) and style changes together. Sam ----- Original Message ----- From: "Luigi Rizzo" To: ; Sent: Sunday, November 17, 2002 8:30 AM Subject: cvs commit: src/sys/netinet ip_output.c ip_var.h > luigi 2002/11/17 08:30:44 PST > > Modified files: > sys/netinet ip_output.c ip_var.h > Log: > Move the ip_fragment code from ip_output() to a separate function, > so that it can be reused elsewhere (there is a number of places > where it can be useful). This also trims some 200 lines from > the body of ip_output(), which helps readability a bit. > > (This change was discussed a few weeks ago on the mailing lists, > Julian agreed, silence from others. It is not a functional change, > so i expect it to be ok to commit it now but i am happy to back it > out if there are objections). > > While at it, fix some function headers and replace m_copy() with > m_copypacket() where applicable. > > MFC after: 1 week > > Revision Changes Path > 1.171 +168 -143 src/sys/netinet/ip_output.c > http://cvsweb.FreeBSD.org/src/sys/netinet/ip_output.c.diff?r1=1.170&r2=1.171 > 1.69 +2 -0 src/sys/netinet/ip_var.h > http://cvsweb.FreeBSD.org/src/sys/netinet/ip_var.h.diff?r1=1.68&r2=1.69 > > > To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message