Date: Tue, 7 Apr 2015 07:24:03 +0000 From: Alexey Dokuchaev <danfe@FreeBSD.org> To: Don Lewis <truckman@FreeBSD.org> Cc: sunpoet@FreeBSD.org, svn-ports-head@FreeBSD.org, svn-ports-all@FreeBSD.org, ports-committers@FreeBSD.org Subject: Re: svn commit: r383472 - head/audio/muse Message-ID: <20150407072403.GA54371@FreeBSD.org> In-Reply-To: <201504070631.t376VnAp041310@gw.catspoiler.org> References: <20150407012902.GA22994@FreeBSD.org> <201504070631.t376VnAp041310@gw.catspoiler.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Mon, Apr 06, 2015 at 11:31:49PM -0700, Don Lewis wrote:
> On 7 Apr, Alexey Dokuchaev wrote:
> > On Mon, Apr 06, 2015 at 06:59:20PM +0000, Sunpoet Po-Chuan Hsieh wrote:
> >> New Revision: 383472
> >> [...]
> >> - ${INSTALL_DATA} ${PORTDOCS:S,^,${WRKSRC}/,} ${STAGEDIR}${DOCSDIR}
> >> + (cd ${WRKSRC} && ${INSTALL_DATA} ${PORTDOCS} ${STAGEDIR}${DOCSDIR})
> >
> > Please do not change working and readable code into equivalent
> > less-readable one.
>
> I'm not particularly fond of either the original or the update, but the
> original is obscure enough that I'd have to dig out the manual to figure
> out what it even does.
Yes, *in general* in-var substitutions can be cryptic, and I've outlined
it already that I'm in the "always :S, no thinking required". That said,
we should know our tools, make(1) in this case, and not be afraid to use
its features, and also: this particular trick is used a lot in the ports
tree already and thus should not surprise any seasonal developer and/or
contributor.
./danfe
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20150407072403.GA54371>