From owner-svn-src-head@freebsd.org Fri Aug 30 22:00:27 2019 Return-Path: Delivered-To: svn-src-head@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 627C9D9A62; Fri, 30 Aug 2019 22:00:27 +0000 (UTC) (envelope-from mjguzik@gmail.com) Received: from mail-oi1-x230.google.com (mail-oi1-x230.google.com [IPv6:2607:f8b0:4864:20::230]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1O1" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 46KthB3cdRz4cBD; Fri, 30 Aug 2019 22:00:26 +0000 (UTC) (envelope-from mjguzik@gmail.com) Received: by mail-oi1-x230.google.com with SMTP id h4so3092193oih.8; Fri, 30 Aug 2019 15:00:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=8jadTFPHqI2qy7CCPO767KRMGil7ZNTX2CJLKyglCYA=; b=CNoL0OnPjDFOUBaNDpPe/bSyW4YsABEPeVcQernMwznYXCP+RYQjM1QfksUnU4hYHd YPQy8XvptNr5fcYtC8YOs0Z9/VrNRze4Y9GCQlzUW5NrhVN25mUCRn52ZKahAQAQDtN7 l/C8RqF+H31dsogiwnl1bIG9DYT2Hws/feF/r2onZCe257khr41mzZX3DUwOugMvKyLM gSJuOpRkU0QEA99GM/FIwXBHJxwUA7LdAQORkRPCWXnHTqcHRCCaO76qB5vupcYLTV0d yh3UYZBH1t9vCDhByiCTLZg2t37tOdnmuNZDuI5fTfPzUPTxBsf8Ui74Q/D3anPtRTHS 2G4g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=8jadTFPHqI2qy7CCPO767KRMGil7ZNTX2CJLKyglCYA=; b=L9/n2SPDottw2HaLuJPX32f3RDtskeKkmp/AcsX5cWn4+rsRW8gSZBhN7l0756Mcrp NY0Zsf5h/T4SfX+TSu46HYMtzxPzpeKXaEOkbFPnytSDl23R+FZttN0zfjQRHGes7yS0 DebnmTLmIcfH6jFBtumATbJhsgqg4TxSpzc7Asw1m8BvO6bPQvkd6YDDs9nbcXZ6HQpt N4y1mCXQtJN+tBPHzwoYO3P5IUdDqrmhBDWTuchHm5QWjCYwbz1B3O8yad3s+n+aNGQh Lzgp9PJtFH0Lvuc8n2vsXRZZUCpMV3WMSuSzaWz0MoMz54kTNxxdz+ggBOLFlDaez34N 3R2A== X-Gm-Message-State: APjAAAWvlPmhNP7knTO00zvEBm7lbUM41L58PAfJ2CiO0WiU8yVrnNvd guXIvBTvraZg6xbAjhAJ9XH1xwkpNOk+Yf/aQNA= X-Google-Smtp-Source: APXvYqxVQzqWjcQETz/o9ukowb46jWZ1tJMOwtF+fuaU5VppLprv6IJRuDaWFlGgk9glTJ305PMRATNvn1PyUvLacZE= X-Received: by 2002:aca:bb42:: with SMTP id l63mr11859820oif.85.1567202424975; Fri, 30 Aug 2019 15:00:24 -0700 (PDT) MIME-Version: 1.0 Received: by 2002:a4a:83d6:0:0:0:0:0 with HTTP; Fri, 30 Aug 2019 15:00:24 -0700 (PDT) In-Reply-To: <20190830102943.GE71821@kib.kiev.ua> References: <201908300045.x7U0jsq9083259@repo.freebsd.org> <20190830102943.GE71821@kib.kiev.ua> From: Mateusz Guzik Date: Sat, 31 Aug 2019 00:00:24 +0200 Message-ID: Subject: Re: svn commit: r351622 - head/sys/kern To: Konstantin Belousov Cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Content-Type: text/plain; charset="UTF-8" X-Rspamd-Queue-Id: 46KthB3cdRz4cBD X-Spamd-Bar: --- Authentication-Results: mx1.freebsd.org; dkim=pass header.d=gmail.com header.s=20161025 header.b=CNoL0OnP; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (mx1.freebsd.org: domain of mjguzik@gmail.com designates 2607:f8b0:4864:20::230 as permitted sender) smtp.mailfrom=mjguzik@gmail.com X-Spamd-Result: default: False [-3.99 / 15.00]; ARC_NA(0.00)[]; NEURAL_HAM_MEDIUM(-1.00)[-1.000,0]; R_DKIM_ALLOW(-0.20)[gmail.com:s=20161025]; FROM_HAS_DN(0.00)[]; RCPT_COUNT_THREE(0.00)[4]; R_SPF_ALLOW(-0.20)[+ip6:2607:f8b0:4000::/36]; FREEMAIL_FROM(0.00)[gmail.com]; MIME_GOOD(-0.10)[text/plain]; IP_SCORE(0.00)[ip: (-8.23), ipnet: 2607:f8b0::/32(-2.84), asn: 15169(-2.32), country: US(-0.05)]; NEURAL_HAM_LONG(-1.00)[-1.000,0]; TO_DN_SOME(0.00)[]; IP_SCORE_FREEMAIL(0.00)[]; TO_MATCH_ENVRCPT_SOME(0.00)[]; DKIM_TRACE(0.00)[gmail.com:+]; DMARC_POLICY_ALLOW(-0.50)[gmail.com,none]; RCVD_IN_DNSWL_NONE(0.00)[0.3.2.0.0.0.0.0.0.0.0.0.0.0.0.0.0.2.0.0.4.6.8.4.0.b.8.f.7.0.6.2.list.dnswl.org : 127.0.5.0]; NEURAL_HAM_SHORT(-0.99)[-0.993,0]; FREEMAIL_TO(0.00)[gmail.com]; FROM_EQ_ENVFROM(0.00)[]; MIME_TRACE(0.00)[0:+]; FREEMAIL_ENVFROM(0.00)[gmail.com]; ASN(0.00)[asn:15169, ipnet:2607:f8b0::/32, country:US]; RCVD_COUNT_TWO(0.00)[2]; RCVD_TLS_ALL(0.00)[]; DWL_DNSWL_NONE(0.00)[gmail.com.dwl.dnswl.org : 127.0.5.0] X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 30 Aug 2019 22:00:27 -0000 On 8/30/19, Konstantin Belousov wrote: > On Fri, Aug 30, 2019 at 12:45:54AM +0000, Mateusz Guzik wrote: >> + VNASSERT(vp->v_holdcnt > 0 && vp->v_usecount > 0, vp, > A more precise assert condition would also include > vp->v_holdcont >= vp->v_usecount > I agree, but that would be problematic to test for due to other threads playing with these counters. Note this commit was just diff reduction for "usecount implies holdcnt" ( https://reviews.freebsd.org/D21471 ) after which the stronger assertion would not hold. -- Mateusz Guzik