Date: Wed, 14 Jan 2004 10:55:49 -0800 (PST) From: Nate Lawson <nate@root.org> To: cvs-all@FreeBSD.org, cvs-src@FreeBSD.org, src-committers@FreeBSD.org Subject: Re: cvs commit: src/sys/contrib/dev/acpica exstore.c Message-ID: <20040114105507.D67236@root.org> In-Reply-To: <20040114185436.9BD8F16A540@hub.freebsd.org> References: <20040114185436.9BD8F16A540@hub.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Wed, 14 Jan 2004, Nate Lawson wrote:
> Modified files: (Branch: INTEL)
> sys/contrib/dev/acpica exstore.c
> Log:
> When creating a package element via "Store(0xXXX, Index(ArgX, 0xXXX))",
> be sure to increment the refcount of the argument so it is not
> prematurely deleted. This is a workaround and may appear in a different
> form in ACPI-CA. This fixes battery evaluation on Thinkpads that was
> broken by fixing the Dell battery state.
>
> Submitted by: Luming Yu <luming.yu@intel.com>
>
> Revision Changes Path
> 1.1.1.23 +1 -1 src/sys/contrib/dev/acpica/exstore.c
>
> --- src/sys/contrib/dev/acpica/exstore.c:1.1.1.22 Mon Dec 8 18:43:40 2003
> +++ src/sys/contrib/dev/acpica/exstore.c Wed Jan 14 10:54:22 2004
> @@ -389,7 +389,7 @@
>
> /* If same as the original source, add a reference */
>
> - if (NewDesc == SourceDesc)
> + if (NewDesc == SourceDesc || ObjDesc == NULL)
> {
> AcpiUtAddReference (NewDesc);
> }
>
Ok, done on the right branch this time. Thanks to markm for repo work to
fix my mistake.
-Nate
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20040114105507.D67236>