From owner-freebsd-emulation@FreeBSD.ORG Tue Jan 1 12:58:18 2008 Return-Path: Delivered-To: emulation@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id A5CE416A417; Tue, 1 Jan 2008 12:58:18 +0000 (UTC) (envelope-from rdivacky@vlk.vlakno.cz) Received: from vlakno.cz (vlk.vlakno.cz [62.168.28.247]) by mx1.freebsd.org (Postfix) with ESMTP id 5E8B513C43E; Tue, 1 Jan 2008 12:58:18 +0000 (UTC) (envelope-from rdivacky@vlk.vlakno.cz) Received: from localhost (localhost [127.0.0.1]) by vlakno.cz (Postfix) with ESMTP id 433CA66B4DE; Tue, 1 Jan 2008 13:58:17 +0100 (CET) X-Virus-Scanned: amavisd-new at vlakno.cz Received: from vlakno.cz ([127.0.0.1]) by localhost (vlk.vlakno.cz [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id abHt26+KL9FV; Tue, 1 Jan 2008 13:58:07 +0100 (CET) Received: from vlk.vlakno.cz (localhost [127.0.0.1]) by vlakno.cz (Postfix) with ESMTP id 2E03166B4B3; Tue, 1 Jan 2008 13:58:07 +0100 (CET) Received: (from rdivacky@localhost) by vlk.vlakno.cz (8.13.8/8.13.8/Submit) id m01Cw7A4093885; Tue, 1 Jan 2008 13:58:07 +0100 (CET) (envelope-from rdivacky) Date: Tue, 1 Jan 2008 13:58:07 +0100 From: Roman Divacky To: jkim@freebsd.org Message-ID: <20080101125806.GA93742@freebsd.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.4.2.3i Cc: emulation@freebsd.org Subject: PROT_WRITE implies PROT_READ, fixing mmap05 ltp test X-BeenThere: freebsd-emulation@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Development of Emulators of other operating systems List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 01 Jan 2008 12:58:18 -0000 hi in rev. 1.70 of i386/linux/linux_machdep.c you talk about: revision 1.70 date: 2007/02/15 00:54:40; author: jkim; state: Exp; lines: +58 -54 MFP4: 113025, 113146, 113177, 113203, 113500, 113546, 113570 - PROT_READ, PROT_WRITE, or PROT_EXEC implies PROT_READ and PROT_EXEC. Linux/ia64's i386 emulation layer does this and it complies with Linux header files. This fixes mmap05 LTP test case on amd64. I have a few questions: 1) did you verify that PROT_WRITE implies PROT_READ in linux/i386? I didnt find any such place, only a comment in ia64 ia32 emulation talking about this. I think the ia64 might be wrong (does anybody uses ia32 emulation on ia64 at all?) 2) the mmap05 tests tries to mmap() file with PROT_NONE prot. how is implying PROT_READ when PROT_WRITE going to help that? in the real i386 linux the only thing I see is that PROT_READ implies PROT_EXEC. nothing more. thnx roman