From owner-svn-src-head@freebsd.org Sat Dec 30 16:25:28 2017 Return-Path: Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 9B67BEA09C6 for ; Sat, 30 Dec 2017 16:25:28 +0000 (UTC) (envelope-from pfg@FreeBSD.org) Received: from sonic312-36.consmr.mail.ne1.yahoo.com (sonic312-36.consmr.mail.ne1.yahoo.com [66.163.191.217]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 6F7B625A8 for ; Sat, 30 Dec 2017 16:25:28 +0000 (UTC) (envelope-from pfg@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1514651127; bh=cEkEmlATfIyMhN2jF0e5n0OJcY8eZlYxVweIaGhuqJU=; h=Subject:To:Cc:References:From:Date:In-Reply-To:From:Subject; b=aML9NUyU7IkChSiOC2nC9dp6Wh91TeoAnaw/QsdbEgNmRU+a0kqgVMqywrTyPi09s+lobKOO9IvT7A9gBqgg5Nl1pAu6Mj5wIS5ywA5fh3qOPOY52/5vPARZnUFquJOJIN/hH2lMzsKN0RSba6pEzRgCwFLfguGQ6eOZqU0TfAakeqHuIwcL6UaS+gMK0qFkq3/p7If5vsvFzdXtMogJKi+ShZ8s80VDy0+hoiVuTL8sQAfl1J+uUCkoSC/Nu3E3S0/l4uIYLGQ558JsJ8JolqKwy9VhqbA9y350dVga1fCgfZGmoCedeX9mpAEBax1SLZNa8jc4rzDzIGkD/5ArVA== X-YMail-OSG: nIaZ.sUVM1kkJ42JimxVWA1Sd0t22f9QTqifEFOD2hDMaJGsuh61tuzjG0jyQ7q _eE8DLr1CJBG_XnjKhO6zRjnmdURoFKLwIavkganC68vaOF5MuKsE5W.LOE7xwVdyf3vHodZxyYl gvt5a21aQrwdjQKleAfNM2Pgg4Bhsm3GwxhKpATJf51mnVR8zyuVBsHvDSevMpLAmTU27RKTPzca 0kOO3Ylc2MuD.YznseoAwbeaTzOVApDc24Dwd84YvYEBMo_u7BiBW1IyywT9z0o69YjKjbnC5gWe U3CyJT2GPgqRL8X0QzvE8GUdp28M1ZbHUOWvUhVKjtMjgfX9cJQswrV.fln8DZhl0nK68dVq0F_C 7m1BYlL3ikFFf0gdqGA2jKgM0d8ZbIJzC6C8vOlY.L6O5Q8rN2xyPs6_vl0yWq5yiwKjzfyjuJht 9MEE0eXPNaKr11jdXp2QXq7QR72IYZESZD0tieVC4T9ckcyHNqisKK0NGjhW2.YxwY9FlSa1G Received: from sonic.gate.mail.ne1.yahoo.com by sonic312.consmr.mail.ne1.yahoo.com with HTTP; Sat, 30 Dec 2017 16:25:27 +0000 Received: from smtp226.mail.ne1.yahoo.com (EHLO [192.168.0.6]) ([10.218.253.215]) by smtp406.mail.ne1.yahoo.com (JAMES SMTP Server ) with ESMTPA ID db5b6f980b0766508c7f24f08cf82a4f; Sat, 30 Dec 2017 16:25:24 +0000 (UTC) Subject: Re: svn commit: r327368 - head/sbin/ccdconfig To: rgrimes@FreeBSD.org Cc: src-committers@FreeBSD.org, svn-src-all@FreeBSD.org, svn-src-head@FreeBSD.org References: <201712301610.vBUGAmg0076574@pdx.rh.CN85.dnsmgr.net> From: Pedro Giffuni Message-ID: <2f1978cc-302a-72fa-9030-ab94ba9f2912@FreeBSD.org> Date: Sat, 30 Dec 2017 11:25:26 -0500 User-Agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:52.0) Gecko/20100101 Thunderbird/52.5.2 MIME-Version: 1.0 In-Reply-To: <201712301610.vBUGAmg0076574@pdx.rh.CN85.dnsmgr.net> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Content-Language: en-US X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.25 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 30 Dec 2017 16:25:28 -0000 On 12/30/17 11:10, Rodney W. Grimes wrote: > [ Charset UTF-8 unsupported, converting... ] >> >> On 12/30/17 10:11, Rodney W. Grimes wrote: >>>> Author: pfg >>>> Date: Sat Dec 30 00:22:47 2017 >>>> New Revision: 327368 >>>> URL: https://svnweb.freebsd.org/changeset/base/327368 >>>> >>>> Log: >>>> ccdconfig: Update licensing terms to match NetBSD. >>>> >>>> The code originated in NetBSD which has since removed Clauses 3 and 4. >>>> >>>> Approved by: phk (concerning his own copyright) >>>> Obtained from: NetBSD (CVS ccdconfig.c 1.47, ccdconfig.8 1.24) >>> I am a bit on edge about these "license" changes that are occuring, >>> before what you had been doing was adding "SPDX" tags which are just >>> an advisory item, now your actually changing the text of licenses >>> and doing so without second or third eyes and in a way that for me >>> is a bit questionable. >> That is correct. >> >> I will be glad to move to "code review" mode from now on. I agree it is >> important to have more eyes on such changes. It just happens that even >> copyright owners sometimes don't want to look at these changes. > True that copyright holders often dont want to change the terms > and/or copyright that they have already applied. Its just extra > work they probably see as an unnecessary time consumer. > > >>> Part of the problem comes that if you go back and pull a licence change >>> from NetBSD that was done in 2000 and apply it to our code because it >>> was dervied from there your ignoring the fact that someone else may >>> of made changes between 2000 and today, and technically those changes >>> fall under the licence that was inplace when they made those changes. >> It is not as simple as that, I did check the changes that are relevant >> for us in NetBSD before the license changes. I might have missed >> something though, so yes I agree on having more eyes. > It is not just the changes in NetBSD, the problem I am trying to > bring out is any changes made to OUR files are being done under > an N clause licence, your now removing those clauses without > permission from any of the people who made those changes to our > code independent of what happened in NetBSD. > Well, phk was the only author that added his copyright to the file in question. He approved the change and made a further blank statement CC'd to core. Other people have made changes to the file and from my reading of the Berne convention they have authorship rights over the file, how much of that is copyrightable is uncertain but they can certainly add their own copyright if they feel strongly. >>> Also the NetBSD license change may of been athorized directly, as in >>> this case here where you got direct permission from phk, and I have not >>> seen any notes about that in your prior commits. Also note that if >>> someone authorized NetBSD to make a license change, that authorization >>> is NOT global in nature, it is for NetBSD to make that change, not >>> *BSD. >> Authorization from NetBSD would be necessary if we were including code >> from NetBSD that was not meant to be covered by the license change. I >> didn't find any evidence of that, but feel free to point out any such >> case so that we can take it to the NetBSD guys. > And authorization from FreeBSD commiter(s) is needed to change the license > on those files. Understand that they made those changes to that file > under the terms of that license, they may not want the other clauses > removed (unlikely, but possilbe). Aha.. interesting point but irrelevant to this case. We are removing copyright clauses that are specific to NetBSD:       * 3. All advertising materials mentioning features or use of this software       *    must display the following acknowledgement:       *        This product includes software developed by the NetBSD       *        Foundation, Inc. and its contributors.       * 4. Neither the name of The NetBSD Foundation nor the names of its       *    contributors may be used to endorse or promote products derived       *    from this software without specific prior written permission. If TNF doesn't want their name to be included anymore,  other copyright owners cannot force such condition. Pedro.