From owner-svn-src-head@FreeBSD.ORG Fri Mar 6 17:13:13 2009 Return-Path: Delivered-To: svn-src-head@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 29F7B1065677; Fri, 6 Mar 2009 17:13:13 +0000 (UTC) (envelope-from thompsa@FreeBSD.org) Received: from svn.freebsd.org (svn.freebsd.org [IPv6:2001:4f8:fff6::2c]) by mx1.freebsd.org (Postfix) with ESMTP id 17E048FC12; Fri, 6 Mar 2009 17:13:13 +0000 (UTC) (envelope-from thompsa@FreeBSD.org) Received: from svn.freebsd.org (localhost [127.0.0.1]) by svn.freebsd.org (8.14.3/8.14.3) with ESMTP id n26HDCrW024680; Fri, 6 Mar 2009 17:13:12 GMT (envelope-from thompsa@svn.freebsd.org) Received: (from thompsa@localhost) by svn.freebsd.org (8.14.3/8.14.3/Submit) id n26HDCe9024679; Fri, 6 Mar 2009 17:13:12 GMT (envelope-from thompsa@svn.freebsd.org) Message-Id: <200903061713.n26HDCe9024679@svn.freebsd.org> From: Andrew Thompson Date: Fri, 6 Mar 2009 17:13:12 +0000 (UTC) To: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org X-SVN-Group: head MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Cc: Subject: svn commit: r189453 - head/sys/dev/usb/controller X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 06 Mar 2009 17:13:13 -0000 Author: thompsa Date: Fri Mar 6 17:13:12 2009 New Revision: 189453 URL: http://svn.freebsd.org/changeset/base/189453 Log: MFp4 //depot/projects/usb@158692 Workaround a EHCI performance problem by issuing a doorbell after queueing a bulk xfer. Submitted by: Hans Petter Selasky Modified: head/sys/dev/usb/controller/ehci.c Modified: head/sys/dev/usb/controller/ehci.c ============================================================================== --- head/sys/dev/usb/controller/ehci.c Fri Mar 6 17:04:47 2009 (r189452) +++ head/sys/dev/usb/controller/ehci.c Fri Mar 6 17:13:12 2009 (r189453) @@ -2189,12 +2189,21 @@ static void ehci_device_bulk_start(struct usb2_xfer *xfer) { ehci_softc_t *sc = EHCI_BUS2SC(xfer->xroot->bus); + uint32_t temp; /* setup TD's and QH */ ehci_setup_standard_chain(xfer, &sc->sc_async_p_last); /* put transfer on interrupt queue */ ehci_transfer_intr_enqueue(xfer); + + /* XXX Performance quirk: Some Host Controllers have a too low + * interrupt rate. Issue an IAAD to stimulate the Host + * Controller after queueing the BULK transfer. + */ + temp = EOREAD4(sc, EHCI_USBCMD); + if (!(temp & EHCI_CMD_IAAD)) + EOWRITE4(sc, EHCI_USBCMD, temp | EHCI_CMD_IAAD); } struct usb2_pipe_methods ehci_device_bulk_methods =