From owner-cvs-all  Thu Jun  6 19:28: 6 2002
Delivered-To: cvs-all@freebsd.org
Received: from mailman.zeta.org.au (mailman.zeta.org.au [203.26.10.16])
	by hub.freebsd.org (Postfix) with ESMTP
	id 5801937B403; Thu,  6 Jun 2002 19:28:02 -0700 (PDT)
Received: from bde.zeta.org.au (bde.zeta.org.au [203.2.228.102])
	by mailman.zeta.org.au (8.9.3/8.8.7) with ESMTP id MAA00299;
	Fri, 7 Jun 2002 12:28:00 +1000
Date: Fri, 7 Jun 2002 12:28:38 +1000 (EST)
From: Bruce Evans <bde@zeta.org.au>
X-X-Sender: bde@gamplex.bde.org
To: Chad David <davidc@FreeBSD.org>
Cc: cvs-committers@FreeBSD.org, <cvs-all@FreeBSD.org>
Subject: Re: cvs commit: src/sys/kern kern_sig.c
In-Reply-To: <200206061912.g56JCiX08025@freefall.freebsd.org>
Message-ID: <20020607121232.Q13645-100000@gamplex.bde.org>
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; charset=US-ASCII
Sender: owner-cvs-all@FreeBSD.ORG
Precedence: bulk
List-ID: <cvs-all.FreeBSD.ORG>
List-Archive: <http://docs.freebsd.org/mail/> (Web Archive)
List-Help: <mailto:majordomo@FreeBSD.ORG?subject=help> (List Instructions)
List-Subscribe: <mailto:majordomo@FreeBSD.ORG?subject=subscribe%20cvs-all>
List-Unsubscribe: <mailto:majordomo@FreeBSD.ORG?subject=unsubscribe%20cvs-all>
X-Loop: FreeBSD.ORG

> davidc      2002/06/06 12:12:44 PDT
>
>   Modified files:
>     sys/kern             kern_sig.c
>   Log:
>   s/!SIGNOTEMPY/SIGISEMPTY/
>
>   Reviewed by: marcel, jhb, alfred

One or both of these shouldn't exist.  SIGISEMPTY was unused.  SIGNOTEMPTY
was used a whole 6 times in /sys and 0 times in libc.  SIGISEMPTY is
just a wrapper for __sigisempty, and __sigisempty could be named
sigisempty and used instead.  IIRC, the 2 layers of wrappers are mainly
to support dead and/or moot uses in <signal.h> and libc.  __sigisempty
needs to have 2 underscores if it is used in a standard header, but
it isn't used there.  libc could use the macros in <sys/signalvar.h>,
but doesn't.

Bruce


To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe cvs-all" in the body of the message