From owner-freebsd-geom@FreeBSD.ORG  Sat Mar 13 11:54:24 2010
Return-Path: <owner-freebsd-geom@FreeBSD.ORG>
Delivered-To: freebsd-geom@FreeBSD.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id B03F8106564A;
	Sat, 13 Mar 2010 11:54:24 +0000 (UTC) (envelope-from avg@icyb.net.ua)
Received: from citadel.icyb.net.ua (citadel.icyb.net.ua [212.40.38.140])
	by mx1.freebsd.org (Postfix) with ESMTP id C15A18FC08;
	Sat, 13 Mar 2010 11:54:23 +0000 (UTC)
Received: from porto.topspin.kiev.ua (porto-e.starpoint.kiev.ua
	[212.40.38.100])
	by citadel.icyb.net.ua (8.8.8p3/ICyb-2.3exp) with ESMTP id NAA04291;
	Sat, 13 Mar 2010 13:54:21 +0200 (EET) (envelope-from avg@icyb.net.ua)
Received: from localhost.topspin.kiev.ua ([127.0.0.1])
	by porto.topspin.kiev.ua with esmtp (Exim 4.34 (FreeBSD))
	id 1NqPvB-0005BB-7C; Sat, 13 Mar 2010 13:54:21 +0200
Message-ID: <4B9B7CEC.4050809@icyb.net.ua>
Date: Sat, 13 Mar 2010 13:54:20 +0200
From: Andriy Gapon <avg@icyb.net.ua>
User-Agent: Thunderbird 2.0.0.23 (X11/20100211)
MIME-Version: 1.0
To: Jaakko Heinonen <jh@FreeBSD.org>
References: <20100313083551.GB966@a91-153-117-195.elisa-laajakaista.fi>
In-Reply-To: <20100313083551.GB966@a91-153-117-195.elisa-laajakaista.fi>
X-Enigmail-Version: 0.96.0
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Cc: freebsd-geom@FreeBSD.org
Subject: Re: Escape unsafe characters for kern.geom.confxml XML dump
X-BeenThere: freebsd-geom@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: GEOM-specific discussions and implementations
	<freebsd-geom.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-geom>,
	<mailto:freebsd-geom-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-geom>
List-Post: <mailto:freebsd-geom@freebsd.org>
List-Help: <mailto:freebsd-geom-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-geom>,
	<mailto:freebsd-geom-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sat, 13 Mar 2010 11:54:24 -0000

on 13/03/2010 10:35 Jaakko Heinonen said the following:
> Hi,
> 
> I intend to commit following patch unless there are objections. I have
> seen the problem commonly reported by FreeBSD users.
> 
> ---
> 
> Escape characters unsafe for XML output in GEOM class, instance and provider
> names.
> 
> - Characters in range 0x01-0x1f except '\t', '\n', and '\r' are replaced
>   with '?'. Those characters are disallowed in XML.
> - '&', '<', '>', '\'', '"' and characters in range 0x7f-0xff are replaced
>   with XML numeric character reference.
> 
> If the kern.geom.confxml sysctl provides invalid XML, libgeom
> geom_xml2tree() fails and utilities using it do not work. Unsafe
> characters are common in msdosfs and cd9660 labels.
> 
> PR:		kern/104389
> Submitter by:	Doug Steinwand (original version)

Thank you for taking care of this one.


-- 
Andriy Gapon