Skip site navigation (1)Skip section navigation (2)
Date:      Sat, 13 Mar 2010 13:54:20 +0200
From:      Andriy Gapon <avg@icyb.net.ua>
To:        Jaakko Heinonen <jh@FreeBSD.org>
Cc:        freebsd-geom@FreeBSD.org
Subject:   Re: Escape unsafe characters for kern.geom.confxml XML dump
Message-ID:  <4B9B7CEC.4050809@icyb.net.ua>
In-Reply-To: <20100313083551.GB966@a91-153-117-195.elisa-laajakaista.fi>
References:  <20100313083551.GB966@a91-153-117-195.elisa-laajakaista.fi>

next in thread | previous in thread | raw e-mail | index | archive | help
on 13/03/2010 10:35 Jaakko Heinonen said the following:
> Hi,
> 
> I intend to commit following patch unless there are objections. I have
> seen the problem commonly reported by FreeBSD users.
> 
> ---
> 
> Escape characters unsafe for XML output in GEOM class, instance and provider
> names.
> 
> - Characters in range 0x01-0x1f except '\t', '\n', and '\r' are replaced
>   with '?'. Those characters are disallowed in XML.
> - '&', '<', '>', '\'', '"' and characters in range 0x7f-0xff are replaced
>   with XML numeric character reference.
> 
> If the kern.geom.confxml sysctl provides invalid XML, libgeom
> geom_xml2tree() fails and utilities using it do not work. Unsafe
> characters are common in msdosfs and cd9660 labels.
> 
> PR:		kern/104389
> Submitter by:	Doug Steinwand (original version)

Thank you for taking care of this one.


-- 
Andriy Gapon



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?4B9B7CEC.4050809>