From owner-cvs-src@FreeBSD.ORG Sun Jun 1 14:03:00 2008 Return-Path: Delivered-To: cvs-src@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id D292F106567A; Sun, 1 Jun 2008 14:03:00 +0000 (UTC) (envelope-from ed@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [IPv6:2001:4f8:fff6::29]) by mx1.freebsd.org (Postfix) with ESMTP id BCD2D8FC20; Sun, 1 Jun 2008 14:03:00 +0000 (UTC) (envelope-from ed@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.14.1/8.14.1) with ESMTP id m51E30RI044785; Sun, 1 Jun 2008 14:03:00 GMT (envelope-from ed@repoman.freebsd.org) Received: (from svn2cvs@localhost) by repoman.freebsd.org (8.14.1/8.14.1/Submit) id m51E30hN044784; Sun, 1 Jun 2008 14:03:00 GMT (envelope-from ed@repoman.freebsd.org) Message-Id: <200806011403.m51E30hN044784@repoman.freebsd.org> X-Authentication-Warning: repoman.freebsd.org: svn2cvs set sender to ed@repoman.freebsd.org using -f From: Ed Schouten Date: Sun, 1 Jun 2008 14:02:46 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/sys/fs/devfs devfs_vnops.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 01 Jun 2008 14:03:01 -0000 ed 2008-06-01 14:03:00 UTC FreeBSD src repository Modified files: sys/fs/devfs devfs_vnops.c Log: SVN rev 179475 on 2008-06-01 14:02:46Z by ed Revert the changes I made to devfs_setattr() in r179457. As discussed with Robert Watson and John Baldwin, it would be better if PTY's are created with proper permissions, turning grantpt() into a no-op. Bypassing security frameworks like MAC by passing NOCRED to VOP_SETATTR() will only make things more complex. Approved by: philip (mentor) Revision Changes Path 1.161 +3 -4 src/sys/fs/devfs/devfs_vnops.c