From nobody Tue Apr 16 20:13:19 2024 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4VJwG82KvZz5H0l6; Tue, 16 Apr 2024 20:13:20 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4VJwG764G1z4v7F; Tue, 16 Apr 2024 20:13:19 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1713298399; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=0Vwq7hn8AX3ROJwGzjy4Pz3Hv5UcPSFD1h3mwJidXVo=; b=P5xJCAuE/ktuBoO51Pp6Y67Lxn7m6LWqiP6MhG2/rec288CSP7lcvv7WM/Mg1gxBYhQgU4 PC8g6+1C3xrQZ4KTjHeNVInXF8IcNgnY6eeuoX8JgFuvcXEv6ywFD1xwG2nirXhYPXOXq2 C/XZ4o7sANAENfA/UBAIctZU6axAPtBGKThw21c3Jx7Ygo9thMpx0GMZ/8Ee5xI7JB7r9Z yQCDnsPYEqJo+s3Y5PAxCQ77Au+Pk7rsnTSLgfHQvToIc4dxtTcYFfrvFAm/EIriV45YUH 1XCMWC0ZPqqA3wGJqIZ7RzN1IhxeH512QRuabtfcheOt64rm885pGgy2DKHFBw== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1713298399; a=rsa-sha256; cv=none; b=WwiGjXVDvM6EItU+6wsNrreE4+NThjU1cPvfNQT0TtiSWxDC/gFrUIAOb9FDk4knkv2RVy xHGnSdnTIgY1eBEWLTHyRgUoRxGalaSx/HuHeg0UhHD17q7jE93v2cd/SyVqVFRlxFciEZ UX04wdbwHn1rBW/Nl2XnmNX7wL7T43JAGDEOwN6fdP+Z3sLHUvZ/z1dwlcy/2tH1cGzrNV 7dYR4K8yD+DC6UMMCiuW5fUWE9AcX19VXqZs5Vm4M8ZwtC64kT9hU9eMO5mKY55pwCdJIc c9sNYYxSnEkRzSLKtUlRQcbObQe88KPcK/N2D69h7ro5X6pRflQLNCZaCR2ukA== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1713298399; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=0Vwq7hn8AX3ROJwGzjy4Pz3Hv5UcPSFD1h3mwJidXVo=; b=c8sSm46itTeag+on6TXQZgeQ4ZSxHCyXDr+A2PQMiFiVid+f/13g10bRJ8XK8yk91SqVHU GovcNdZYdcey5SG9rFOLLkRxMXT9wp4xZW+TTQs+A5HHb9jcG6bwAIUoK1A01bK0Kxptf7 yr/i3KFcMcvICFQiSwjt0u3+gOvPWG5mH/sBIVNb3s06aHbXfdd4ZrCysH2ivJLrw4gH1D tE4qbZX0cFa3GfO96g53JSWwsJ7uZQCxJboMjbsNsgAo3WnizwsueLu6Iq5IjA2xi/5Mdo IPKGNXfXB5ZLCWBLLEyF0EcsKK4li9kOgJAgowx2ZmNCPo0g7rK8TU9iWhXi3A== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4VJwG75dFZzxY6; Tue, 16 Apr 2024 20:13:19 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.17.1/8.17.1) with ESMTP id 43GKDJ4r039296; Tue, 16 Apr 2024 20:13:19 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.17.1/8.17.1/Submit) id 43GKDJnf039293; Tue, 16 Apr 2024 20:13:19 GMT (envelope-from git) Date: Tue, 16 Apr 2024 20:13:19 GMT Message-Id: <202404162013.43GKDJnf039293@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-branches@FreeBSD.org From: Warner Losh Subject: git: 6cad882b7eec - stable/14 - loader/efi: Linker sets not needed. List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: imp X-Git-Repository: src X-Git-Refname: refs/heads/stable/14 X-Git-Reftype: branch X-Git-Commit: 6cad882b7eeced9c268cdd0f848b03cfde5722ce Auto-Submitted: auto-generated The branch stable/14 has been updated by imp: URL: https://cgit.FreeBSD.org/src/commit/?id=6cad882b7eeced9c268cdd0f848b03cfde5722ce commit 6cad882b7eeced9c268cdd0f848b03cfde5722ce Author: Warner Losh AuthorDate: 2024-02-25 00:57:04 +0000 Commit: Warner Losh CommitDate: 2024-04-16 19:54:27 +0000 loader/efi: Linker sets not needed. We don't need linker sets listed as sections. They are explicitly included in the objcopy we use to create the .efi file. This practice was added in 2002 by peter@ in a6d81d83a280 to make ia64 builds self-hosted. However, it was added back to the objcopy in 2010 by rpaulo in 8df7a05edd36 for i386 EFI support, though the ldscript file then retained them needlessly. The gcc/binutils bug having been fixed in the interim. We've not needed them since then, but the redundancy didn't matter. Sponsored by: Netflix Reviewed by: tsoome, kevans Differential Revision: https://reviews.freebsd.org/D44061 (cherry picked from commit d024bc7ff5e80537438b4556810782e9a8257b44) --- stand/efi/loader/arch/amd64/amd64.ldscript | 11 ----------- stand/efi/loader/arch/arm/arm.ldscript | 10 ---------- stand/efi/loader/arch/arm64/arm64.ldscript | 11 ----------- stand/efi/loader/arch/riscv/riscv.ldscript | 11 ----------- 4 files changed, 43 deletions(-) diff --git a/stand/efi/loader/arch/amd64/amd64.ldscript b/stand/efi/loader/arch/amd64/amd64.ldscript index 57014aefc025..0e620654ea81 100644 --- a/stand/efi/loader/arch/amd64/amd64.ldscript +++ b/stand/efi/loader/arch/amd64/amd64.ldscript @@ -34,17 +34,6 @@ SECTIONS *(COMMON) } . = ALIGN(4096); - set_Xcommand_set : { - __start_set_Xcommand_set = .; - *(set_Xcommand_set) - __stop_set_Xcommand_set = .; - } - set_Xficl_compile_set : { - __start_set_Xficl_compile_set = .; - *(set_Xficl_compile_set) - __stop_set_Xficl_compile_set = .; - } - . = ALIGN(4096); __gp = .; .sdata : { *(.got.plt .got) diff --git a/stand/efi/loader/arch/arm/arm.ldscript b/stand/efi/loader/arch/arm/arm.ldscript index 13affe12bbba..7b5c2af399c9 100644 --- a/stand/efi/loader/arch/arm/arm.ldscript +++ b/stand/efi/loader/arch/arm/arm.ldscript @@ -42,16 +42,6 @@ SECTIONS *(.got.plt .got) *(.sdata*.sdata.* .gnu.linkonce.s.*) } - set_Xcommand_set : { - __start_set_Xcommand_set = .; - *(set_Xcommand_set) - __stop_set_Xcommand_set = .; - } - set_Xficl_compile_set : { - __start_set_Xficl_compile_set = .; - *(set_Xficl_compile_set) - __stop_set_Xficl_compile_set = .; - } __gp = .; .plt : { *(.plt) } .reloc : { *(.reloc) } diff --git a/stand/efi/loader/arch/arm64/arm64.ldscript b/stand/efi/loader/arch/arm64/arm64.ldscript index bacb81b5032f..18aead05cb49 100644 --- a/stand/efi/loader/arch/arm64/arm64.ldscript +++ b/stand/efi/loader/arch/arm64/arm64.ldscript @@ -39,17 +39,6 @@ SECTIONS __bss_end = .; } . = ALIGN(16); - set_Xcommand_set : { - __start_set_Xcommand_set = .; - *(set_Xcommand_set) - __stop_set_Xcommand_set = .; - } - set_Xficl_compile_set : { - __start_set_Xficl_compile_set = .; - *(set_Xficl_compile_set) - __stop_set_Xficl_compile_set = .; - } - . = ALIGN(16); __gp = .; .sdata : { *(.got.plt .got) diff --git a/stand/efi/loader/arch/riscv/riscv.ldscript b/stand/efi/loader/arch/riscv/riscv.ldscript index 342ec62cf03e..63b71c3bd702 100644 --- a/stand/efi/loader/arch/riscv/riscv.ldscript +++ b/stand/efi/loader/arch/riscv/riscv.ldscript @@ -35,17 +35,6 @@ SECTIONS __bss_end = .; } . = ALIGN(16); - set_Xcommand_set : { - __start_set_Xcommand_set = .; - *(set_Xcommand_set) - __stop_set_Xcommand_set = .; - } - set_Xficl_compile_set : { - __start_set_Xficl_compile_set = .; - *(set_Xficl_compile_set) - __stop_set_Xficl_compile_set = .; - } - . = ALIGN(16); .sdata : { /* * u-boot expects the gp register to be untouched by the EFI payload, so we