From owner-svn-src-head@freebsd.org Fri Nov 17 21:49:14 2017 Return-Path: Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id E872EDE3E5F; Fri, 17 Nov 2017 21:49:14 +0000 (UTC) (envelope-from cse.cem@gmail.com) Received: from mail-it0-f49.google.com (mail-it0-f49.google.com [209.85.214.49]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id AC51976BE5; Fri, 17 Nov 2017 21:49:14 +0000 (UTC) (envelope-from cse.cem@gmail.com) Received: by mail-it0-f49.google.com with SMTP id y15so5716872ita.4; Fri, 17 Nov 2017 13:49:14 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=ySu+2FpV7qeModrHj4ulrfxSxtqWz+693pe6CpOh5Tk=; b=MXiGj6ZIGemHMPlKRGRePqRVp9VtU9D4Nu9Iax/yQLFNpUPEQhOYfgoMnEGoLnVIyR Vy7GOyQoFjtGG/n6UIPWvzHh5zlKntSNXBXT8qOB8iFq5hdct/NhT1QZBQPZEl1bl0Eu hrlUWwyped4vEfOEp7wvRwQopuKxrvXVpv++Sl6C1pv1Iu6sjE1wzugHBgYNQbRTnMJ3 zCfInGnqWaKel9MJdM5luzqBrzfkjpr9ZaVmLDY67I+zdt5Qisw40NivpmixYS8C/EKs 4c06fAJWx058OD16+RHeNizslcmdTxRh7a4by9uGb5TpGGU2wmGlL7FGBU3u4VbLsgRn 5pHQ== X-Gm-Message-State: AJaThX6w3twkhTYpfn4F0r5RKA0U2sJqxnQi/dwBECiwniulhAny+nSC HpXllS4WPdLBRGSl8tDQHlGCZmsK X-Google-Smtp-Source: AGs4zMatmnxmVqrBr7rutfUxAdJetPT+LRp9BBi+zmlFj5ExXKXvHRfo1PsVeSlgj0cqqWSLVnI6Ig== X-Received: by 10.36.0.209 with SMTP id 200mr8724805ita.55.1510955347969; Fri, 17 Nov 2017 13:49:07 -0800 (PST) Received: from mail-it0-f54.google.com (mail-it0-f54.google.com. [209.85.214.54]) by smtp.gmail.com with ESMTPSA id b66sm2446785itb.28.2017.11.17.13.49.06 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 17 Nov 2017 13:49:07 -0800 (PST) Received: by mail-it0-f54.google.com with SMTP id l196so5731304itl.4; Fri, 17 Nov 2017 13:49:06 -0800 (PST) X-Received: by 10.36.53.15 with SMTP id k15mr8988916ita.75.1510955346293; Fri, 17 Nov 2017 13:49:06 -0800 (PST) MIME-Version: 1.0 References: <201711171925.vAHJPeuN074946@repo.freebsd.org> In-Reply-To: From: Conrad Meyer Date: Fri, 17 Nov 2017 21:48:55 +0000 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: svn commit: r325957 - in head: sys/kern tests/sys/vfs To: Oliver Pinter Cc: Conrad Meyer , "src-committers@freebsd.org" , "svn-src-all@freebsd.org" , "svn-src-head@freebsd.org" Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Content-Filtered-By: Mailman/MimeDel 2.1.25 X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.25 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 17 Nov 2017 21:49:15 -0000 Yes. On Fri, Nov 17, 2017 at 12:30 PM Oliver Pinter < oliver.pinter@hardenedbsd.org> wrote: > > > On Friday, November 17, 2017, Conrad Meyer wrote: > >> Author: cem >> Date: Fri Nov 17 19:25:39 2017 >> New Revision: 325957 >> URL: https://svnweb.freebsd.org/changeset/base/325957 >> >> Log: >> vfs_lookup: Allow PATH_MAX-1 symlinks >> >> Previously, symlinks in FreeBSD were artificially limited to PATH_MAX-= 2. >> >> Add a short test case to verify the change. >> >> Submitted by: Gaurav Gangalwar >> Reviewed by: kib >> Sponsored by: Dell EMC Isilon >> Differential Revision: https://reviews.freebsd.org/D12589 >> >> Added: >> head/tests/sys/vfs/lookup_test.sh (contents, props changed) >> Modified: >> head/sys/kern/vfs_lookup.c >> head/tests/sys/vfs/Makefile >> >> Modified: head/sys/kern/vfs_lookup.c >> >> =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D >> --- head/sys/kern/vfs_lookup.c Fri Nov 17 19:10:10 2017 (r325956= ) >> +++ head/sys/kern/vfs_lookup.c Fri Nov 17 19:25:39 2017 (r325957= ) >> @@ -499,7 +499,7 @@ namei(struct nameidata *ndp) >> error =3D ENOENT; >> break; >> } >> - if (linklen + ndp->ni_pathlen >=3D MAXPATHLEN) { >> + if (linklen + ndp->ni_pathlen > MAXPATHLEN) { >> if (ndp->ni_pathlen > 1) >> uma_zfree(namei_zone, cp); >> error =3D ENAMETOOLONG; >> >> Modified: head/tests/sys/vfs/Makefile >> >> =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D >> --- head/tests/sys/vfs/Makefile Fri Nov 17 19:10:10 2017 (r325956= ) >> +++ head/tests/sys/vfs/Makefile Fri Nov 17 19:25:39 2017 (r325957= ) >> @@ -7,6 +7,8 @@ TESTSDIR=3D ${TESTSBASE}/sys/vfs >> ATF_TESTS_C+=3D lookup_cap_dotdot >> CFLAGS.lookup_cap_dotdot.c+=3D -I${SRCTOP}/tests >> >> +#ATF_TESTS_SH+=3D lookup_test > > > This commented out line is intended? > > >> + >> TAP_TESTS_SH+=3D trailing_slash >> >> .include >> >> Added: head/tests/sys/vfs/lookup_test.sh >> >> =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D >> --- /dev/null 00:00:00 1970 (empty, because file is newly added) >> +++ head/tests/sys/vfs/lookup_test.sh Fri Nov 17 19:25:39 2017 >> (r325957) >> @@ -0,0 +1,17 @@ >> +# $FreeBSD$ >> + >> +long_symlink_head() >> +{ >> + atf_set "descr" "Test for 1023 (PATH_MAX-1) symlink support" >> +} >> +long_symlink_body() >> +{ >> + atf_check -s exit:0 ln -s >> aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa= aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa= aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa= aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa/aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa= aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa= aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa= aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa/aaaaaaaaaa= aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa= aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa= aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa= aaaaaaaaaaaaaaaaaaaa/aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa= aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa= aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa >> aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa sym_long >> + # was: "stat: sym_long: stat: File name too long"; exit 1 >> + atf_check -s exit:0 -o ignore stat -L sym_long >> +} >> + >> +atf_init_test_cases() >> +{ >> + atf_add_test_case long_symlink >> +} >> > _______________________________________________ >> svn-src-head@freebsd.org mailing list >> https://lists.freebsd.org/mailman/listinfo/svn-src-head >> To unsubscribe, send any mail to "svn-src-head-unsubscribe@freebsd.org" >> >