From owner-svn-src-all@freebsd.org Wed Sep 18 14:33:54 2019 Return-Path: Delivered-To: svn-src-all@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 05A57FEFBF; Wed, 18 Sep 2019 14:33:54 +0000 (UTC) (envelope-from yaneurabeya@gmail.com) Received: from mail-pf1-x434.google.com (mail-pf1-x434.google.com [IPv6:2607:f8b0:4864:20::434]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1O1" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 46YMt84ZS0z4P62; Wed, 18 Sep 2019 14:33:52 +0000 (UTC) (envelope-from yaneurabeya@gmail.com) Received: by mail-pf1-x434.google.com with SMTP id q7so73473pfh.8; Wed, 18 Sep 2019 07:33:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:subject:from:in-reply-to:date:cc :content-transfer-encoding:message-id:references:to; bh=7zG9fsIp5ZWG8t/NVo2n3trzTl/SuNuBBWDv25aQNJU=; b=Son4I8Ztc/iYdP14OFA9Ri7/b8qFfV8lt3hcVwMK3CWPJYS2KtE2oENR+S0V1/WJJu oFpecRmMJpgUkdHJr3M0EFznVVU5aAgWAWJYKOCwZAnRvJeyxhZFhHbts4SDMTIPjGkV sSksOrCTo8q5bbyYfZ56qBCnQsg/fIVhJp8j/Lmv0a+C9mCYVJK5fOYznZJpB4iHmm6x cxGS1kjHcSGivYxa5Almb4VYwU2VIZRxyvPevDCoq1xnuze1EyEYzPXxJTvfNpHJB581 neD6t/a0GSf8jA5VtcEQOt9ULa7U4TF3/yR6pKCKPJKwNCilitPlWPR6VY9bNFWilMYT 4jZQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:subject:from:in-reply-to:date:cc :content-transfer-encoding:message-id:references:to; bh=7zG9fsIp5ZWG8t/NVo2n3trzTl/SuNuBBWDv25aQNJU=; b=kQUb85JsNdM90RDXpgK5HVn6j7ErKiQfISSTicuSNgbs27sYRxfq1iKAN9adF+iQG1 DOsYKoVxR1XijGaz/kz6oZEeHnJl5Odfg61lmRRCXLss4UXiLcgppseCZCkj4h2iSmLW 8bh+XJJ2TIZHCM1vH361Mt07VfHfZ1FpAxFNLu8pIY05AxDEanp/k32e+iZ4c/yh7ruf gMcpKBPoLTueTVufQQNWKELkjanr7xm2Snj+WlLrQSSK1i47ypfk2Gr0T1CAgi1FyuzV SLYNxu+IzLwXnqLJGZCjo2RVX/XoYvNMn35yY76kCbAPkAxtu2Ominxw7Mc8UwBfIFx/ mKTw== X-Gm-Message-State: APjAAAVkbzPXit4XHXsBLld1KJZMM/G1XIeCuE9oM4KBOdyIefjlVmol IkasUIiiXOu8H3anNyleBd5DZhBAVo0= X-Google-Smtp-Source: APXvYqzAhUpWsDG/JXfkfSkPqj16Vk4KoabLoX9tUhE6YLDGehG8NCr/ZGjxB5mJ4tFIUDhiIKjoXQ== X-Received: by 2002:a65:5186:: with SMTP id h6mr4246007pgq.304.1568817230370; Wed, 18 Sep 2019 07:33:50 -0700 (PDT) Received: from ?IPv6:2607:fb90:8361:37e4:e838:8e5e:c58b:1a9d? ([2607:fb90:8361:37e4:e838:8e5e:c58b:1a9d]) by smtp.gmail.com with ESMTPSA id q204sm5304344pfc.11.2019.09.18.07.33.49 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 18 Sep 2019 07:33:49 -0700 (PDT) Content-Type: text/plain; charset=utf-8 Mime-Version: 1.0 (1.0) Subject: Re: svn commit: r352465 - head/share/mk From: Enji Cooper X-Mailer: iPhone Mail (16G102) In-Reply-To: Date: Wed, 18 Sep 2019 07:33:48 -0700 Cc: src-committers , svn-src-all , svn-src-head Content-Transfer-Encoding: quoted-printable Message-Id: References: <201909180158.x8I1wuZu011258@repo.freebsd.org> <0FBC9A62-AE3B-4F27-AABC-06FF45F415F1@gmail.com> To: Kyle Evans X-Rspamd-Queue-Id: 46YMt84ZS0z4P62 X-Spamd-Bar: -- Authentication-Results: mx1.freebsd.org; dkim=pass header.d=gmail.com header.s=20161025 header.b=Son4I8Zt; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (mx1.freebsd.org: domain of yaneurabeya@gmail.com designates 2607:f8b0:4864:20::434 as permitted sender) smtp.mailfrom=yaneurabeya@gmail.com X-Spamd-Result: default: False [-2.50 / 15.00]; RCVD_VIA_SMTP_AUTH(0.00)[]; R_SPF_ALLOW(-0.20)[+ip6:2607:f8b0:4000::/36]; FREEMAIL_FROM(0.00)[gmail.com]; MV_CASE(0.50)[]; RCVD_COUNT_THREE(0.00)[3]; TO_DN_ALL(0.00)[]; DKIM_TRACE(0.00)[gmail.com:+]; DMARC_POLICY_ALLOW(-0.50)[gmail.com,none]; FROM_EQ_ENVFROM(0.00)[]; IP_SCORE(0.00)[ip: (-8.95), ipnet: 2607:f8b0::/32(-2.68), asn: 15169(-2.23), country: US(-0.05)]; MIME_TRACE(0.00)[0:+]; FREEMAIL_ENVFROM(0.00)[gmail.com]; ASN(0.00)[asn:15169, ipnet:2607:f8b0::/32, country:US]; MID_RHS_MATCH_FROM(0.00)[]; DWL_DNSWL_NONE(0.00)[gmail.com.dwl.dnswl.org : 127.0.5.0]; ARC_NA(0.00)[]; NEURAL_HAM_MEDIUM(-1.00)[-1.000,0]; R_DKIM_ALLOW(-0.20)[gmail.com:s=20161025]; FROM_HAS_DN(0.00)[]; RCPT_COUNT_THREE(0.00)[4]; TO_MATCH_ENVRCPT_ALL(0.00)[]; NEURAL_HAM_LONG(-1.00)[-1.000,0]; MIME_GOOD(-0.10)[text/plain]; IP_SCORE_FREEMAIL(0.00)[]; RCVD_IN_DNSWL_NONE(0.00)[4.3.4.0.0.0.0.0.0.0.0.0.0.0.0.0.0.2.0.0.4.6.8.4.0.b.8.f.7.0.6.2.list.dnswl.org : 127.0.5.0]; RCVD_TLS_ALL(0.00)[] X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 18 Sep 2019 14:33:54 -0000 > On Sep 18, 2019, at 05:40, Kyle Evans wrote: >=20 >> On Wed, Sep 18, 2019 at 7:34 AM Enji Cooper wrote= : >>=20 >>=20 >>> On Sep 17, 2019, at 18:58, Kyle Evans wrote: >>>=20 >>> Author: kevans >>> Date: Wed Sep 18 01:58:56 2019 >>> New Revision: 352465 >>> URL: https://svnweb.freebsd.org/changeset/base/352465 >>>=20 >>> Log: >>> googletest: default-disable on all of MIPS for now >>>=20 >>> Parts of the fusefs tests trigger a bug in current versions of llvm: IR >>> representation of some routine for the MIPS targets is a function with a= >>> large number of arguments. This then leads the compiler on an hour+ long= >>> goose chase, which is OK if you build the current tree but less-so if yo= u're >>> trying external toolchain or doing a universe build involving mips when i= t >>> eventually gets switched over to LLVM. >>>=20 >>> Better, accurate details can be found in LLVM PR43263. >>=20 >> Uhhhhh... why not do this in tests/sys/... instead? >=20 > Because there's still value in being able to easily enable these for > building/running the complete set of tests through standard build > infrastructure, but it's not worth adding a knob specifically for the > fusefs tests. I also prefer the communication of it being an > off-by-default option and easily deduced from src.conf(5) that this > part of the build is default-disabled on mips/mips. Let me rephrase things a bit: is googlemock broken for all of mips, or is it= just the tests? If the latter, the tests should be blacklisted for mips wit= h a justification. If the former, I agree your method of dealing with the si= tuation is ok, but more investigation needs to be done to see whether or not= the port (in general) is broken and mark it broken if need be. The problem with src.opts.mk=E2=80=99s per-architecture options, is that it c= an be very heavy handed enabling/disabling features. I=E2=80=99m not sure th= at everything in there warrants disabling at that level. Thanks, -Enji=