Date: Sun, 5 Sep 2010 12:31:39 +0200 From: David Naylor <naylor.b.david@gmail.com> To: Greg Lewis <glewis@eyesbeyond.com> Cc: Anonymous <swell.k@gmail.com>, freebsd-ports@freebsd.org Subject: Re: MAKE_JOBS and openjdk6 Message-ID: <201009051231.43035.naylor.b.david@gmail.com> In-Reply-To: <20100904212627.GA15260@misty.eyesbeyond.com> References: <201006251808.29467.naylor.b.david@gmail.com> <201008291037.40908.naylor.b.david@gmail.com> <20100904212627.GA15260@misty.eyesbeyond.com>
next in thread | previous in thread | raw e-mail | index | archive | help
--nextPart1660042.oUX4vuLTpH Content-Type: Text/Plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable On Saturday 04 September 2010 23:26:27 Greg Lewis wrote: > On Sun, Aug 29, 2010 at 10:37:37AM +0200, David Naylor wrote: > > On Saturday 28 August 2010 23:30:22 Greg Lewis wrote: > > > On Sun, Aug 29, 2010 at 12:44:39AM +0400, Anonymous wrote: > > > > Greg Lewis <glewis@eyesbeyond.com> writes: > >=20 > > Your attached patch does not explicitly define either MAKE_JOBS_(UN)SAF= E. > > I would by happy with it being defined as _UNSAFE. If there are no > > other problems with your patch (see my comment at the bottom) then I'm > > happy for this patch to be committed. >=20 > I'd already committed a change that marked the port as MAKE_JOBS_UNSAFE, = so > the patch didn't include that. Yes, sorry I didn't see that. =20 =20 > > Is it safe to pass an empty HOTSPOT_BUILD_JOBS to MAKE_ENV? (i.e. when > > DISABLE_MAKE_JOBS is defined.) >=20 > Good thought. I tried the build with DISABLE_MAKE_JOBS set and experienc= ed > no problems, so I think we're ok on that front. >=20 > > > > > +.endif > > > > >=20 > > > > > COPYDIRS=3D \ > > > > > =20 > > > > > hotspot/src/os/linux/launcher \ >=20 > I'm going to commit the change in a day or two if there are no further > objections. I'll then use it as a template for changes to the other JDK > ports. No objections here. Thank you for your patience in resolving this. =20 --nextPart1660042.oUX4vuLTpH Content-Type: application/pgp-signature; name=signature.asc Content-Description: This is a digitally signed message part. -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.15 (FreeBSD) iEYEABECAAYFAkyDcY8ACgkQUaaFgP9pFrKvIgCfcm3QhKVfQJyTn8peFf9xexR9 L0kAnA/embwlvMOQ8TGw4d7dhljRm5oQ =Ugdz -----END PGP SIGNATURE----- --nextPart1660042.oUX4vuLTpH--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201009051231.43035.naylor.b.david>