From owner-dev-commits-ports-all@freebsd.org  Tue Apr 20 13:54:54 2021
Return-Path: <owner-dev-commits-ports-all@freebsd.org>
Delivered-To: dev-commits-ports-all@mailman.nyi.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1])
 by mailman.nyi.freebsd.org (Postfix) with ESMTP id 33C415F72A5;
 Tue, 20 Apr 2021 13:54:54 +0000 (UTC) (envelope-from mat@freebsd.org)
Received: from smtp.freebsd.org (smtp.freebsd.org [96.47.72.83])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256
 client-signature RSA-PSS (4096 bits) client-digest SHA256)
 (Client CN "smtp.freebsd.org", Issuer "R3" (verified OK))
 by mx1.freebsd.org (Postfix) with ESMTPS id 4FPlYV0zGyz4m2H;
 Tue, 20 Apr 2021 13:54:54 +0000 (UTC) (envelope-from mat@freebsd.org)
Received: from mail.j.mat.cc (owncloud.cube.mat.cc [79.143.240.228])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (Client CN "mail.mat.cc", Issuer "R3" (verified OK))
 (Authenticated sender: mat/mail)
 by smtp.freebsd.org (Postfix) with ESMTPSA id ED723C34B;
 Tue, 20 Apr 2021 13:54:53 +0000 (UTC) (envelope-from mat@freebsd.org)
Received: from aching.in.mat.cc (unknown
 [IPv6:2a01:678:ab:0:3356:ef6b:256f:d0c6])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange ECDHE (P-256) server-signature RSA-PSS (4096 bits) server-digest
 SHA256) (No client certificate requested)
 (Authenticated sender: mat@mat.cc)
 by mail.j.mat.cc (Postfix) with ESMTPSA id EDF87942D80;
 Tue, 20 Apr 2021 13:54:51 +0000 (UTC)
Date: Tue, 20 Apr 2021 15:54:50 +0200
From: Mathieu Arnold <mat@freebsd.org>
To: Jan Beich <jbeich@freebsd.org>
Cc: Mathieu Arnold <mat@freebsd.org>, ports-committers@freebsd.org,
 dev-commits-ports-all@freebsd.org, dev-commits-ports-branches@freebsd.org
Subject: Re: git: 043e196d694c - 2021Q2 - Add the prepare-commit-msg hook to
 the repository.
Message-ID: <20210420135450.ahbofrjlolqf5ivy@aching.in.mat.cc>
References: <202104201151.13KBpDlw022416__12188.0763372005$1618919484$gmane$org@gitrepo.freebsd.org>
 <lf9d-xfbs-wny@FreeBSD.org>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
 protocol="application/pgp-signature"; boundary="5zydvrs3eyercxdo"
Content-Disposition: inline
In-Reply-To: <lf9d-xfbs-wny@FreeBSD.org>
X-BeenThere: dev-commits-ports-all@freebsd.org
X-Mailman-Version: 2.1.34
Precedence: list
List-Id: Commit messages for all branches of the ports repository
 <dev-commits-ports-all.freebsd.org>
List-Unsubscribe: <https://lists.freebsd.org/mailman/options/dev-commits-ports-all>, 
 <mailto:dev-commits-ports-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/dev-commits-ports-all/>
List-Post: <mailto:dev-commits-ports-all@freebsd.org>
List-Help: <mailto:dev-commits-ports-all-request@freebsd.org?subject=help>
List-Subscribe: <https://lists.freebsd.org/mailman/listinfo/dev-commits-ports-all>, 
 <mailto:dev-commits-ports-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Tue, 20 Apr 2021 13:54:54 -0000


--5zydvrs3eyercxdo
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Tue, Apr 20, 2021 at 03:20:39PM +0200, Jan Beich wrote:
> Mathieu Arnold <mat@FreeBSD.org> writes:
>=20
> > +# MFH:		<Ports tree branch name.  Request approval for merge.>
>=20
> Why bother after https://svnweb.freebsd.org/changeset/ports/556626 ?

The MFH field always was there to note intent, not to get approval.

> > +# Relnotes:	<Set to 'yes' for mention in release notes.>
>=20
> "yes" doesn't apply to ports/. Also, some ports/ committers already use
> "Relnotes:" to link to upstream changelog.
>=20
> > +# Pull Request:	<https://github.com/freebsd/<repo>/pull/###>
>=20
> Looks too GitHub-specific and doesn't allow auto-close by commit.

The script comes from the src tree:
https://cgit.freebsd.org/src/tree/tools/tools/git/hooks/prepare-commit-msg

I only removed the `MFC after` that we do not use in the ports tree.
I don't see why Relnotes or Pull Request cannot be used here too.

--=20
Mathieu Arnold

--5zydvrs3eyercxdo
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQKTBAABCgB9FiEEVhwchfRfuV0unqO5KesJApEdfgIFAmB+3SZfFIAAAAAALgAo
aXNzdWVyLWZwckBub3RhdGlvbnMub3BlbnBncC5maWZ0aGhvcnNlbWFuLm5ldDU2
MUMxQzg1RjQ1RkI5NUQyRTlFQTNCOTI5RUIwOTAyOTExRDdFMDIACgkQKesJApEd
fgKx4xAAiG7gZAP6P6ZqA3AkiXAFebL74112H3OllJjjgx+SqEhyeRupjnzGsgrb
6jEtLnRKOPbMQ8PAUWJ0js2GAHKZ5Wl48wzctLq8k0YMe6ZqB3A4EZ8kI5myyKNE
7neeRKDV+H08jHEwoEAp+X0OaqyeXZL6RwfyI17r/VNgCoH8+Jl8JGd13BupUhfa
cMFwju1h7l19utRI6sFTjj93AvDDe/5id1JgWe0S/xBwp29zanQe/6O+rF3chX1S
pERClw4ryzv9Fa8GSegCJeefEqv/H5qUOg0XFTgnhmBR8N9431NXVQan/cRRyBHb
VpderZqMo4Y2eTuZggH79DQMloykfNFvZV3Ev0FYheZbORpRCRAHX+TGh/LKg8OK
vuk2Jv8OTpf+9NISm5sqf67lAeAVKUj26J06i9xQA1W4yppb5H0z3S04aLGQQaEN
aJ1lPzYFvzenq9LZnkvNuXwZIAtq+w45wub4lp6mlS/f7I7AW8ZHCWZFjnI30Xv2
3bTUPtPCpy/bW8VOzZCYMQdPpeVdzQC8eUTOviS8Q/iCUQL+OoW9xUTNAHdwfIuy
xCCAG9aVo4ycLCx4lLTCzFy2VcvQfeVKGaAhegVLl+WO/mo3lqhV6dlzKCv8zW5N
sySTcMVNPIqHbUJRWoyjXxEtbSmgEc+5RFoZGv475SZuu7FmWow=
=fBcx
-----END PGP SIGNATURE-----

--5zydvrs3eyercxdo--