From owner-freebsd-scsi@FreeBSD.ORG  Thu Jul 31 09:11:28 2003
Return-Path: <owner-freebsd-scsi@FreeBSD.ORG>
Delivered-To: freebsd-scsi@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id 42B5E37B401
	for <scsi@freebsd.org>; Thu, 31 Jul 2003 09:11:28 -0700 (PDT)
Received: from smtp.mho.com (smtp.mho.net [64.58.4.6])
	by mx1.FreeBSD.org (Postfix) with SMTP id 6E48A43FA3
	for <scsi@freebsd.org>; Thu, 31 Jul 2003 09:11:27 -0700 (PDT)
	(envelope-from scottl@freebsd.org)
Received: (qmail 69961 invoked by uid 1002); 31 Jul 2003 16:11:26 -0000
Received: from adsl-64-58-12-196.mho.net (HELO freebsd.org) (64.58.12.196)
  by smtp.mho.net with SMTP; 31 Jul 2003 16:11:26 -0000
Message-ID: <3F293FAA.1060204@freebsd.org>
Date: Thu, 31 Jul 2003 10:11:22 -0600
From: Scott Long <scottl@freebsd.org>
User-Agent: Mozilla/5.0 (X11; U; FreeBSD i386; en-US; rv:1.3) Gecko/20030425
X-Accept-Language: en-us, en
MIME-Version: 1.0
To: Ruslan Ermilov <ru@freebsd.org>
References: <20030731154855.GA63027@sunbay.com>
In-Reply-To: <20030731154855.GA63027@sunbay.com>
Content-Type: text/plain; charset=us-ascii; format=flowed
Content-Transfer-Encoding: 7bit
cc: scsi@freebsd.org
Subject: Re: amd(4) module
X-BeenThere: freebsd-scsi@freebsd.org
X-Mailman-Version: 2.1.1
Precedence: list
List-Id: SCSI subsystem <freebsd-scsi.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-scsi>,
	<mailto:freebsd-scsi-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-scsi>
List-Post: <mailto:freebsd-scsi@freebsd.org>
List-Help: <mailto:freebsd-scsi-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-scsi>,
	<mailto:freebsd-scsi-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Thu, 31 Jul 2003 16:11:28 -0000

Ruslan Ermilov wrote:
> The amd(4) module is pretty unusable at the moment.  The attached
> patch fixed it for me.  Should I commit it?

The patch looks fine.

> 
> BTW, the "camcontrol rescan all" only works if amd.ko is loaded
> from the loader(8); loading it by kldload(8) causes the camcontrol
> to stuck.  Is this a known issue?

How does it get stuck?  A backtrace would help.  However, I'm working on
porting the NetBSD esp(4) driver, which will replace amd(4) and also add
support for many other variants of the hardware.

Scott

> 
> 
> Cheers,
> 
> 
> ------------------------------------------------------------------------
> 
> Index: amd.c
> ===================================================================
> RCS file: /home/ncvs/src/sys/dev/amd/amd.c,v
> retrieving revision 1.21
> diff -u -r1.21 amd.c
> --- amd.c	1 Jul 2003 15:51:53 -0000	1.21
> +++ amd.c	31 Jul 2003 15:45:51 -0000
> @@ -2497,3 +2497,4 @@
>  
>  static devclass_t amd_devclass;
>  DRIVER_MODULE(amd, pci, amd_driver, amd_devclass, 0, 0);
> +MODULE_DEPEND(amd, cam, 1, 1, 1);