From owner-cvs-all  Sun Jan  7 17:37:55 2001
Delivered-To: cvs-all@freebsd.org
Received: from mailman.zeta.org.au (mailman.zeta.org.au [203.26.10.16])
	by hub.freebsd.org (Postfix) with ESMTP
	id BE70037B6B0; Sun,  7 Jan 2001 17:35:38 -0800 (PST)
Received: from bde.zeta.org.au (bde.zeta.org.au [203.2.228.102])
	by mailman.zeta.org.au (8.9.3/8.8.7) with ESMTP id MAA12347;
	Mon, 8 Jan 2001 12:34:36 +1100
Date: Mon, 8 Jan 2001 12:35:28 +1100 (EST)
From: Bruce Evans <bde@zeta.org.au>
X-Sender: bde@besplex.bde.org
To: Alfred Perlstein <bright@wintelcom.net>
Cc: Poul-Henning Kamp <phk@critter.freebsd.dk>,
	Bosko Milekic <bmilekic@FreeBSD.org>, cvs-committers@FreeBSD.org,
	cvs-all@FreeBSD.org
Subject: Re: cvs commit: src/sys/dev/musycc musycc.c
In-Reply-To: <20010106141257.F15744@fw.wintelcom.net>
Message-ID: <Pine.BSF.4.21.0101081230260.21487-100000@besplex.bde.org>
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; charset=US-ASCII
Sender: owner-cvs-all@FreeBSD.ORG
Precedence: bulk
X-Loop: FreeBSD.ORG

On Sat, 6 Jan 2001, Alfred Perlstein wrote:

> not only that but we have one of my favorite bugs:
> 
>     while (csc->state != C_RUNNING)
>         tsleep(&csc->state, PZERO + PCATCH, "crun", hz/10);
> 
> should have no PCATCH, or somehow deal with the signal instead of
> looping forever.

It also obfuscates ORing the PCATCH mask with the PZERO value.

These bugs are repeated 15 times in the file (the value returned by
tsleep() is not checked 17 times, but '|' is misspelled '+' only 15
times).

> You're right, this file is pretty broken. :)

Right :).

Bruce



To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe cvs-all" in the body of the message