Date: Wed, 14 Aug 2019 02:02:14 +0000 (UTC) From: Alexander Motin <mav@FreeBSD.org> To: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: svn commit: r351006 - head/sys/dev/nvd Message-ID: <201908140202.x7E22Eao098950@repo.freebsd.org>
next in thread | raw e-mail | index | archive | help
Author: mav Date: Wed Aug 14 02:02:14 2019 New Revision: 351006 URL: https://svnweb.freebsd.org/changeset/base/351006 Log: Add missing break statements in r351004. Surprisingly code still worked, but thanks imp@ for noticing it. MFC after: 1 week Modified: head/sys/dev/nvd/nvd.c Modified: head/sys/dev/nvd/nvd.c ============================================================================== --- head/sys/dev/nvd/nvd.c Tue Aug 13 23:32:56 2019 (r351005) +++ head/sys/dev/nvd/nvd.c Wed Aug 14 02:02:14 2019 (r351006) @@ -306,8 +306,10 @@ nvd_getattr(struct bio *bp) nsdata = nvme_ns_get_data(ndisk->ns); /* Try to return NGUID as lunid. */ - for (i = 0; i < sizeof(nsdata->nguid); i++) + for (i = 0; i < sizeof(nsdata->nguid); i++) { if (nsdata->nguid[i] != 0) + break; + } if (i < sizeof(nsdata->nguid)) { if (bp->bio_length < sizeof(nsdata->nguid) * 2 + 1) return (EFAULT); @@ -320,8 +322,10 @@ nvd_getattr(struct bio *bp) } /* Try to return EUI64 as lunid. */ - for (i = 0; i < sizeof(nsdata->eui64); i++) + for (i = 0; i < sizeof(nsdata->eui64); i++) { if (nsdata->eui64[i] != 0) + break; + } if (i < sizeof(nsdata->eui64)) { if (bp->bio_length < sizeof(nsdata->eui64) * 2 + 1) return (EFAULT);
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201908140202.x7E22Eao098950>