From owner-p4-projects@FreeBSD.ORG  Wed Jul 24 01:01:29 2013
Return-Path: <owner-p4-projects@FreeBSD.ORG>
Delivered-To: p4-projects@freebsd.org
Received: by hub.freebsd.org (Postfix, from userid 32767)
 id 1FE7E9B3; Wed, 24 Jul 2013 01:01:29 +0000 (UTC)
Delivered-To: perforce@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115])
 by hub.freebsd.org (Postfix) with ESMTP id C52CF9B1
 for <perforce@freebsd.org>; Wed, 24 Jul 2013 01:01:28 +0000 (UTC)
 (envelope-from bb+lists.freebsd.perforce@cyrus.watson.org)
Received: from skunkworks.freebsd.org (skunkworks.freebsd.org [8.8.178.74])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by mx1.freebsd.org (Postfix) with ESMTPS id B4B24202D
 for <perforce@freebsd.org>; Wed, 24 Jul 2013 01:01:28 +0000 (UTC)
Received: from skunkworks.freebsd.org ([127.0.1.74])
 by skunkworks.freebsd.org (8.14.7/8.14.7) with ESMTP id r6O11SJ8033090
 for <perforce@freebsd.org>; Wed, 24 Jul 2013 01:01:28 GMT
 (envelope-from bb+lists.freebsd.perforce@cyrus.watson.org)
Received: (from perforce@localhost)
 by skunkworks.freebsd.org (8.14.7/8.14.6/Submit) id r6O11RFm033087
 for perforce@freebsd.org; Wed, 24 Jul 2013 01:01:27 GMT
 (envelope-from bb+lists.freebsd.perforce@cyrus.watson.org)
Date: Wed, 24 Jul 2013 01:01:27 GMT
Message-Id: <201307240101.r6O11RFm033087@skunkworks.freebsd.org>
X-Authentication-Warning: skunkworks.freebsd.org: perforce set sender to
 bb+lists.freebsd.perforce@cyrus.watson.org using -f
From: Robert Watson <rwatson@FreeBSD.org>
Subject: PERFORCE change 231392 for review
To: Perforce Change Reviews <perforce@FreeBSD.org>
Precedence: bulk
X-BeenThere: p4-projects@freebsd.org
X-Mailman-Version: 2.1.14
List-Id: p4 projects tree changes <p4-projects.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/p4-projects>,
 <mailto:p4-projects-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/p4-projects>
List-Post: <mailto:p4-projects@freebsd.org>
List-Help: <mailto:p4-projects-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/p4-projects>,
 <mailto:p4-projects-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Wed, 24 Jul 2013 01:01:29 -0000

http://p4web.freebsd.org/@@231392?ac=10

Change 231392 by rwatson@rwatson_cinnamon on 2013/07/24 01:01:23

	Add two missing previously() quantifiers that lead to surprising
	behaviour.

Affected files ...

.. //depot/projects/ctsrd/tesla/src/sys/ufs/ffs/ffs_vnops.c#15 edit
.. //depot/projects/ctsrd/tesla/src/sys/ufs/ufs/ufs_vnops.c#5 edit

Differences ...

==== //depot/projects/ctsrd/tesla/src/sys/ufs/ffs/ffs_vnops.c#15 (text+ko) ====

@@ -1720,8 +1720,8 @@
 #ifdef MAC
 #ifdef TESLA_MAC
 	TESLA_SYSCALL(incallstack(ufs_setacl) ||
-	    mac_vnode_check_setextattr(ANY(ptr), ap->a_vp,
-	    ap->a_attrnamespace, ap->a_name) == 0);
+	    previously(mac_vnode_check_setextattr(ANY(ptr), ap->a_vp,
+	    ap->a_attrnamespace, ap->a_name) == 0));
 #endif
 #endif
 

==== //depot/projects/ctsrd/tesla/src/sys/ufs/ufs/ufs_vnops.c#5 (text+ko) ====

@@ -276,7 +276,7 @@
 #ifdef MAC
 #ifdef TESLA_MAC
 	TESLA_SYSCALL(incallstack(kern_execve) ||
-	    mac_vnode_check_open(ANY(ptr), vp, ANY(int)) == 0);
+	    previously(mac_vnode_check_open(ANY(ptr), vp, ANY(int)) == 0));
 #endif
 #endif