From owner-cvs-ports@FreeBSD.ORG  Sun Jan  2 07:18:53 2005
Return-Path: <owner-cvs-ports@FreeBSD.ORG>
Delivered-To: cvs-ports@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP
	id CBA4416A4CE; Sun,  2 Jan 2005 07:18:53 +0000 (GMT)
Received: from obsecurity.dyndns.org
	(CPE0050040655c8-CM00111ae02aac.cpe.net.cable.rogers.com [69.199.47.57])
	by mx1.FreeBSD.org (Postfix) with ESMTP
	id 9111C43D2D; Sun,  2 Jan 2005 07:18:53 +0000 (GMT)
	(envelope-from kris@obsecurity.org)
Received: by obsecurity.dyndns.org (Postfix, from userid 1000)
	id F3E4751A06; Sat,  1 Jan 2005 23:18:49 -0800 (PST)
Date: Sat, 1 Jan 2005 23:18:49 -0800
From: Kris Kennaway <kris@obsecurity.org>
To: Edwin Groothuis <edwin@mavetju.org>
Message-ID: <20050102071849.GA31292@xor.obsecurity.org>
References: <200501020116.j021GBqD070105@repoman.freebsd.org>
	<20050102064857.GA4047@frontfree.net>
	<20050102065949.GB6250@xor.obsecurity.org>
	<20050102070800.GA106@frontfree.net> <20050102071136.GD1436@k7.mavetju>
Mime-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha1;
	protocol="application/pgp-signature"; boundary="wac7ysb48OaltWcw"
Content-Disposition: inline
In-Reply-To: <20050102071136.GD1436@k7.mavetju>
User-Agent: Mutt/1.4.2.1i
cc: Kris Kennaway <kris@FreeBSD.org>
cc: cvs-all@FreeBSD.org
cc: ports-committers@FreeBSD.org
cc: Kris Kennaway <kris@obsecurity.org>
cc: cvs-ports@FreeBSD.org
cc: Xin LI <delphij@frontfree.net>
Subject: Re: cvs commit: ports/mail/postfix-gps Makefile
X-BeenThere: cvs-ports@freebsd.org
X-Mailman-Version: 2.1.1
Precedence: list
List-Id: CVS commit messages for the ports tree <cvs-ports.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-ports>,
	<mailto:cvs-ports-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/cvs-ports>
List-Post: <mailto:cvs-ports@freebsd.org>
List-Help: <mailto:cvs-ports-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-ports>,
	<mailto:cvs-ports-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sun, 02 Jan 2005 07:18:54 -0000


--wac7ysb48OaltWcw
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Sun, Jan 02, 2005 at 06:11:36PM +1100, Edwin Groothuis wrote:
> On Sun, Jan 02, 2005 at 03:08:00PM +0800, Xin LI wrote:
> > I think a better way is to have bsd.port.mk to set WITH_FOO or WITHOUT_=
FOO
> > according to the defaults set in individual ports' Makefile.  It seems =
that
> > bsd.port.mk will ignore OPTIONS when doing package builds.
>=20
> They did this on purpose, see the part of bsd.port.mk which starts with:
>     ################################################################
>     #
>     # Do preliminary work to detect if we need to run the config
>     # target or not.
>     #
>     ################################################################
>=20
> I am totally on your side with this, bsd.port.mk should set the
> default WITH_ and WITHOUT_s.

The problem is that INDEX builds also need to set this or the
dependency list will be all wrong.  Doing this the obvious way gives a
huge slowdown.

Kris

--wac7ysb48OaltWcw
Content-Type: application/pgp-signature
Content-Disposition: inline

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.6 (FreeBSD)

iD8DBQFB16BYWry0BWjoQKURAo6YAJ9eHqemv7z3pRPQS2ki8zMcDE/rrwCgmcbL
9Y33tZgCkiT49eTklGJB+L0=
=L6e+
-----END PGP SIGNATURE-----

--wac7ysb48OaltWcw--