From nobody Wed May 19 03:24:58 2021 X-Original-To: freebsd-hackers@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 0D2EA5D4725 for ; Wed, 19 May 2021 03:25:09 +0000 (UTC) (envelope-from kostikbel@gmail.com) Received: from kib.kiev.ua (kib.kiev.ua [IPv6:2001:470:d5e7:1::1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 4FlJCS3Yzsz4k4l; Wed, 19 May 2021 03:25:08 +0000 (UTC) (envelope-from kostikbel@gmail.com) Received: from tom.home (kib@localhost [127.0.0.1]) by kib.kiev.ua (8.16.1/8.16.1) with ESMTPS id 14J3Owtx079277 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NO); Wed, 19 May 2021 06:25:01 +0300 (EEST) (envelope-from kostikbel@gmail.com) DKIM-Filter: OpenDKIM Filter v2.10.3 kib.kiev.ua 14J3Owtx079277 Received: (from kostik@localhost) by tom.home (8.16.1/8.16.1/Submit) id 14J3Owqf079276; Wed, 19 May 2021 06:24:58 +0300 (EEST) (envelope-from kostikbel@gmail.com) X-Authentication-Warning: tom.home: kostik set sender to kostikbel@gmail.com using -f Date: Wed, 19 May 2021 06:24:58 +0300 From: Konstantin Belousov To: Alan Somers Cc: Mark Johnston , FreeBSD Hackers Subject: Re: The pagedaemon evicts ARC before scanning the inactive page list Message-ID: References: List-Id: Technical discussions relating to FreeBSD List-Archive: https://lists.freebsd.org/archives/freebsd-hackers List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-hackers@freebsd.org MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Spam-Status: No, score=-1.0 required=5.0 tests=ALL_TRUSTED,BAYES_00, DKIM_ADSP_CUSTOM_MED,FORGED_GMAIL_RCVD,FREEMAIL_FROM, NML_ADSP_CUSTOM_MED autolearn=no autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on tom.home X-Rspamd-Queue-Id: 4FlJCS3Yzsz4k4l X-Spamd-Bar: ---- Authentication-Results: mx1.freebsd.org; none X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[] On Tue, May 18, 2021 at 05:55:36PM -0600, Alan Somers wrote: > On Tue, May 18, 2021 at 4:10 PM Mark Johnston wrote: > > > On Tue, May 18, 2021 at 04:00:14PM -0600, Alan Somers wrote: > > > On Tue, May 18, 2021 at 3:45 PM Mark Johnston wrote: > > > > > > > On Tue, May 18, 2021 at 03:07:44PM -0600, Alan Somers wrote: > > > > > I'm using ZFS on servers with tons of RAM and running FreeBSD > > > > > 12.2-RELEASE. Sometimes they get into a pathological situation where > > > > most > > > > > of that RAM sits unused. For example, right now one of them has: > > > > > > > > > > 2 GB Active > > > > > 529 GB Inactive > > > > > 16 GB Free > > > > > 99 GB ARC total > > > > > 469 GB ARC max > > > > > 86 GB ARC target > > > > > > > > > > When a server gets into this situation, it stays there for days, > > with the > > > > > ARC target barely budging. All that inactive memory never gets > > reclaimed > > > > > and put to a good use. Frequently the server never recovers until a > > > > reboot. > > > > > > > > > > I have a theory for what's going on. Ever since r334508^ the > > pagedaemon > > > > > sends the vm_lowmem event _before_ it scans the inactive page list. > > If > > > > the > > > > > ARC frees enough memory, then vm_pageout_scan_inactive won't need to > > free > > > > > any. Is that order really correct? For reference, here's the > > relevant > > > > > code, from vm_pageout_worker: > > > > > > > > That was the case even before r334508. Note that prior to that > > revision > > > > vm_pageout_scan_inactive() would trigger vm_lowmem if pass > 0, before > > > > scanning the inactive queue. During a memory shortage we have pass > > > 0. > > > > pass == 0 only when the page daemon is scanning the active queue. > > > > > > > > > shortage = pidctrl_daemon(&vmd->vmd_pid, vmd->vmd_free_count); > > > > > if (shortage > 0) { > > > > > ofree = vmd->vmd_free_count; > > > > > if (vm_pageout_lowmem() && vmd->vmd_free_count > ofree) > > > > > shortage -= min(vmd->vmd_free_count - ofree, > > > > > (u_int)shortage); > > > > > target_met = vm_pageout_scan_inactive(vmd, shortage, > > > > > &addl_shortage); > > > > > } else > > > > > addl_shortage = 0 > > > > > > > > > > Raising vfs.zfs.arc_min seems to workaround the problem. But ideally > > > > that > > > > > wouldn't be necessary. > > > > > > > > vm_lowmem is too primitive: it doesn't tell subscribing subsystems > > > > anything about the magnitude of the shortage. At the same time, the VM > > > > doesn't know much about how much memory they are consuming. A better > > > > strategy, at least for the ARC, would be reclaim memory based on the > > > > relative memory consumption of each subsystem. In your case, when the > > > > page daemon goes to reclaim memory, it should use the inactive queue to > > > > make up ~85% of the shortfall and reclaim the rest from the ARC. Even > > > > better would be if the ARC could use the page cache as a second-level > > > > cache, like the buffer cache does. > > > > > > > > Today I believe the ARC treats vm_lowmem as a signal to shed some > > > > arbitrary fraction of evictable data. If the ARC is able to quickly > > > > answer the question, "how much memory can I release if asked?", then > > > > the page daemon could use that to determine how much of its reclamation > > > > target should come from the ARC vs. the page cache. > > > > > > > > > > I guess I don't understand why you would ever free from the ARC rather > > than > > > from the inactive list. When is inactive memory ever useful? > > > > Pages in the inactive queue are either unmapped or haven't had their > > mappings referenced recently. But they may still be frequently accessed > > by file I/O operations like sendfile(2). That's not to say that > > reclaiming from other subsystems first is always the right strategy, but > > note also that the page daemon may scan the inactive queue many times in > > between vm_lowmem calls. > > > > So By default ZFS tries to free (arc_target / 128) bytes of memory in > arc_lowmem. That's huge! On this server, pidctrl_daemon typically > requests 0-10MB, and arc_lowmem tries to free 600 MB. It looks like it > would be easy to modify vm_lowmem to include the total amount of memory > that it wants freed. I could make such a patch. My next question is: > what's the fastest way to generate a lot of inactive memory? My first > attempt was "find . | xargs md5", but that isn't terribly effective. The > production machines are doing a lot of "zfs recv" and running some busy Go > programs, among other things, but I can't easily replicate that workload on Is your machine ZFS-only? If yes, then typical source of inactive memory can be of two kinds: - anonymous memory that apps allocate with facilities like malloc(3). If inactive is shrinkable then it is probably not, because dirty pages from anon objects must go through laundry->swap route to get evicted, and you did not mentioned swapping - double-copy pages cached in v_objects of ZFS vnodes, clean or dirty. If unmapped, these are mostly a waste. Even if mapped, the source of truth for data is ARC, AFAIU, so they can be dropped as well, since inactive state means that its content is not hot. You can try to inspect the most outstanding objects adding to the inactive queue with 'vmobject -o' to see where the most of inactive pages come from. If indeed they are double-copy, then perhaps ZFS can react even to the current primitive vm_lowmem signal somewhat different. First, it could do the pass over its vnodes and - free clean unmapped pages - if some targets are not met after that, laundry dirty pages, then return to freeing clean unmapped pages all that before ever touching its cache (ARC).