From owner-svn-ports-all@freebsd.org Tue Jun 25 08:45:39 2019 Return-Path: Delivered-To: svn-ports-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 9000515C4E14; Tue, 25 Jun 2019 08:45:39 +0000 (UTC) (envelope-from koobs.freebsd@gmail.com) Received: from mail-pl1-x642.google.com (mail-pl1-x642.google.com [IPv6:2607:f8b0:4864:20::642]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1O1" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 0D23F80360; Tue, 25 Jun 2019 08:45:39 +0000 (UTC) (envelope-from koobs.freebsd@gmail.com) Received: by mail-pl1-x642.google.com with SMTP id e5so8452668pls.13; Tue, 25 Jun 2019 01:45:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:reply-to:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=eMtCtWdeVzZeV55IU8Tvb/tZ5JncKmrPAx08QN5CpjQ=; b=jsnp9rX/A4ELk00/fJIcPvDHaygbRlZkyWUq4ZY/cfI87AW0SZSfFZlDDRMMwpNe2M R1Lx73BD0GKSiGIMkBdRYHk+P2TGjEHJqVC2N5wdyqA63gaHIIrYn8oq0yMQc4Ai2ty5 Ff127YW3bHtTxnWL33hu9PqMd4F2/CjUmtQKNJSWA2cdTaMNi955AuCkMNgu93tQRnI8 8CuG+7qWmj/whvs+4fhFSgBE0ZOPW5ut90XwLy07k2i8gqIuTqaobWo4qfxzOOluxytY uMf+rRKbgS1Vu6cqiu5hcmFblS7sPiOclmgpbClY7VTcuvXOyprSplTqsEunWIVlj6Lf RYtg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:reply-to:subject:to:cc:references:from :message-id:date:user-agent:mime-version:in-reply-to :content-language:content-transfer-encoding; bh=eMtCtWdeVzZeV55IU8Tvb/tZ5JncKmrPAx08QN5CpjQ=; b=G6ElWYypo1gbhH2uARVt4bV8WCVTJTfZI79sCmmwRAmFSlut6SZS5H1hWUqNli+eXW aXyO71zIBu4HFRTujZ7adgSil5qcUs2GyuZImDKaAlEUXce77dlvn/TRy1Or+WeIoXWC WwadUfOke+hOljVm60M1utF7rEbNie3ALgjA5i+UAGnfyQmC2khFWBBeLLEHkAk8YUo0 ctD7RwK+5sq4UFQWlxK15p1WUMQCTGwEVsPBewdN3Er8io0SGh+9oE/HwKK3n8m/8UAu vd+XobJ2v0Tt50tP++Q5RPMFsTqHARoJ+GuL/yOzwm23o68Qecuh4c3yAs3sEW9vyydE ez7w== X-Gm-Message-State: APjAAAWML2g67QuSFOXlcRe0dcc5pH3O/UlPf1IvHqgdZCLKgZIQuiWW OgaVl+oih5146ajBzzxoagMQ1GMm X-Google-Smtp-Source: APXvYqy/W2aaNi/PbDSiFmOiCVFYh6+5IYcnpoQMdL2xaZSgVaImuXya+P07ROuY5o+MusPGpMHSDg== X-Received: by 2002:a17:902:a03:: with SMTP id 3mr9562873plo.302.1561452337622; Tue, 25 Jun 2019 01:45:37 -0700 (PDT) Received: from [192.168.1.103] (180-150-68-130.b49644.syd.nbn.aussiebb.net. [180.150.68.130]) by smtp.gmail.com with ESMTPSA id y22sm26929811pfo.39.2019.06.25.01.45.35 (version=TLS1_3 cipher=AEAD-AES128-GCM-SHA256 bits=128/128); Tue, 25 Jun 2019 01:45:37 -0700 (PDT) Sender: Kubilay Kocak Reply-To: koobs@FreeBSD.org Subject: Re: svn commit: r505045 - head/sysutils/plasma5-ksysguard To: Piotr Kubaj Cc: "Tobias C. Berner" , ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org References: <201906241810.x5OIAu1h080487@repo.freebsd.org> <20190624194627.GB49520@ThinkPad-X200.g.anongoth.pl> <20190624202703.GA68048@ThinkPad-X200.g.anongoth.pl> <8eab69dc-52bb-a187-6a30-565ae58f4512@FreeBSD.org> <20190625082911.GA63640@KGPE-D16> From: Kubilay Kocak Message-ID: <5878f408-2030-7f57-ec1e-5f45e814433f@FreeBSD.org> Date: Tue, 25 Jun 2019 18:45:33 +1000 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:68.0) Gecko/20100101 Thunderbird/68.0 MIME-Version: 1.0 In-Reply-To: <20190625082911.GA63640@KGPE-D16> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit X-Rspamd-Queue-Id: 0D23F80360 X-Spamd-Bar: ------ Authentication-Results: mx1.freebsd.org X-Spamd-Result: default: False [-6.97 / 15.00]; NEURAL_HAM_MEDIUM(-1.00)[-1.000,0]; NEURAL_HAM_LONG(-1.00)[-1.000,0]; REPLY(-4.00)[]; NEURAL_HAM_SHORT(-0.97)[-0.971,0]; TAGGED_FROM(0.00)[] X-BeenThere: svn-ports-all@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: SVN commit messages for the ports tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 25 Jun 2019 08:45:39 -0000 On 25/06/2019 6:29 pm, Piotr Kubaj wrote: > To be honest, I fail to see the meaning of this flag. > > If it's not about approval, then what does this flag actually mean? Only > that "I acknowledge that there's a problem"? It means feedback is required. Feedback can take many forms. Not all bugs are patch submissions requiring (only) approval from a maintainer. Take for example, a bug report without a patch. maintainer-feedback? is set when issue is created. The maintainer comes back with 'i can reproduce the problem' and sets maintainer-feedback + (feedback provided). Triage sets need-patch keyword requesting a patch to fix the issue and sets maintainer-feedback? again, feedback this time being in the form of a patch. > Then maybe work-in-progress? As in, the maintainer is working on the fix. This doesn't cover feedback of forms that don't involve work/patches, the vast majority, and this is already covered by needs-patch keyword in any case. Again, if there's any way to improve the maintainer-feedback flag name to not mean 'approval' (as thats not what its for), I'd been keen to hear ideas. > On 19-06-25 11:59:32, Kubilay Kocak wrote: >> On 25/06/2019 6:27 am, Piotr Kubaj wrote: >>> OK, for me maintainer-feedback entry means that the patch is accepted. >>> >>> When I wasn't a committer, I used to set maintainer-feedback to indicate >>> that I accept the patch. When I send PR's nowadays, some maintainers >>> also do that. >>> >>> On 19-06-24 21:54:56, Tobias C. Berner wrote: >>>> I set maintainer feedback, because I, as the maintainer gave you the >>>> feedback, that "I think this is wrong" :) >>>> If I liked that patch, I would have set the patch-approved flag on it. >>>> >>>> >>>> All that said, thanks for "fixing" it, but I still would prefer a real >>>> fix, >>>> that we can upstream rather than that. >>>> >>>> >>>> mfg Tobias >>>> >>>> >>>> On Mon, 24 Jun 2019 at 21:46, Piotr Kubaj wrote: >>>> >>>>> Oh, I didn't use "implicit". Doesn't maintainer-feedback + mean that >>>>> it's >>>>> accepted? >>>>> >>>>> On 19-06-24 21:34:09, Tobias C. Berner wrote: >>>>> >Moin moin >>>>> > >>>>> >Sorry, but I explicitely did not approve this :) so using implicit >>>>> on it, >>>>> >is a bit of a crappy move. >>>>> > >>>>> >mfg Tobias >>>>> > >>>>> >On Mon, 24 Jun 2019 at 20:11, Piotr Kubaj wrote: >>>>> > >>>>> >> Author: pkubaj >>>>> >> Date: Mon Jun 24 18:10:55 2019 >>>>> >> New Revision: 505045 >>>>> >> URL: https://svnweb.freebsd.org/changeset/ports/505045 >>>>> >> >>>>> >> Log: >>>>> >>   sysutils/plasma5-ksysguard: fix build with GCC-based >>>>> architectures >>>>> >> >>>>> >>   Link with libinotify explicitly to fix linking on GCC >>>>> architectures. >>>>> >> >>>>> >>   PR:           238702 >>>>> >>   Approved by:  tcberner (maintainer, mentor) >>>>> >> >>>>> >> Modified: >>>>> >>   head/sysutils/plasma5-ksysguard/Makefile >>>>> >> >>>>> >> Modified: head/sysutils/plasma5-ksysguard/Makefile >>>>> >> >>>>> >> >>>>> ============================================================================== >>>>> >>>>> >>>>> >> --- head/sysutils/plasma5-ksysguard/Makefile    Mon Jun 24 >>>>> 18:07:12 2019 >>>>> >>       (r505044) >>>>> >> +++ head/sysutils/plasma5-ksysguard/Makefile    Mon Jun 24 >>>>> 18:10:55 2019 >>>>> >>       (r505045) >>>>> >> @@ -23,5 +23,6 @@ OPTIONS_SUB=  yes >>>>> >> >>>>> >>  INOTIFY_DESC=          Filesystem alteration notifications using >>>>> inotify >>>>> >>  INOTIFY_LIB_DEPENDS=   libinotify.so:devel/libinotify >>>>> >> +INOTIFY_LDFLAGS=       -linotify >>>>> >> >>>>> >>  .include >> >> >> What could we (bugmeister) name the flag so that it was clear that >> >> a) The flag is about needing feedback >> b) The flag has nothing to do with / does not mean approval? >> >>