From nobody Fri May 16 08:20:19 2025 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4ZzKl80GD5z5wJKl; Fri, 16 May 2025 08:20:20 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R11" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4ZzKl74G0gz3j23; Fri, 16 May 2025 08:20:19 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1747383619; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=Jou7N1sPI5vGIUxvzl439miiRnLy3w8XwQGUqH2ELms=; b=sNp17YrrDeESGT8uHRRnfE6Lwbik2zNYoN2rDSh40YDoBDH/06tSt3Xl7LLDGFJ3s9VwhY ma5+lVpeu9Pz3hxyxOZ4cCR6kep3gPMb2GHn5CpY5qrhtO4E2HCS6/5GXoPkh6D5vQWjgA IvDKHv11xY4YxxMHcwBS4SYZsKXzkCVWeHRKMrAPN8zW595YMSrxsKZ+I4Rs2F5PwHy11r YSUK8Q69PQKk9eNGiWD9yxQl+mO4YhJFmpFq/x0MxrSkssVVvSiKGR/ZfYSHor6Fq/MEXq 9+O1hgI6OzLCERMF8ZgQb93ZcLG/sRy8ELkbpk55jYO+3VB6nz+IvmCRicQpFQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1747383619; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=Jou7N1sPI5vGIUxvzl439miiRnLy3w8XwQGUqH2ELms=; b=oEx6aoQEwkl0WME/6LiKUPgLH/zvbUsGjWODaGyxKDNy+ndRBkbYcatWteGdoD2rRUpgsl PkdK6Um8mO3EyYTfmGO6f6Ij+nNVfwvBvmGKcKTJzQEGAltEUE0qClJvfnVlyb8TtxNr1g m4lMFcWZoX4cWWlnIcPLTPsfzZpWAO/ClAu4Lxk0z3aPLUR4N50g1N7f9Pgmgs1BaCsH2f Qel+el02bsQjOQXN613dnTvzDVZKXhbNqmDbsGWg/ok+6jSiCa+UcdC1pE92ran1SlTM4p T6isEVrzFCyFE8yNsNxAzsY7eZsMTTfdBcDChR6SHRBP5GorkJjbJxfWG3S/Gg== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1747383619; a=rsa-sha256; cv=none; b=dj04L0orre1FKrTRKrCH4RutL6i8rYjh9EWiZfonmqRIoytc1VpWB1sklC8rWE/Q+XohNE 5UWhhTOGWzRU/b2Q7QzSzrvnvGYfzN90VVIICvt8hEJWHXt+Cvd2BvfZLNB8zh4W/sfPg1 8Dz+IU9WTazqq85/KhDGxW9CVWOndMkZ1X2Wm3w4q99zDVbl3DPMY312Lx58ClzPnSRRyQ 1Ez6p30GXJ3ZkqjTc7xVBRHkhY8wQyo9s2QPAhXeu50esALG4zabLYRvgiTpk2PPLbbJrE Ychg9Wg6jdUmQ3xb37fRY/LcMgZ6T1qvWc2ocxfWpTuCzlB4NqU76qquME2dVQ== ARC-Authentication-Results: i=1; mx1.freebsd.org; none Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4ZzKl73b4pzw1n; Fri, 16 May 2025 08:20:19 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.18.1/8.18.1) with ESMTP id 54G8KJA9075322; Fri, 16 May 2025 08:20:19 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.18.1/8.18.1/Submit) id 54G8KJBH075319; Fri, 16 May 2025 08:20:19 GMT (envelope-from git) Date: Fri, 16 May 2025 08:20:19 GMT Message-Id: <202505160820.54G8KJBH075319@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Doug Moore Subject: git: ca18e0441029 - main - vm_page: update some iterator-related comments List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: dougm X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: ca18e0441029fc94076eb8441581ae07561cace0 Auto-Submitted: auto-generated The branch main has been updated by dougm: URL: https://cgit.FreeBSD.org/src/commit/?id=ca18e0441029fc94076eb8441581ae07561cace0 commit ca18e0441029fc94076eb8441581ae07561cace0 Author: Doug Moore AuthorDate: 2025-05-16 07:42:34 +0000 Commit: Doug Moore CommitDate: 2025-05-16 07:42:34 +0000 vm_page: update some iterator-related comments Update a stale comment about vm_page_alloc_iter(), and add a comment about one of its use cases. Reviewed by: kib, markj, alc Differential Revision: https://reviews.freebsd.org/D50263 --- sys/vm/vm_page.c | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/sys/vm/vm_page.c b/sys/vm/vm_page.c index 681846f8c71a..0fdda1d5fc48 100644 --- a/sys/vm/vm_page.c +++ b/sys/vm/vm_page.c @@ -1996,10 +1996,8 @@ vm_page_alloc(vm_object_t object, vm_pindex_t pindex, int req) } /* - * Allocate a page in the specified object with the given page index. To - * optimize insertion of the page into the object, the caller must also specify - * the resident page in the object with largest index smaller than the given - * page index, or NULL if no such page exists. + * Allocate a page in the specified object with the given page index. If the + * object lock is dropped and regained, the pages iter is reset. */ vm_page_t vm_page_alloc_iter(vm_object_t object, vm_pindex_t pindex, int req, @@ -5189,6 +5187,7 @@ retrylookup: break; m = vm_page_alloc_iter(object, pindex + i, pflags | VM_ALLOC_COUNT(count - i), &pages); + /* pages was reset if alloc_iter lost the lock. */ if (m == NULL) { if ((allocflags & (VM_ALLOC_NOWAIT | VM_ALLOC_WAITFAIL)) != 0)