Date: Tue, 19 Aug 2014 15:07:37 +0000 From: bugzilla-noreply@freebsd.org To: freebsd-ports-bugs@FreeBSD.org Subject: [Bug 190283] [stage] Add staging support to www/moodle24 Message-ID: <bug-190283-13-6AsWXisvwb@https.bugs.freebsd.org/bugzilla/> In-Reply-To: <bug-190283-13@https.bugs.freebsd.org/bugzilla/> References: <bug-190283-13@https.bugs.freebsd.org/bugzilla/>
next in thread | previous in thread | raw e-mail | index | archive | help
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=190283 --- Comment #9 from John Marino <marino@FreeBSD.org> --- That's good but I see several issues. #1) your commands in the install targets are masked with "@". This is against policy (even if it was there before) #2) wen@ isn't the maintainer, so it means your patch wasn't generated against the latest tree. #3) there's no point to a pre-install and do-install target. They should be combined to a single "do-install" target. That's just a 5-second review -- You are receiving this mail because: You are the assignee for the bug.
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?bug-190283-13-6AsWXisvwb>