From owner-svn-src-all@FreeBSD.ORG  Sun Dec 27 19:11:06 2009
Return-Path: <owner-svn-src-all@FreeBSD.ORG>
Delivered-To: svn-src-all@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 84DD0106566B;
	Sun, 27 Dec 2009 19:11:06 +0000 (UTC) (envelope-from ed@hoeg.nl)
Received: from palm.hoeg.nl (mx0.hoeg.nl [IPv6:2001:7b8:613:100::211])
	by mx1.freebsd.org (Postfix) with ESMTP id 296EC8FC0C;
	Sun, 27 Dec 2009 19:11:06 +0000 (UTC)
Received: by palm.hoeg.nl (Postfix, from userid 1000)
	id 0FA621CE29; Sun, 27 Dec 2009 20:11:05 +0100 (CET)
Date: Sun, 27 Dec 2009 20:11:04 +0100
From: Ed Schouten <ed@80386.nl>
To: Doug Barton <dougb@FreeBSD.org>
Message-ID: <20091227191104.GZ64905@hoeg.nl>
References: <200912200134.nBK1YCAA048942@svn.freebsd.org>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha1;
	protocol="application/pgp-signature"; boundary="IbHvapklzsHS+ltG"
Content-Disposition: inline
In-Reply-To: <200912200134.nBK1YCAA048942@svn.freebsd.org>
User-Agent: Mutt/1.5.20 (2009-06-14)
Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org,
	src-committers@freebsd.org
Subject: Re: svn commit: r200743 - in head/usr.sbin: . service
X-BeenThere: svn-src-all@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: "SVN commit messages for the entire src tree \(except for &quot;
	user&quot; and &quot; projects&quot; \)" <svn-src-all.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-all>,
	<mailto:svn-src-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-all>
List-Post: <mailto:svn-src-all@freebsd.org>
List-Help: <mailto:svn-src-all-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-all>,
	<mailto:svn-src-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sun, 27 Dec 2009 19:11:06 -0000


--IbHvapklzsHS+ltG
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

Doug,

Even though I think having a help-feature is nice, just expecting users
to open up the proper manual page seems to be our tradition. Because of
that, I think we should change the usage-output to conform a bit more
with other applications. We should also display "-l | -r" instead of
"-l|r".

What do you think about the following patch?

%%%
Index: service.8
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D
--- service.8	(revision 201047)
+++ service.8	(working copy)
@@ -35,7 +35,7 @@
 .Fl e
 .Nm
 .Op Fl v
-.Fl l|r
+.Fl l | r
 .Nm
 .Op Fl v
 .Ar <rc.d script> start|stop|etc.
Index: service.sh
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D
--- service.sh	(revision 201047)
+++ service.sh	(working copy)
@@ -30,24 +30,14 @@
 load_rc_config 'XXX'
=20
 usage () {
-	echo ''
-	echo 'Usage:'
-	echo "${0##*/} -e"
-	echo "${0##*/} [-v] -l|r"
-	echo "${0##*/} [-v] <rc.d script> start|stop|etc."
-	echo "${0##*/} -h"
-	echo ''
-	echo '-e	Show services that are enabled'
-	echo "-l	List all scripts in /etc/rc.d and $local_startup"
-	echo '-r	Show the results of boot time rcorder'
-	echo '-v	Verbose'
-	echo ''
+	echo "usage: ${0##*/} -e"
+	echo "       ${0##*/} [-v] -l | -r"
+	echo "       ${0##*/} [-v] <rc.d script> start|stop|etc."
 }
=20
 while getopts 'ehlrv' COMMAND_LINE_ARGUMENT ; do
 	case "${COMMAND_LINE_ARGUMENT}" in
 	e)	ENABLED=3Deopt ;;
-	h)	usage ; exit 0 ;;
 	l)	LIST=3Dlopt ;;
 	r)	RCORDER=3Dropt ;;
 	v)	VERBOSE=3Dvopt ;;
%%%

--=20
 Ed Schouten <ed@80386.nl>
 WWW: http://80386.nl/

--IbHvapklzsHS+ltG
Content-Type: application/pgp-signature
Content-Disposition: inline

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.10 (FreeBSD)

iEYEARECAAYFAks3sUgACgkQ52SDGA2eCwW28wCeMXcYnGNXtpBA9jWVav/9OQJT
Ga0An0LtWGAApweAuaDR1oDvqQ0VdQ1c
=mB2X
-----END PGP SIGNATURE-----

--IbHvapklzsHS+ltG--