From owner-svn-src-all@FreeBSD.ORG Thu May 30 15:56:38 2013 Return-Path: Delivered-To: svn-src-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by hub.freebsd.org (Postfix) with ESMTP id D5A6341E; Thu, 30 May 2013 15:56:38 +0000 (UTC) (envelope-from yanegomi@gmail.com) Received: from mail-pb0-x234.google.com (mail-pb0-x234.google.com [IPv6:2607:f8b0:400e:c01::234]) by mx1.freebsd.org (Postfix) with ESMTP id 9806317E; Thu, 30 May 2013 15:56:38 +0000 (UTC) Received: by mail-pb0-f52.google.com with SMTP id xa12so595033pbc.39 for ; Thu, 30 May 2013 08:56:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=subject:mime-version:content-type:from:in-reply-to:date:cc :content-transfer-encoding:message-id:references:to:x-mailer; bh=nF4BJWIDsBKeRovce/e38Sr0Dx1OV+mbygvHH9L065o=; b=F9haGIRJMuTX9zz/fI75jjwuVOgcr2tu8FgfbRMnlEcG7uk/07vEAYggmfcHSHerw7 Xkeis5sVGWsEk40kz0Km5L9YP+cQQ9ZXIPil+kZDXIi/wDjVb+J9E0rO8y9LQ1gsW7Xr 1Q6mifTucS33NZvcvXsdbeirYnfB14uLhtoEisCv5tM5HgI0DFilKB1GTclgOUC4ILCi NEbDHPKjzH3IYZiuVbNVGciZHvjFq5u+QeuRm5/0GIjz8vo0w1dIohxyBPm5RiQkjAYN L8u5IWnNI58imZ4uJLS7HN2Z5QJRyxYdNOhPgh8GJ89x7tJBfQgt1MhrkUERsgnCo8jq 741w== X-Received: by 10.69.2.228 with SMTP id br4mr8540930pbd.91.1369929398348; Thu, 30 May 2013 08:56:38 -0700 (PDT) Received: from [192.168.20.5] (c-98-203-241-95.hsd1.wa.comcast.net. [98.203.241.95]) by mx.google.com with ESMTPSA id ra4sm45413339pab.9.2013.05.30.08.56.35 for (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Thu, 30 May 2013 08:56:36 -0700 (PDT) Subject: Re: svn commit: r251140 - head Mime-Version: 1.0 (Apple Message framework v1283) Content-Type: text/plain; charset=us-ascii From: Garrett Cooper In-Reply-To: <201305301409.r4UE9wSP009396@svn.freebsd.org> Date: Thu, 30 May 2013 08:56:33 -0700 Content-Transfer-Encoding: quoted-printable Message-Id: References: <201305301409.r4UE9wSP009396@svn.freebsd.org> To: Brooks Davis X-Mailer: Apple Mail (2.1283) Cc: svn-src-head@freebsd.org, Glen Barber , svn-src-all@freebsd.org, src-committers@freebsd.org, hrs@FreeBSD.org X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 30 May 2013 15:56:38 -0000 On May 30, 2013, at 7:09 AM, Brooks Davis wrote: > Author: brooks > Date: Thu May 30 14:09:58 2013 > New Revision: 251140 > URL: http://svnweb.freebsd.org/changeset/base/251140 >=20 > Log: > Always define INSTALL_DDIR and define it such that it contains no = extra > / characters rather than removing them later on. This should fix > release builds. >=20 > PR: conf/178963 > Reviewed by: gjb, hrs This is similar to a fix/enhancement I've made to Makefile.inc1 on my = atf-tools-regression-convert branch: = https://github.com/yaneurabeya/freebsd/blob/atf-tools-regression-convert/M= akefile.inc1 . There are two key differences between my changes and this one: 1. I more consistently used INSTALL_DDIR in the Makefile as there were a = number of spots where it wasn't doing that, but instead explicitly = stating ${DESTDIR}/${DISTDIR}. 2. I properly deal with removing adjacent / by using the {2,} regexp = quantifier as the current code only deals with even number of repeating = /, not odd number of repeating / (not sure why this even mattered in the = first place because this should be properly handled by whatever tool is = calculating the absolute path, but I won't question why this is being = done any further). Thanks! -Garrett=