Date: Fri, 26 Jul 2024 13:14:23 -0400 From: "Drew Gallatin" <gallatin@freebsd.org> To: "Konstantin Belousov" <kib@freebsd.org>, src-committers@freebsd.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org Subject: Re: git: c097967b9af9 - main - mlx5en: add diagnostic in one more case of failed eeprom read preparation Message-ID: <52e1bb60-32f3-49de-9714-78762edbfd4c@app.fastmail.com> In-Reply-To: <202405060315.4463FxP6098471@gitrepo.freebsd.org> References: <202405060315.4463FxP6098471@gitrepo.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
--775e74ac73ea4ddb9d8a89b5497dea89 Content-Type: text/plain Hi, This recently hit our tree and was deployed, and our operations team is quite upset because this results in a massive (orders of magnitude) increase in our kernel log messages due to our monitoring scripts probing each port. Can we please move this under bootverbose, or have some other way to suppress these prints? I can back this out in our tree, but I don't want to create yet another local patch. Thank you, Drew On Sun, May 5, 2024, at 11:15 PM, Konstantin Belousov wrote: > The branch main has been updated by kib: > > URL: https://cgit.FreeBSD.org/src/commit/?id=c097967b9af946cf46246cce5adde53f7e955ecc > > commit c097967b9af946cf46246cce5adde53f7e955ecc > Author: Konstantin Belousov <kib@FreeBSD.org> > AuthorDate: 2024-05-05 07:09:07 +0000 > Commit: Konstantin Belousov <kib@FreeBSD.org> > CommitDate: 2024-05-06 03:15:35 +0000 > > mlx5en: add diagnostic in one more case of failed eeprom read preparation > > Sponsored by: Nvidia Networking > MFC after: 1 week > --- > sys/dev/mlx5/mlx5_en/mlx5_en_main.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/sys/dev/mlx5/mlx5_en/mlx5_en_main.c b/sys/dev/mlx5/mlx5_en/mlx5_en_main.c > index e1dbd02fcf3a..962705e6d258 100644 > --- a/sys/dev/mlx5/mlx5_en/mlx5_en_main.c > +++ b/sys/dev/mlx5/mlx5_en/mlx5_en_main.c > @@ -3674,6 +3674,9 @@ out: > /* Check if module is present before doing an access */ > module_status = mlx5_query_module_status(priv->mdev, module_num); > if (module_status != MLX5_MODULE_STATUS_PLUGGED_ENABLED) { > + mlx5_en_err(ifp, > + "Query module %d status: not plugged (%d), eeprom reading is not supported\n", > + module_num, module_status); > error = EINVAL; > goto err_i2c; > } > --775e74ac73ea4ddb9d8a89b5497dea89 Content-Type: text/html Content-Transfer-Encoding: quoted-printable <!DOCTYPE html><html><head><title></title><style type=3D"text/css">p.Mso= Normal,p.MsoNoSpacing{margin:0}</style></head><body><div>Hi,<br></div><d= iv><br></div><div>This recently hit our tree and was deployed, and our o= perations team is quite upset because this results in a massive (orders = of magnitude) increase in our kernel log messages due to our monit= oring scripts probing each port.<br></div><div><br></div><div>Can we ple= ase move this under bootverbose, or have some other way to suppress thes= e prints? I can back this out in our tree, but I don't want to cre= ate yet another local patch.<br></div><div><br></div><div>Thank you,<br>= </div><div><br></div><div>Drew<br></div><div><br></div><div>On Sun, May = 5, 2024, at 11:15 PM, Konstantin Belousov wrote:<br></div><blockquote ty= pe=3D"cite" id=3D"qt" style=3D""><div>The branch main has been updated b= y kib:<br></div><div><br></div><div>URL: <a href=3D"https://cgit.Fr= eeBSD.org/src/commit/?id=3Dc097967b9af946cf46246cce5adde53f7e955ecc">htt= ps://cgit.FreeBSD.org/src/commit/?id=3Dc097967b9af946cf46246cce5adde53f7= e955ecc</a><br></div><div><br></div><div>commit c097967b9af946cf46246cce= 5adde53f7e955ecc<br></div><div>Author: Konstanti= n Belousov <<a href=3D"mailto:kib@FreeBSD.org">kib@FreeBSD.org</a>>= ;<br></div><div>AuthorDate: 2024-05-05 07:09:07 +0000<br></div><div>Comm= it: Konstantin Belousov <<a href=3D"mailto:ki= b@FreeBSD.org">kib@FreeBSD.org</a>><br></div><div>CommitDate: 2024-05= -06 03:15:35 +0000<br></div><div><br></div><div> mlx5e= n: add diagnostic in one more case of failed eeprom read preparation<br>= </div><div> <br></div><div> Spo= nsored by: Nvidia Networking<br></div><div>  = ; MFC after: 1 week<br></div><div>---<br><= /div><div>sys/dev/mlx5/mlx5_en/mlx5_en_main.c | 3 +++<br></div><div>1 fi= le changed, 3 insertions(+)<br></div><div><br></div><div>diff --git a/sy= s/dev/mlx5/mlx5_en/mlx5_en_main.c b/sys/dev/mlx5/mlx5_en/mlx5_en_main.c<= br></div><div>index e1dbd02fcf3a..962705e6d258 100644<br></div><div>--- = a/sys/dev/mlx5/mlx5_en/mlx5_en_main.c<br></div><div>+++ b/sys/dev/mlx5/m= lx5_en/mlx5_en_main.c<br></div><div>@@ -3674,6 +3674,9 @@ out:<br></div>= <div>/* Check if module is present before doing an access */<br></div><d= iv>module_status =3D mlx5_query_module_status(priv->mdev, module_num)= ;<br></div><div>if (module_status !=3D MLX5_MODULE_STATUS_PLUGGED_ENABLE= D) {<br></div><div>+ mlx5_en_err(ifp,<br></div><div>+ &n= bsp; "Query module %d status: not plugged (%d), eeprom reading is not su= pported\n",<br></div><div>+ module_num, module_stat= us);<br></div><div>error =3D EINVAL;<br></div><div>goto err_i2c;<br></di= v><div>}<br></div><div><br></div></blockquote><div><br></div></body></ht= ml> --775e74ac73ea4ddb9d8a89b5497dea89--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?52e1bb60-32f3-49de-9714-78762edbfd4c>