From owner-svn-src-projects@freebsd.org Wed Feb 13 15:09:02 2019 Return-Path: Delivered-To: svn-src-projects@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id C121514F1F2F for ; Wed, 13 Feb 2019 15:09:02 +0000 (UTC) (envelope-from yaneurabeya@gmail.com) Received: from mail-pf1-x441.google.com (mail-pf1-x441.google.com [IPv6:2607:f8b0:4864:20::441]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 2C40E8E40F; Wed, 13 Feb 2019 15:09:02 +0000 (UTC) (envelope-from yaneurabeya@gmail.com) Received: by mail-pf1-x441.google.com with SMTP id h1so1265042pfo.7; Wed, 13 Feb 2019 07:09:02 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:subject:from:in-reply-to:date:cc :content-transfer-encoding:message-id:references:to; bh=f2I7oUW51OM6c652LpojxrAjS/S37aslLbs3+usZvzg=; b=mv1EsmmQmiCpsdGv/+xwYUToeommhPbyuCw9iQ7Vk9M4gYVCKdI1s9E9cOymMrY3NO emm5HEVOdtbNGY56jtWE6fysR71S/Czb3PDFoIzx+9BZJGK1S9nXP3oPcgn4JiKt8DLR xIOG+xODvZC6zl1edIGtB6nZD7MQ5uqE30ycfMzgYlVcecAV4YAjRDhw/z0YK4oH9DVV ORIT1J8vdNo4BuITEgGslVED5TI/J+5epuXs3nXFaLGQLJ+5wupnBgKQ+cpxDs+JPgQu VNwSYKtj9oscj7Afq+MkPuO2BwDBuTxRejoDrSIGiBILIswJ3s2nszA2xteot4TciWa+ CKtg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:subject:from:in-reply-to:date:cc :content-transfer-encoding:message-id:references:to; bh=f2I7oUW51OM6c652LpojxrAjS/S37aslLbs3+usZvzg=; b=fvbzJGxBeOlSv11RLBExEBbxbXsyudZ3So/zCoLUsvTrK9x8dRugJQNkwo/0/zPWQG CWrC3abpJLUFCfuLzvAulv2cXPEToe+/J0TzZJqCuO/d9pm1De40RQEYySLkitHHuQJ7 4YF9QZQMAOt6hiaSz/UKhmi5GGnAFCvnhDOlRR+arRVlj9+kysMd4AfiO3d4WpiE3yji ILT8xDxZrCWXZCNB4Ex3GBzBCGDp/BchnKUaBrwN+PJeS2eNSRgJ/3GjBPui1bCibDHR RQiPwyGyZFYxGgol8GAtoptN5Kx9GDxSiRWnsERUigjZQGZbuOlqWc+3ozRCdVqwL9wu jddQ== X-Gm-Message-State: AHQUAuZXNlK+zV7BGX/ZqM+3Zkni0gA183DvDAvS1UU8zhTbqJ2a5iOo ahXEvBWDyoLPAesZNnXMYZUzLl41 X-Google-Smtp-Source: AHgI3IbNzB69tx5wcbFu5HXjXHq+lRelkh1owfTSlyNN7CjEZH3YyB9GowjP5NYgQR+oxr8PerNftQ== X-Received: by 2002:a62:b286:: with SMTP id z6mr978033pfl.106.1550070540627; Wed, 13 Feb 2019 07:09:00 -0800 (PST) Received: from ?IPv6:2607:fb90:a695:22c1:409c:1f73:a1ae:a38e? ([2607:fb90:a695:22c1:409c:1f73:a1ae:a38e]) by smtp.gmail.com with ESMTPSA id h8sm19489608pgv.27.2019.02.13.07.08.59 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 13 Feb 2019 07:08:59 -0800 (PST) Content-Type: text/plain; charset=utf-8 Mime-Version: 1.0 (1.0) Subject: Re: svn commit: r344087 - in projects/import-googletest-1.8.1/lib/googletest: gmock/tests gtest/tests From: Enji Cooper X-Mailer: iPhone Mail (16C104) In-Reply-To: <201902131442.x1DEgcsa081703@pdx.rh.CN85.dnsmgr.net> Date: Wed, 13 Feb 2019 07:08:58 -0800 Cc: Enji Cooper , src-committers@freebsd.org, svn-src-projects@freebsd.org Content-Transfer-Encoding: quoted-printable Message-Id: <7F4DB347-CD49-4A09-A360-7DBAB33EEBC6@gmail.com> References: <201902131442.x1DEgcsa081703@pdx.rh.CN85.dnsmgr.net> To: rgrimes@freebsd.org X-Rspamd-Queue-Id: 2C40E8E40F X-Spamd-Bar: ------ Authentication-Results: mx1.freebsd.org X-Spamd-Result: default: False [-6.92 / 15.00]; NEURAL_HAM_MEDIUM(-0.99)[-0.995,0]; NEURAL_HAM_SHORT(-0.92)[-0.924,0]; REPLY(-4.00)[]; NEURAL_HAM_LONG(-1.00)[-1.000,0] X-BeenThere: svn-src-projects@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "SVN commit messages for the src " projects" tree" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 13 Feb 2019 15:09:03 -0000 On Feb 13, 2019, at 06:42, Rodney W. Grimes = wrote: >> On Feb 13, 2019, at 06:26, Rodney W. Grimes wrote: >>=20 >>>> Author: ngie >>>> Date: Wed Feb 13 05:41:04 2019 >>>> New Revision: 344087 >>>> URL: https://svnweb.freebsd.org/changeset/base/344087 >>>>=20 >>>> Log: >>>> Compile the tests without -Werror for now >>>>=20 >>>> I'm working on resolving the issue upstream on github >>>>=20 >>>> Modified: >>>> projects/import-googletest-1.8.1/lib/googletest/gmock/tests/Makefile >>>> projects/import-googletest-1.8.1/lib/googletest/gtest/tests/Makefile >>>=20 >>> Are we going to have to live with this project name of >>> import-googletest-1.8.1 long term, or is this just a >>> stepping stone? >>=20 >> It?s a short lived project. I didn?t realize in the last year and a >> half that branch names had formalized into something else, especially >> since GUIDELINES.txt doesn?t state a naming convention. >=20 > I do not know that they have formalized in any way. But as long > as it is shorted lived it really does not matter much. >=20 > Please do be careful when choosing a vendor/ directory name > if that is where this is headed, 'import' and '1.8.1' are > probably not wanted there at all, just googletest. brooks reviewed my initial import into vendor to ensure that the naming/stru= cture was correct: ^/vendor/google/googletest/dist -> ^/vendor/google/google= test/1.8.1 (for the release branch, given that the initial import was 1.8.1)= . I=E2=80=99ve been following similar conventions before in the past other pro= jects I=E2=80=99ve imported. Given that this is the first of a handful of go= ogle projects that will be imported, I don=E2=80=99t understand why there=E2= =80=99s an issue with this naming convention. -Enji=