From owner-svn-src-all@freebsd.org Wed May 22 15:10:29 2019 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 05FFA15AE10B; Wed, 22 May 2019 15:10:29 +0000 (UTC) (envelope-from danfe@freebsd.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2610:1c1:1:6074::16:84]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "freefall.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 9CB4B89DFA; Wed, 22 May 2019 15:10:28 +0000 (UTC) (envelope-from danfe@freebsd.org) Received: by freefall.freebsd.org (Postfix, from userid 1033) id 8DE971628A; Wed, 22 May 2019 15:10:28 +0000 (UTC) Date: Wed, 22 May 2019 15:10:28 +0000 From: Alexey Dokuchaev To: Alexander Motin Cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r345815 - in head: lib/libcam sys/cam sys/cam/nvme Message-ID: <20190522151028.GA29205@FreeBSD.org> References: <201904021937.x32JbrRk067921@repo.freebsd.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <201904021937.x32JbrRk067921@repo.freebsd.org> User-Agent: Mutt/1.11.4 (2019-03-13) X-Rspamd-Queue-Id: 9CB4B89DFA X-Spamd-Bar: -- Authentication-Results: mx1.freebsd.org X-Spamd-Result: default: False [-2.89 / 15.00]; local_wl_from(0.00)[freebsd.org]; NEURAL_HAM_MEDIUM(-1.00)[-0.998,0]; NEURAL_HAM_LONG(-1.00)[-0.999,0]; NEURAL_HAM_SHORT(-0.89)[-0.890,0]; ASN(0.00)[asn:11403, ipnet:2610:1c1:1::/48, country:US] X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 22 May 2019 15:10:29 -0000 On Tue, Apr 02, 2019 at 07:37:53PM +0000, Alexander Motin wrote: > New Revision: 345815 > URL: https://svnweb.freebsd.org/changeset/base/345815 > > Log: > Make cam_error_print() decode NVMe commands. > > Modified: head/sys/cam/nvme/nvme_xpt.c > ... > @@ -769,11 +769,13 @@ nvme_proto_debug_out(union ccb *ccb) > { > char cdb_str[(sizeof(struct nvme_command) * 3) + 1]; > > - if (ccb->ccb_h.func_code != XPT_NVME_IO) > + if (ccb->ccb_h.func_code != XPT_NVME_IO || > + ccb->ccb_h.func_code != XPT_NVME_ADMIN) > return; PVS Studio complains that "Expression is always true. Probably the '&&' operator should be used here". Can you take a look? ./danfe