From owner-freebsd-geom@FreeBSD.ORG Wed Oct 19 20:14:05 2011 Return-Path: Delivered-To: freebsd-geom@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 4A4E8106564A for ; Wed, 19 Oct 2011 20:14:05 +0000 (UTC) (envelope-from pawel@dawidek.net) Received: from mail.dawidek.net (60.wheelsystems.com [83.12.187.60]) by mx1.freebsd.org (Postfix) with ESMTP id B45C58FC13 for ; Wed, 19 Oct 2011 20:14:04 +0000 (UTC) Received: from localhost (89-73-195-149.dynamic.chello.pl [89.73.195.149]) by mail.dawidek.net (Postfix) with ESMTPSA id 9CE587D9; Wed, 19 Oct 2011 22:13:59 +0200 (CEST) Date: Wed, 19 Oct 2011 22:13:17 +0200 From: Pawel Jakub Dawidek To: Garrett Cooper Message-ID: <20111019201317.GC1982@garage.freebsd.pl> References: <924643A0-0798-4FAC-8F82-4AFBC56DC8D7@gmail.com> <7EC93C28-6405-443F-92C6-0291F8D88995@gmail.com> <20111017132945.GG1679@garage.freebsd.pl> <20111019161833.GB1982@garage.freebsd.pl> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="oJ71EGRlYNjSvfq7" Content-Disposition: inline In-Reply-To: X-OS: FreeBSD 9.0-CURRENT amd64 User-Agent: Mutt/1.5.21 (2010-09-15) Cc: Xin LI , freebsd-geom@freebsd.org Subject: Re: GELI devices produced with 9.0+ fail when mounted on 8.2, etc? X-BeenThere: freebsd-geom@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: GEOM-specific discussions and implementations List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 19 Oct 2011 20:14:05 -0000 --oJ71EGRlYNjSvfq7 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Wed, Oct 19, 2011 at 09:37:33AM -0700, Garrett Cooper wrote: > On Wed, Oct 19, 2011 at 9:18 AM, Pawel Jakub Dawidek wr= ote: > > On Wed, Oct 19, 2011 at 08:30:39AM -0700, Garrett Cooper wrote: > >> Patch added for the first suggestion here: > >> http://www.freebsd.org/cgi/query-pr.cgi?pr=3D161807 . I'll see if I can > >> get around to the other two sometime before the end of the week. > > > > I'm already working on this. Unfortunately 'upgrade' subcommand will be > > much harder to implement, because in some cases we would need to rewrite > > the data for the entire provider. I decided not to add upgrade. It also > > doesn't buy us much. Even after upgrade you cannot switch to new > > algorithms or to multi-key encryption, etc. > > > > Instead I added 'version' subcommand: > > > > =A0 =A0 =A0 =A0geli version [-l] > > =A0 =A0 =A0 =A0geli version [prov ...] > > > > Examples: > > > > =A0 =A0 =A0 =A0# geli version > > =A0 =A0 =A0 =A0kernel: 6 > > =A0 =A0 =A0 =A0userland: 5 > > > > =A0 =A0 =A0 =A0# geli version ada0 gpt/secret > > =A0 =A0 =A0 =A0ada0: 5 > > =A0 =A0 =A0 =A0gpt/secret: 3 > > > > =A0 =A0 =A0 =A0# geli version -l > > =A0 =A0 =A0 =A0FreeBSD version: highest supported GELI version: > > =A0 =A0 =A0 =A0FreeBSD 6.0: 0 > > =A0 =A0 =A0 =A0FreeBSD 6.1: 0 > > =A0 =A0 =A0 =A0FreeBSD 6.2: 3 > > =A0 =A0 =A0 =A0FreeBSD 6.3: 3 > > =A0 =A0 =A0 =A0FreeBSD 6.4: 3 > > =A0 =A0 =A0 =A0FreeBSD 7.0: 3 > > =A0 =A0 =A0 =A0FreeBSD 7.1: 3 > > =A0 =A0 =A0 =A0FreeBSD 7.2: 3 > > =A0 =A0 =A0 =A0FreeBSD 7.3: 3 > > =A0 =A0 =A0 =A0FreeBSD 7.4: 3 > > =A0 =A0 =A0 =A0FreeBSD 8.0: 3 > > =A0 =A0 =A0 =A0FreeBSD 8.1: 3 > > =A0 =A0 =A0 =A0FreeBSD 8.2: 5 > > =A0 =A0 =A0 =A0FreeBSD 9.0: 6 >=20 > Wouldn't it be better to document this in a manpage like I suggested > so the code could be MFCed easier? Manual page is in the same place as source code, so it doesn't really matter if we merge geli.8 or geom_eli.c. I was planing to put this into manual page as well, but I think that having it only in the manual page should be enough indeed. > Also, I like the thought of having a separate subcommand -- version -- > for displaying the version output of a geli image. It seems like: >=20 > geli upgrade md0 You meant 'version' here, right? > should just upgrade md0 to the latest supported metadata format > instead of printing out the metadata version, as the implied metadata > version should be the latest one by default. Well, as I said, upgrading is often not possible, as it would require rewrite of all the data, as the code assumes for example that if this is version X, IV should be calculated this way and if it Y some other way, etc. --=20 Pawel Jakub Dawidek http://www.wheelsystems.com FreeBSD committer http://www.FreeBSD.org Am I Evil? Yes, I Am! http://yomoli.com --oJ71EGRlYNjSvfq7 Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.14 (FreeBSD) iEYEARECAAYFAk6fL10ACgkQForvXbEpPzQjhACfXARMnjUlPoOm0VMjNX0pEEJo FnkAoIiV0jFwuJ9yI/9jIV4eZfs0DM9Z =e96d -----END PGP SIGNATURE----- --oJ71EGRlYNjSvfq7--