From owner-svn-src-all@freebsd.org Tue May 19 15:02:30 2020 Return-Path: Delivered-To: svn-src-all@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id E790E2DB216; Tue, 19 May 2020 15:02:30 +0000 (UTC) (envelope-from gallatin@cs.duke.edu) Received: from duke.cs.duke.edu (duke.cs.duke.edu [152.3.140.1]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 49RJyY3QnGz4f1l; Tue, 19 May 2020 15:02:29 +0000 (UTC) (envelope-from gallatin@cs.duke.edu) Received: from [192.168.1.2] (pool-74-110-182-118.rcmdva.fios.verizon.net [74.110.182.118]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) (Authenticated sender: gallatin) by duke.cs.duke.edu (Postfix) with ESMTPSA id 2898C2700092; Tue, 19 May 2020 11:02:28 -0400 (EDT) DMARC-Filter: OpenDMARC Filter v1.3.1 duke.cs.duke.edu 2898C2700092 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=cs.duke.edu; s=mail0816; t=1589900548; bh=UCs2cCLpTnnmn/S+nmUrWIlRIRC/J+ss33J/43D3sqs=; h=Subject:To:From:Date:From; b=bjus9jygTBuK/tiFbnBrv+CR2h92pbhoBj1VyHIEeEenyR/pDOPr3b4fXik6B7W+r Qh8VEn2nrwuXzo4sH0wtTYDcl1tCEMoCuH6+2djg4jte/RDZyjOgJAA0daGwsAod4G HVOfBp0i/jSxhs8SeGm4FFi2WEkKJjCzGTbR4nF9GzxZvUNthIkPiILkJzYRE/0brp qfNGiQAf1hy9fVLMOwkk+t7PAn9+pMFRqZu4ezkhfYEB2z1YooGvAFoSa+/x4XA0ga /ZR0fFzkMhvKGnocdAeHziyw0dJbtU07xlaiGXN6gerSrdhhAjybVl4jx6fmJumlfb zc0m634YLma9A== Subject: Re: svn commit: r347418 - head/sys/net To: Kristof Provost , Eric Joyner , Jacob Keller , shurd@FreeBSD.org Cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org References: <201905100041.x4A0fhNT083122@repo.freebsd.org> <3BBFB371-EA44-4EE9-8A55-542CDE273CC4@FreeBSD.org> From: Andrew Gallatin Message-ID: Date: Tue, 19 May 2020 11:02:27 -0400 User-Agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:68.0) Gecko/20100101 Thunderbird/68.6.0 MIME-Version: 1.0 In-Reply-To: <3BBFB371-EA44-4EE9-8A55-542CDE273CC4@FreeBSD.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit X-Rspamd-Queue-Id: 49RJyY3QnGz4f1l X-Spamd-Bar: --- Authentication-Results: mx1.freebsd.org; dkim=pass header.d=cs.duke.edu header.s=mail0816 header.b=bjus9jyg; dmarc=pass (policy=none) header.from=cs.duke.edu; spf=pass (mx1.freebsd.org: domain of gallatin@cs.duke.edu designates 152.3.140.1 as permitted sender) smtp.mailfrom=gallatin@cs.duke.edu X-Spamd-Result: default: False [-3.71 / 15.00]; RCVD_VIA_SMTP_AUTH(0.00)[]; ARC_NA(0.00)[]; R_DKIM_ALLOW(-0.20)[cs.duke.edu:s=mail0816]; RCVD_IN_DNSWL_LOW(-0.10)[152.3.140.1:from]; FROM_HAS_DN(0.00)[]; TO_DN_SOME(0.00)[]; R_SPF_ALLOW(-0.20)[+ip4:152.3.140.0/23]; MIME_GOOD(-0.10)[text/plain]; NEURAL_HAM_MEDIUM(-0.97)[-0.974]; DWL_DNSWL_LOW(-1.00)[duke.edu:dkim]; RECEIVED_SPAMHAUS_PBL(0.00)[74.110.182.118:received]; TO_MATCH_ENVRCPT_SOME(0.00)[]; DKIM_TRACE(0.00)[cs.duke.edu:+]; DMARC_POLICY_ALLOW(-0.50)[cs.duke.edu,none]; RCPT_COUNT_SEVEN(0.00)[7]; NEURAL_HAM_SHORT(-0.63)[-0.633]; FROM_EQ_ENVFROM(0.00)[]; MIME_TRACE(0.00)[0:+]; ASN(0.00)[asn:13371, ipnet:152.3.128.0/17, country:US]; MID_RHS_MATCH_FROM(0.00)[]; RCVD_TLS_ALL(0.00)[]; RCVD_COUNT_TWO(0.00)[2] X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.33 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 19 May 2020 15:02:31 -0000 On 2020-05-19 04:21, Kristof Provost wrote: > The if_bnxt driver initialises |.isc_nrxd_max = {INT32_MAX, INT32_MAX, > INT32_MAX},|, so presumably that’s the cause. > I don’t know what a sane value would be though. I’ve defaulted to 4096 > (because that’s what some other iflib users seems to do) for now, and > that seems to work. It doesn’t panic and I can get traffic through it at > least: You seem to be setting the max, not the default, and 4K max descriptors on a 100g device is going to basically cripple it. How about setting to the next power of 2 below max int so as to keep with the authors intent? If we don't already have a macro, something like (INT32_MAX >> 1) + 1 Drew