From nobody Tue Jul 7 20:57:58 2026 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4gvtpv1JX2z6kT4r for ; Tue, 07 Jul 2026 20:57:59 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "YR1" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 4gvtpt60w3z3m8Q for ; Tue, 07 Jul 2026 20:57:58 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1783457878; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=sIpl36ts4s0E3mnOI9B/AFHcx2D49/88PI828BuEZhE=; b=Byy99omhIFfK5TJxidpE9QpUCHSM1QzRZChA0YEzlILoI0/rykoo587hVbRhzoMuNPqvmi mQxGr1GVLvybEMmSYudQ6QY+BDqL50wvSx5BnJ8IqiS+Roo5d2laNo8UpuG58QGvS9z5NQ 98c+3FNE/mPyWinulyCJ2nK7WFwa02mDhBBO9n7BJHV76cabBhJbOOh8JTOEtJRvu2DFv8 ku3PARaoTBCeyrfpN8OI0USnXj20/jUO2cM+zkDdKlYfug2mJSsa7ys8A7sAqJw/yjqKPT KQ031gtjW5lkm+1WVYBtmxRGZwMKbFZlL2Sq3HlvJP2PCV9AiDLzRiJ5Z12r8w== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1783457878; a=rsa-sha256; cv=none; b=WBTTdGHnfnwUziq2hrx7OEFtuAbASgAgpiDuQ6Db5X5BTWsIhzKRRAWE4LzSy2svSCfZNM vO4V79Vet+SeH/1PkAUJ5Y+8138Ck+YdMCFTttagkZroYvN67oAm9Dimoh3LTg+vOfskAv 9dPrutitEKLijxW4Xy5fnevfKBA9Qb2MqVma9xqhnxC8j9PI7KG0ZZ70FpvdM+8W63crH3 DC9dDPUCYiGPlqx7VpI2eDMJWLKkp2AF7upIrvzImMPkW9KmS1LyOBxjjbl3Hbefs0vvwI D/onItqA+Q1Iw2csqKiOifzS/3Z4m/txcKDELuSNZaSd2rZrn5AQITqGIW2ivw== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1783457878; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=sIpl36ts4s0E3mnOI9B/AFHcx2D49/88PI828BuEZhE=; b=bcOB7IRY3AXx8muCpkXd2TioO1pI3jsavkX6TBAUY3CEV+F16YhpkJULdq1U+1jnfFvEpn 8mBDnaUBdZWg8L8hgo+X0tLn0LY5gT3IXxFISfi0wxRHqKTnTSUnfXYx254Nc3s8Jg3QsO Qc4Oz5HxnGvSHGX2H2qNPmICzxYw5edJnGxmWjW3ik81iLh5SHz6te2OFRL9Rds90nO1iq 1p92Qoye0CRr+9r0eRPqVnbnrICz3sJF7h8aUilz8UWeTIt9jQWqX40hg9JQnpkeKshqeG jr5eJwujEdemXfGnNiUMlImn4fz5SpvS7D/OapdO++ia8kY9dUT2/85warQ+HQ== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) by mxrelay.nyi.freebsd.org (Postfix) with ESMTP id 4gvtpt3z35zr4d for ; Tue, 07 Jul 2026 20:57:58 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from git (uid 1279) (envelope-from git@FreeBSD.org) id 183e1 by gitrepo.freebsd.org (DragonFly Mail Agent v0.13+ on gitrepo.freebsd.org); Tue, 07 Jul 2026 20:57:58 +0000 To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-branches@FreeBSD.org Cc: Siva Mahadevan From: Dag-Erling=?utf-8?Q? Sm=C3=B8rg?=rav Subject: git: f9f7b3aefab2 - stable/14 - ping: Fix bell char ordering in -A test cases List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: des X-Git-Repository: src X-Git-Refname: refs/heads/stable/14 X-Git-Reftype: branch X-Git-Commit: f9f7b3aefab21b77811ac84043adae1cb9f3cb61 Auto-Submitted: auto-generated Date: Tue, 07 Jul 2026 20:57:58 +0000 Message-Id: <6a4d6856.183e1.1b0abab9@gitrepo.freebsd.org> The branch stable/14 has been updated by des: URL: https://cgit.FreeBSD.org/src/commit/?id=f9f7b3aefab21b77811ac84043adae1cb9f3cb61 commit f9f7b3aefab21b77811ac84043adae1cb9f3cb61 Author: Siva Mahadevan AuthorDate: 2026-06-26 12:22:57 +0000 Commit: Dag-Erling Smørgrav CommitDate: 2026-07-07 07:07:56 +0000 ping: Fix bell char ordering in -A test cases Previously, these tests expected the bell chars to arrive before the initial status line. This appeared to be ok because ping(8) incorrectly mixed unbuffered and buffered writes by using printf(3) calls for the initial status, but direct write(2) calls for the bell chars. 141bb85798 revealed that the test's assertions only passed because the buffered writes did not get flushed before the direct writes in the test runs. 8bda488114f3 fixed ping(8) to use POSIX stdio buffered writes in all cases and guarantee a deterministic output ordering to stdout observers. This patch fixes the test to match the correct ordering. Reviewed by: des Sponsored by: The FreeBSD Foundation (cherry picked from commit 7ac9995a062ff9f78b634fe403e6a313f5637945) (cherry picked from commit 5b8c28adb829b50fb8ac065637fa99f717858bab) (cherry picked from commit f7f916d755fe5b48a2a68a937beea770b7bafa95) --- sbin/ping/tests/test_ping.py | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/sbin/ping/tests/test_ping.py b/sbin/ping/tests/test_ping.py index 3f9a3aecf924..60ddd3d751bf 100644 --- a/sbin/ping/tests/test_ping.py +++ b/sbin/ping/tests/test_ping.py @@ -407,8 +407,8 @@ round-trip min/avg/max/stddev = /// ms "args": "ping -A -c3 192.0.2.2", "returncode": 2, "stdout": """\ -\x07\x07PING 192.0.2.2 (192.0.2.2): 56 data bytes - +PING 192.0.2.2 (192.0.2.2): 56 data bytes +\x07\x07 --- 192.0.2.2 ping statistics --- 3 packets transmitted, 0 packets received, 100.0% packet loss """, @@ -439,8 +439,8 @@ round-trip min/avg/max/stddev = /// ms "args": "ping -A -c3 2001:db8::2", "returncode": 2, "stdout": """\ -\x07\x07PING(56=40+8+8 bytes) 2001:db8::1 --> 2001:db8::2 - +PING(56=40+8+8 bytes) 2001:db8::1 --> 2001:db8::2 +\x07\x07 --- 2001:db8::2 ping statistics --- 3 packets transmitted, 0 packets received, 100.0% packet loss """,