From owner-svn-src-head@freebsd.org Thu Dec 7 08:41:28 2017 Return-Path: Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 6FD3FE803FE; Thu, 7 Dec 2017 08:41:28 +0000 (UTC) (envelope-from hps@selasky.org) Received: from mail.turbocat.net (turbocat.net [IPv6:2a01:4f8:c17:6c4b::2]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 389007C6EE; Thu, 7 Dec 2017 08:41:28 +0000 (UTC) (envelope-from hps@selasky.org) Received: from hps2016.home.selasky.org (unknown [62.141.128.70]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.turbocat.net (Postfix) with ESMTPSA id 72B342603A1; Thu, 7 Dec 2017 09:41:25 +0100 (CET) Subject: Re: svn commit: r326169 - in head: . contrib/ofed lib/libc/locale share/mk sys/amd64/amd64 sys/amd64/conf sys/conf sys/contrib/rdma/krping sys/dev/cxgbe sys/dev/cxgbe/common sys/dev/cxgbe/iw_cxgbe sys/... To: Bryan Drewery , src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org References: <201711241450.vAOEoSFW056744@repo.freebsd.org> <0fec20d5-cb8f-4937-5dd0-54b8b7461772@selasky.org> <8e2fd368-ad3e-27bb-0834-4b6f2f99e905@FreeBSD.org> From: Hans Petter Selasky Message-ID: <53b6c65e-0e0e-0b18-9740-e97e11a5552f@selasky.org> Date: Thu, 7 Dec 2017 09:38:40 +0100 User-Agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:52.0) Gecko/20100101 Thunderbird/52.4.0 MIME-Version: 1.0 In-Reply-To: <8e2fd368-ad3e-27bb-0834-4b6f2f99e905@FreeBSD.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.25 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 07 Dec 2017 08:41:28 -0000 On 12/07/17 01:48, Bryan Drewery wrote: > 7. We don't put FreeBSD Makefiles in the same directory as contributed > files. It's against the pattern. So moving contrib/ofed/usr.lib/* to > contrib/ofed/*/ is wrong. It complicates future merges of contrib code. > Really none of these Makefiles should be in contrib/ofed - the proper > thing would be to move them out, not to inline them with the contributed > code. Hi, At the moment Mellanox is maintaining this code. Importing vendor code must be merged carefully using graphical tools like "meld". There is no simple C&P at the moment. Several of the utilities in OFED use automake or cmake to build. The Makefiles for FreeBSD must be created manually. This also include the associated config.h files. All the OFED utilities have been re-organized source-wise in upstream GITs since the last OFED user-space update. I'd like the Makefiles to stay in a similar tree as the source tree, so that figuring out which Makefile pull sources from which directory is more trivial instead of having to look into each and every one of them. Finally, Mellanox has sent out several mails to infiniband@freebsd.org and current@freebsd.org warning and telling we are going to merge. I've waited one week extra for input, but it has all been silent. That someone now should jump and say everything is wrong with the Makefiles and build infrastructure in OFED is simply not fair. It would be really helpful to me if you could be more responsive in the few weeks behind or at least say you're busy or on vacation. --HPS