Date: Thu, 22 Dec 2011 08:30:59 -0800 From: Adrian Chadd <adrian@freebsd.org> To: Dimitry Andric <dim@freebsd.org> Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org Subject: Re: svn commit: r228800 - in head/sys/dev/ath/ath_hal: ar5212 ar5416 Message-ID: <CAJ-VmomobqSEjMGkAyVwA1N0C0K2WurTR2W8f7fSoDAROe28QA@mail.gmail.com> In-Reply-To: <201112221409.pBME980v020110@svn.freebsd.org> References: <201112221409.pBME980v020110@svn.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
Just to be silly :) I reviewed this patchset early this morning and it's fi= ne. Nothing in the FreeBSD HAL uses the compression code, so unless someone out there has proprietary extensions which does, this patch is fine. I promise to get the AR5210 and AR5211 stuff tested tonight. The AR5210 at least works fine with -9 and -HEAD before the patch; the AR5211 is broken when trying to do WPA so I'll have to fix that first. Thanks, Adrian On 22 December 2011 06:09, Dimitry Andric <dim@freebsd.org> wrote: > Author: dim > Date: Thu Dec 22 14:09:08 2011 > New Revision: 228800 > URL: http://svn.freebsd.org/changeset/base/228800 > > Log: > =A0Revert r228786. =A0We'll need to work around the warnings in another w= ay. > > =A0Requested by: adrian > =A0MFC after: =A0 =A01 week > > Modified: > =A0head/sys/dev/ath/ath_hal/ar5212/ar5212_misc.c > =A0head/sys/dev/ath/ath_hal/ar5416/ar5416_misc.c > > Modified: head/sys/dev/ath/ath_hal/ar5212/ar5212_misc.c > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D > --- head/sys/dev/ath/ath_hal/ar5212/ar5212_misc.c =A0 =A0 =A0 Thu Dec 22 = 13:47:36 2011 =A0 =A0 =A0 =A0(r228799) > +++ head/sys/dev/ath/ath_hal/ar5212/ar5212_misc.c =A0 =A0 =A0 Thu Dec 22 = 14:09:08 2011 =A0 =A0 =A0 =A0(r228800) > @@ -574,7 +574,7 @@ ar5212SetDecompMask(struct ath_hal *ah, > =A0 =A0 =A0 =A0struct ath_hal_5212 *ahp =3D AH5212(ah); > > =A0 =A0 =A0 =A0 if (keyidx >=3D HAL_DECOMP_MASK_SIZE) > - =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0return AH_FALSE; > + =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0return HAL_EINVAL; > =A0 =A0 =A0 =A0 OS_REG_WRITE(ah, AR_DCM_A, keyidx); > =A0 =A0 =A0 =A0 OS_REG_WRITE(ah, AR_DCM_D, en ? AR_DCM_D_EN : 0); > =A0 =A0 =A0 =A0 ahp->ah_decompMask[keyidx] =3D en; > > Modified: head/sys/dev/ath/ath_hal/ar5416/ar5416_misc.c > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D > --- head/sys/dev/ath/ath_hal/ar5416/ar5416_misc.c =A0 =A0 =A0 Thu Dec 22 = 13:47:36 2011 =A0 =A0 =A0 =A0(r228799) > +++ head/sys/dev/ath/ath_hal/ar5416/ar5416_misc.c =A0 =A0 =A0 Thu Dec 22 = 14:09:08 2011 =A0 =A0 =A0 =A0(r228800) > @@ -161,7 +161,7 @@ ar5416SetAntennaSwitch(struct ath_hal *a > =A0HAL_BOOL > =A0ar5416SetDecompMask(struct ath_hal *ah, uint16_t keyidx, int en) > =A0{ > - =A0 =A0 =A0 return AH_TRUE; > + =A0 =A0 =A0 return HAL_OK; > =A0} > > =A0/* Setup coverage class */
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CAJ-VmomobqSEjMGkAyVwA1N0C0K2WurTR2W8f7fSoDAROe28QA>